Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Forward stdio and cause test failure

Browse source
This commit is contained in:
Adam Gastineau 2025-01-27 07:54:54 -08:00
parent e462d98fc6
commit ee7b0e6188
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tests/library/signals.spec.ts
View file

@ -26,7 +26,7 @@ test('should close the browser when the node process closes', async ({ startRemo
const remoteServer = await startRemoteServer('launchServer', { url: server.EMPTY_PAGE }); const remoteServer = await startRemoteServer('launchServer', { url: server.EMPTY_PAGE });
try { try {
if (isWindows) if (isWindows)
execSync(`taskkill /pid ${remoteServer.child().pid} /T /F`); execSync(`taskkill /pid ${remoteServer.child().pid} /T /F`, { stdio: 'inherit' });
else else
process.kill(remoteServer.child().pid); process.kill(remoteServer.child().pid);
} catch (error) { } catch (error) {
@ -40,6 +40,7 @@ test('should close the browser when the node process closes', async ({ startRemo
// We might not get browser exitCode in time when killing the parent node process, // We might not get browser exitCode in time when killing the parent node process,
// so we don't check it here. // so we don't check it here.
expect(await remoteServer.childExitCode()).toBe(isWindows ? 1 : 0); expect(await remoteServer.childExitCode()).toBe(isWindows ? 1 : 0);
expect(false).toBe(true);
}); });
test('should remove temp dir on process.exit', async ({ startRemoteServer, server, platform }, testInfo) => { test('should remove temp dir on process.exit', async ({ startRemoteServer, server, platform }, testInfo) => {