From ef0a24a1b0c2a8562ac0de0e081d5e566fa8e038 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Mon, 4 Mar 2024 20:12:01 +0100 Subject: [PATCH] chore: remove chromium-with-symbols build (#29807) --- .../trigger_build_chromium_with_symbols.yml | 30 ------------- packages/playwright-core/browsers.json | 6 --- .../src/server/registry/index.ts | 45 +------------------ 3 files changed, 2 insertions(+), 79 deletions(-) delete mode 100644 .github/workflows/trigger_build_chromium_with_symbols.yml diff --git a/.github/workflows/trigger_build_chromium_with_symbols.yml b/.github/workflows/trigger_build_chromium_with_symbols.yml deleted file mode 100644 index e0e31acd57..0000000000 --- a/.github/workflows/trigger_build_chromium_with_symbols.yml +++ /dev/null @@ -1,30 +0,0 @@ -name: "Trigger: Chromium with Symbols Builds" - -on: - workflow_dispatch: - release: - types: [published] - -jobs: - trigger: - name: "trigger" - runs-on: ubuntu-22.04 - steps: - - uses: actions/checkout@v2 - - uses: actions/setup-node@v2 - with: - node-version: 18 - - name: Get Chromium revision - id: chromium-version - run: | - REVISION=$(node -e "console.log(require('./packages/playwright-core/browsers.json').browsers.find(b => b.name === 'chromium-with-symbols').revision)") - echo "REVISION=$REVISION" >> $GITHUB_OUTPUT - - run: | - curl -X POST \ - -H "Accept: application/vnd.github.v3+json" \ - -H "Authorization: token ${GH_TOKEN}" \ - --data "{\"event_type\": \"build_chromium_with_symbols\", \"client_payload\": {\"revision\": \"${CHROMIUM_REVISION}\"}}" \ - https://api.github.com/repos/microsoft/playwright-browsers/dispatches - env: - GH_TOKEN: ${{ secrets.REPOSITORY_DISPATCH_PERSONAL_ACCESS_TOKEN }} - CHROMIUM_REVISION: ${{ steps.chromium-version.outputs.REVISION }} diff --git a/packages/playwright-core/browsers.json b/packages/playwright-core/browsers.json index 6927c9aa48..eb427e8df3 100644 --- a/packages/playwright-core/browsers.json +++ b/packages/playwright-core/browsers.json @@ -7,12 +7,6 @@ "installByDefault": true, "browserVersion": "123.0.6312.22" }, - { - "name": "chromium-with-symbols", - "revision": "1107", - "installByDefault": false, - "browserVersion": "123.0.6312.22" - }, { "name": "chromium-tip-of-tree", "revision": "1198", diff --git a/packages/playwright-core/src/server/registry/index.ts b/packages/playwright-core/src/server/registry/index.ts index fa3a1bbf78..c3547c1118 100644 --- a/packages/playwright-core/src/server/registry/index.ts +++ b/packages/playwright-core/src/server/registry/index.ts @@ -121,29 +121,6 @@ const DOWNLOAD_PATHS: Record = { 'mac13-arm64': 'builds/chromium-tip-of-tree/%s/chromium-tip-of-tree-mac-arm64.zip', 'win64': 'builds/chromium-tip-of-tree/%s/chromium-tip-of-tree-win64.zip', }, - 'chromium-with-symbols': { - '': undefined, - 'ubuntu18.04-x64': undefined, - 'ubuntu20.04-x64': 'builds/chromium/%s/chromium-with-symbols-linux.zip', - 'ubuntu22.04-x64': 'builds/chromium/%s/chromium-with-symbols-linux.zip', - 'ubuntu18.04-arm64': undefined, - 'ubuntu20.04-arm64': 'builds/chromium/%s/chromium-with-symbols-linux-arm64.zip', - 'ubuntu22.04-arm64': 'builds/chromium/%s/chromium-with-symbols-linux-arm64.zip', - 'debian11-x64': 'builds/chromium/%s/chromium-with-symbols-linux.zip', - 'debian11-arm64': 'builds/chromium/%s/chromium-with-symbols-linux-arm64.zip', - 'debian12-x64': 'builds/chromium/%s/chromium-with-symbols-linux.zip', - 'debian12-arm64': 'builds/chromium/%s/chromium-with-symbols-linux-arm64.zip', - 'mac10.13': 'builds/chromium/%s/chromium-with-symbols-mac.zip', - 'mac10.14': 'builds/chromium/%s/chromium-with-symbols-mac.zip', - 'mac10.15': 'builds/chromium/%s/chromium-with-symbols-mac.zip', - 'mac11': 'builds/chromium/%s/chromium-with-symbols-mac.zip', - 'mac11-arm64': 'builds/chromium/%s/chromium-with-symbols-mac-arm64.zip', - 'mac12': 'builds/chromium/%s/chromium-with-symbols-mac.zip', - 'mac12-arm64': 'builds/chromium/%s/chromium-with-symbols-mac-arm64.zip', - 'mac13': 'builds/chromium/%s/chromium-with-symbols-mac.zip', - 'mac13-arm64': 'builds/chromium/%s/chromium-with-symbols-mac-arm64.zip', - 'win64': 'builds/chromium/%s/chromium-with-symbols-win64.zip', - }, 'firefox': { '': undefined, 'ubuntu18.04-x64': undefined, @@ -368,9 +345,9 @@ function readDescriptors(browsersJSON: BrowsersJSON) { } export type BrowserName = 'chromium' | 'firefox' | 'webkit'; -type InternalTool = 'ffmpeg' | 'firefox-beta' | 'firefox-asan' | 'chromium-with-symbols' | 'chromium-tip-of-tree' | 'android'; +type InternalTool = 'ffmpeg' | 'firefox-beta' | 'firefox-asan' | 'chromium-tip-of-tree' | 'android'; type ChromiumChannel = 'chrome' | 'chrome-beta' | 'chrome-dev' | 'chrome-canary' | 'msedge' | 'msedge-beta' | 'msedge-dev' | 'msedge-canary'; -const allDownloadable = ['chromium', 'firefox', 'webkit', 'ffmpeg', 'firefox-beta', 'chromium-with-symbols', 'chromium-tip-of-tree']; +const allDownloadable = ['chromium', 'firefox', 'webkit', 'ffmpeg', 'firefox-beta', 'chromium-tip-of-tree']; export interface Executable { type: 'browser' | 'tool' | 'channel'; @@ -453,24 +430,6 @@ export class Registry { _isHermeticInstallation: true, }); - const chromiumWithSymbols = descriptors.find(d => d.name === 'chromium-with-symbols')!; - const chromiumWithSymbolsExecutable = findExecutablePath(chromiumWithSymbols.dir, 'chromium'); - this._executables.push({ - type: 'tool', - name: 'chromium-with-symbols', - browserName: 'chromium', - directory: chromiumWithSymbols.dir, - executablePath: () => chromiumWithSymbolsExecutable, - executablePathOrDie: (sdkLanguage: string) => executablePathOrDie('chromium-with-symbols', chromiumWithSymbolsExecutable, chromiumWithSymbols.installByDefault, sdkLanguage), - installType: chromiumWithSymbols.installByDefault ? 'download-by-default' : 'download-on-demand', - _validateHostRequirements: (sdkLanguage: string) => this._validateHostRequirements(sdkLanguage, 'chromium', chromiumWithSymbols.dir, ['chrome-linux'], [], ['chrome-win']), - downloadURLs: this._downloadURLs(chromiumWithSymbols), - browserVersion: chromiumWithSymbols.browserVersion, - _install: () => this._downloadExecutable(chromiumWithSymbols, chromiumWithSymbolsExecutable), - _dependencyGroup: 'chromium', - _isHermeticInstallation: true, - }); - const chromiumTipOfTree = descriptors.find(d => d.name === 'chromium-tip-of-tree')!; const chromiumTipOfTreeExecutable = findExecutablePath(chromiumTipOfTree.dir, 'chromium'); this._executables.push({