From f02b89be0b89b9f33aab4bc5f4c13c3cd17191e1 Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Mon, 9 Sep 2024 16:53:04 +0200 Subject: [PATCH] one more rename --- packages/playwright-core/src/server/trace/recorder/tracing.ts | 2 +- packages/trace-viewer/src/entries.ts | 2 +- packages/trace-viewer/src/ui/snapshotTab.tsx | 4 ++-- packages/trace/src/trace.ts | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/playwright-core/src/server/trace/recorder/tracing.ts b/packages/playwright-core/src/server/trace/recorder/tracing.ts index 2b76134e0c..f72c97709f 100644 --- a/packages/playwright-core/src/server/trace/recorder/tracing.ts +++ b/packages/playwright-core/src/server/trace/recorder/tracing.ts @@ -473,7 +473,7 @@ export class Tracing extends SdkObject implements InstrumentationListener, Snaps width: params.width, height: params.height, timestamp: monotonicTime(), - frameSwapTimestamp: params.timestamp, + frameSwapWallTime: params.timestamp, }; // Make sure to write the screencast frame before adding a reference to it. this._appendResource(sha1, params.buffer); diff --git a/packages/trace-viewer/src/entries.ts b/packages/trace-viewer/src/entries.ts index 98f7eef78f..dbfec63be8 100644 --- a/packages/trace-viewer/src/entries.ts +++ b/packages/trace-viewer/src/entries.ts @@ -45,7 +45,7 @@ export type PageEntry = { screencastFrames: { sha1: string, timestamp: number, - frameSwapTimestamp?: number, + frameSwapWallTime?: number, width: number, height: number, }[]; diff --git a/packages/trace-viewer/src/ui/snapshotTab.tsx b/packages/trace-viewer/src/ui/snapshotTab.tsx index f66f723c52..d49f6b575d 100644 --- a/packages/trace-viewer/src/ui/snapshotTab.tsx +++ b/packages/trace-viewer/src/ui/snapshotTab.tsx @@ -170,8 +170,8 @@ export const SnapshotTab: React.FunctionComponent<{ const page = action ? pageForAction(action) : undefined; const screencastFrame = React.useMemo( () => { - if (snapshotInfo.wallTime && page?.screencastFrames[0]?.frameSwapTimestamp) - return findClosest(page.screencastFrames, frame => frame.frameSwapTimestamp!, snapshotInfo.wallTime); + if (snapshotInfo.wallTime && page?.screencastFrames[0]?.frameSwapWallTime) + return findClosest(page.screencastFrames, frame => frame.frameSwapWallTime!, snapshotInfo.wallTime); if (snapshotInfo.timestamp && page?.screencastFrames) return findClosest(page.screencastFrames, frame => frame.timestamp, snapshotInfo.timestamp); diff --git a/packages/trace/src/trace.ts b/packages/trace/src/trace.ts index ae3b777ed0..81fc4ab428 100644 --- a/packages/trace/src/trace.ts +++ b/packages/trace/src/trace.ts @@ -53,7 +53,7 @@ export type ScreencastFrameTraceEvent = { width: number, height: number, timestamp: number, - frameSwapTimestamp?: number, // milliseconds since epoch + frameSwapWallTime?: number, }; export type BeforeActionTraceEvent = {