Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: trim multiline step titles to first line (#31269)

Browse source 
Fixes https://github.com/microsoft/playwright/issues/31266
This commit is contained in:
Yury Semikhatsky 2024-06-12 08:24:12 -07:00 committed by GitHub
parent 6a7bfe63a1
commit f1475fa644
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 23 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright/src/reporters/base.ts
View file

@ -414,7 +414,7 @@ function relativeTestPath(config: FullConfig, test: TestCase): string {
export function stepSuffix(step: TestStep | undefined) {
const stepTitles = step ? step.titlePath() : [];
return stepTitles.map(t => ' › ' + t).join('');
return stepTitles.map(t => t.split('\n')[0]).map(t => ' › ' + t).join('');
}
export function formatTestTitle(config: FullConfig, test: TestCase, step?: TestStep, omitLocation: boolean = false): string {

22
tests/playwright-test/reporter-line.spec.ts
View file

@ -109,6 +109,28 @@ for (const useIntermediateMergeReport of [false, true] as const) {
].join('\n'));
});
test('should trim multiline step titles to first line', {
annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/31266' }
}, async ({ runInlineTest }) => {
const result = await runInlineTest({
'a.test.ts': `
import { test, expect } from '@playwright/test';
test('passes', async ({}) => {
await test.step(\`outer
1.0\`, async () => {
await test.step(\`inner
1.1\`, async () => {
expect(1).toBe(1);
});
});
});
`,
}, { reporter: 'line' });
const text = result.output;
expect(text).toContain('[1/1] a.test.ts:6:26 › passes › outer › inner');
expect(result.exitCode).toBe(0);
});
test('should render failed test steps', async ({ runInlineTest }) => {
const result = await runInlineTest({
'a.test.ts': `