Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feat(webkit): roll webkit to 1076 (#431)

Browse source
This commit is contained in:
Joel Einbinder 2020-01-08 15:34:35 -08:00 committed by Yury Semikhatsky
parent b6f1b17906
commit f161a36a16
4 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -10,7 +10,7 @@
"playwright": { "playwright": {
"chromium_revision": "724623", "chromium_revision": "724623",
"firefox_revision": "1009", "firefox_revision": "1009",
"webkit_revision": "1070" "webkit_revision": "1076"
}, },
"scripts": { "scripts": {
"unit": "node test/test.js", "unit": "node test/test.js",

3
src/server/wkPlaywright.ts
View file

@ -120,8 +120,7 @@ export class WKPlaywright {
webkitExecutable = executablePath; webkitExecutable = executablePath;
} }
webkitArguments.push('--inspector-pipe'); webkitArguments.push('--inspector-pipe');
// Headless options is only implemented on Mac at the moment. if (options.headless !== false)
if (process.platform === 'darwin' && options.headless !== false)
webkitArguments.push('--headless'); webkitArguments.push('--headless');
let connectOptions: WKConnectOptions | undefined = undefined; let connectOptions: WKConnectOptions | undefined = undefined;

4
src/webkit/wkNetworkManager.ts
View file

@ -57,7 +57,7 @@ export class WKNetworkManager {
const promises = []; const promises = [];
promises.push(session.send('Network.enable')); promises.push(session.send('Network.enable'));
if (interceptNetwork) if (interceptNetwork)
promises.push(session.send('Network.setInterceptionEnabled', { enabled: true })); promises.push(session.send('Network.setInterceptionEnabled', { enabled: true, interceptRequests: true }));
if (offlineMode) if (offlineMode)
promises.push(session.send('Network.setEmulateOfflineState', { offline: true })); promises.push(session.send('Network.setEmulateOfflineState', { offline: true }));
await Promise.all(promises); await Promise.all(promises);
@ -73,7 +73,7 @@ export class WKNetworkManager {
} }
async setRequestInterception(enabled: boolean): Promise<void> { async setRequestInterception(enabled: boolean): Promise<void> {
await this._session.send('Network.setInterceptionEnabled', { enabled }); await this._session.send('Network.setInterceptionEnabled', { enabled, interceptRequests: enabled });
} }
async _updateProtocolCacheDisabled() { async _updateProtocolCacheDisabled() {

4
test/geolocation.spec.js
View file

@ -15,14 +15,14 @@
* limitations under the License. * limitations under the License.
*/ */
module.exports.describe = function ({ testRunner, expect, FFOX }) { module.exports.describe = function ({ testRunner, expect, FFOX, WEBKIT }) {
const {describe, xdescribe, fdescribe} = testRunner; const {describe, xdescribe, fdescribe} = testRunner;
const {it, fit, xit, dit} = testRunner; const {it, fit, xit, dit} = testRunner;
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner; const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
// FIXME: not supported in WebKit (as well as Emulation domain in general). // FIXME: not supported in WebKit (as well as Emulation domain in general).
// It was removed from WebKit in https://webkit.org/b/126630 // It was removed from WebKit in https://webkit.org/b/126630
describe.skip(FFOX)('Overrides.setGeolocation', function() { describe.skip(FFOX || WEBKIT)('Overrides.setGeolocation', function() {
it('should work', async({page, server, context}) => { it('should work', async({page, server, context}) => {
await context.setPermissions(server.PREFIX, ['geolocation']); await context.setPermissions(server.PREFIX, ['geolocation']);
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);