Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: include call log into browerType.launchServer TimeoutError (#11956)

Browse source
This commit is contained in:
Yury Semikhatsky 2022-02-09 09:54:16 -08:00 committed by GitHub
parent 40b4218962
commit f2773fbb3a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
packages/playwright-core/src/browserServerImpl.ts
View file

@ -34,6 +34,8 @@ import { BrowserContext } from './server/browserContext';
import { CRBrowser } from './server/chromium/crBrowser'; import { CRBrowser } from './server/chromium/crBrowser';
import { CDPSessionDispatcher } from './dispatchers/cdpSessionDispatcher'; import { CDPSessionDispatcher } from './dispatchers/cdpSessionDispatcher';
import { PageDispatcher } from './dispatchers/pageDispatcher'; import { PageDispatcher } from './dispatchers/pageDispatcher';
import { helper } from './server/helper';
import { rewriteErrorMessage } from './utils/stackTrace';
export class BrowserServerLauncherImpl implements BrowserServerLauncher { export class BrowserServerLauncherImpl implements BrowserServerLauncher {
private _browserName: 'chromium' | 'firefox' | 'webkit'; private _browserName: 'chromium' | 'firefox' | 'webkit';
@ -45,12 +47,17 @@ export class BrowserServerLauncherImpl implements BrowserServerLauncher {
async launchServer(options: LaunchServerOptions = {}): Promise<BrowserServer> { async launchServer(options: LaunchServerOptions = {}): Promise<BrowserServer> {
const playwright = createPlaywright('javascript'); const playwright = createPlaywright('javascript');
// 1. Pre-launch the browser // 1. Pre-launch the browser
const browser = await playwright[this._browserName].launch(internalCallMetadata(), { const metadata = internalCallMetadata();
const browser = await playwright[this._browserName].launch(metadata, {
...options, ...options,
ignoreDefaultArgs: Array.isArray(options.ignoreDefaultArgs) ? options.ignoreDefaultArgs : undefined, ignoreDefaultArgs: Array.isArray(options.ignoreDefaultArgs) ? options.ignoreDefaultArgs : undefined,
ignoreAllDefaultArgs: !!options.ignoreDefaultArgs && !Array.isArray(options.ignoreDefaultArgs), ignoreAllDefaultArgs: !!options.ignoreDefaultArgs && !Array.isArray(options.ignoreDefaultArgs),
env: options.env ? envObjectToArray(options.env) : undefined, env: options.env ? envObjectToArray(options.env) : undefined,
}, toProtocolLogger(options.logger)); }, toProtocolLogger(options.logger)).catch(e => {
const log = helper.formatBrowserLogs(metadata.log);
rewriteErrorMessage(e, `${e.message} Failed to launch browser.${log}`);
throw e;
});
let path = `/${createGuid()}`; let path = `/${createGuid()}`;
if (options.wsPath) if (options.wsPath)