Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: enable flaky worker tests on Firefox (#1548)

Browse source 
Drive-by: remove dead websocket test.
This commit is contained in:
Andrey Lushnikov 2020-03-25 22:46:27 -07:00 committed by GitHub
parent 81bd8de00b
commit f2d72b3d95
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -9,7 +9,7 @@
"main": "index.js", "main": "index.js",
"playwright": { "playwright": {
"chromium_revision": "751710", "chromium_revision": "751710",
"firefox_revision": "1057", "firefox_revision": "1058",
"webkit_revision": "1182" "webkit_revision": "1182"
}, },
"scripts": { "scripts": {

2
test/test.js
View file

@ -85,7 +85,7 @@ const BROWSER_CONFIGS = [
...require('../lib/events').Events, ...require('../lib/events').Events,
...require('../lib/chromium/events').Events, ...require('../lib/chromium/events').Events,
}, },
missingCoverage: ['browserContext.setGeolocation', 'browserContext.setOffline', 'worker.url', 'cDPSession.send', 'cDPSession.detach'], missingCoverage: ['browserContext.setGeolocation', 'browserContext.setOffline', 'cDPSession.send', 'cDPSession.detach'],
}, },
{ {
name: 'WebKit', name: 'WebKit',

26
test/workers.spec.js
View file

@ -27,8 +27,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT,
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner; const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
describe('Workers', function() { describe('Workers', function() {
// flaky: https://github.com/microsoft/playwright/pull/1297/checks?check_run_id=496348690 it('Page.workers', async function({page, server}) {
it.fail(FFOX && LINUX)('Page.workers', async function({page, server}) {
await Promise.all([ await Promise.all([
page.waitForEvent('worker'), page.waitForEvent('worker'),
page.goto(server.PREFIX + '/worker/worker.html')]); page.goto(server.PREFIX + '/worker/worker.html')]);
@ -102,8 +101,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT,
expect(destroyed).toBe(true); expect(destroyed).toBe(true);
expect(page.workers().length).toBe(0); expect(page.workers().length).toBe(0);
}); });
// flaky: https://github.com/microsoft/playwright/pull/1277/checks?check_run_id=496461538 it('should report network activity', async function({page, server}) {
it.fail(FFOX && LINUX)('should report network activity', async function({page, server}) {
const [worker] = await Promise.all([ const [worker] = await Promise.all([
page.waitForEvent('worker'), page.waitForEvent('worker'),
page.goto(server.PREFIX + '/worker/worker.html'), page.goto(server.PREFIX + '/worker/worker.html'),
@ -133,25 +131,5 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT,
expect(response.request()).toBe(request); expect(response.request()).toBe(request);
expect(response.ok()).toBe(true); expect(response.ok()).toBe(true);
}); });
false && it.fail(FFOX)('should report web socket activity', async function({page, server}) {
const [worker] = await Promise.all([
page.waitForEvent('worker'),
page.goto(server.PREFIX + '/worker/worker.html'),
]);
const log = [];
let socketClosed;
const socketClosePromise = new Promise(f => socketClosed = f);
page.on('websocket', ws => {
ws.on('open', () => log.push(`open<${ws.url()}>`));
ws.on('close', () => { log.push('close'); socketClosed(); });
});
worker.evaluate((port) => {
const ws = new WebSocket('ws://localhost:' + port + '/ws');
ws.addEventListener('open', () => ws.close());
}, server.PORT);
await socketClosePromise;
expect(log.join(':')).toBe(`open<ws://localhost:${server.PORT}/ws>:close`);
});
}); });
}; };