Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

browser(firefox): focus all top frames by default (#1811)

Browse source
This commit is contained in:
Yury Semikhatsky 2020-04-15 15:22:47 -07:00 committed by GitHub
parent 88054e34c9
commit f3451d9148
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
browser_patches/firefox/BUILD_NUMBER
View file

@ -1 +1 @@
1080 1081

21
browser_patches/firefox/patches/bootstrap.diff
View file

@ -2329,10 +2329,10 @@ index 0000000000000000000000000000000000000000..ba34976ad05e7f5f1a99777f76ac08b1
+this.SimpleChannel = SimpleChannel; +this.SimpleChannel = SimpleChannel;
diff --git a/juggler/TargetRegistry.js b/juggler/TargetRegistry.js diff --git a/juggler/TargetRegistry.js b/juggler/TargetRegistry.js
new file mode 100644 new file mode 100644
index 0000000000000000000000000000000000000000..77eda904d6130ab120d8a52802ff010f537585c2 index 0000000000000000000000000000000000000000..5f10371dc2f2a921cd5df2b9b038bd1a6cec2533
--- /dev/null --- /dev/null
+++ b/juggler/TargetRegistry.js +++ b/juggler/TargetRegistry.js
@@ -0,0 +1,670 @@ @@ -0,0 +1,664 @@
+const {EventEmitter} = ChromeUtils.import('resource://gre/modules/EventEmitter.jsm'); +const {EventEmitter} = ChromeUtils.import('resource://gre/modules/EventEmitter.jsm');
+const {Helper} = ChromeUtils.import('chrome://juggler/content/Helper.js'); +const {Helper} = ChromeUtils.import('chrome://juggler/content/Helper.js');
+const {SimpleChannel} = ChromeUtils.import('chrome://juggler/content/SimpleChannel.js'); +const {SimpleChannel} = ChromeUtils.import('chrome://juggler/content/SimpleChannel.js');
@ -2622,8 +2622,6 @@ index 0000000000000000000000000000000000000000..77eda904d6130ab120d8a52802ff010f
+ } + }
+ }); + });
+ }); + });
+ // Enforce focused state for all top level documents created via newPage.
+ target.setFocused();
+ if (created) { + if (created) {
+ window.gBrowser.removeTab(window.gBrowser.getTabForBrowser(window.gBrowser.getBrowserAtIndex(0)), { + window.gBrowser.removeTab(window.gBrowser.getTabForBrowser(window.gBrowser.getBrowserAtIndex(0)), {
+ skipPermitUnload: true, + skipPermitUnload: true,
@ -2773,10 +2771,6 @@ index 0000000000000000000000000000000000000000..77eda904d6130ab120d8a52802ff010f
+ return await this._channel.connect('').send('hasFailedToOverrideTimezone').catch(e => true); + return await this._channel.connect('').send('hasFailedToOverrideTimezone').catch(e => true);
+ } + }
+ +
+ async setFocused() {
+ await this._channel.connect('').send('setFocused').catch(e => true);
+ }
+
+ dispose() { + dispose() {
+ this._disposed = true; + this._disposed = true;
+ if (this._browserContext) + if (this._browserContext)
@ -5363,10 +5357,10 @@ index 0000000000000000000000000000000000000000..3a386425d3796d0a6786dea193b3402d
+ +
diff --git a/juggler/content/main.js b/juggler/content/main.js diff --git a/juggler/content/main.js b/juggler/content/main.js
new file mode 100644 new file mode 100644
index 0000000000000000000000000000000000000000..2cb662684cbcf3b9feffda9ba8eef63aead39e39 index 0000000000000000000000000000000000000000..848b8daab8655df61ba2aaebc1abf02ffdc94b6d
--- /dev/null --- /dev/null
+++ b/juggler/content/main.js +++ b/juggler/content/main.js
@@ -0,0 +1,166 @@ @@ -0,0 +1,165 @@
+const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm"); +const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
+const {Helper} = ChromeUtils.import('chrome://juggler/content/Helper.js'); +const {Helper} = ChromeUtils.import('chrome://juggler/content/Helper.js');
+const {FrameTree} = ChromeUtils.import('chrome://juggler/content/content/FrameTree.js'); +const {FrameTree} = ChromeUtils.import('chrome://juggler/content/content/FrameTree.js');
@ -5458,6 +5452,9 @@ index 0000000000000000000000000000000000000000..2cb662684cbcf3b9feffda9ba8eef63a
+ scrollbarManager.setFloatingScrollbars(viewport.isMobile); + scrollbarManager.setFloatingScrollbars(viewport.isMobile);
+ } + }
+ +
+ // Enforce focused state for all top level documents.
+ docShell.overrideHasFocus = true;
+
+ frameTree = new FrameTree(docShell); + frameTree = new FrameTree(docShell);
+ if (colorScheme !== undefined) + if (colorScheme !== undefined)
+ frameTree.setColorScheme(colorScheme); + frameTree.setColorScheme(colorScheme);
@ -5505,10 +5502,6 @@ index 0000000000000000000000000000000000000000..2cb662684cbcf3b9feffda9ba8eef63a
+ // noop, just a rountrip. + // noop, just a rountrip.
+ }, + },
+ +
+ setFocused() {
+ docShell.overrideHasFocus = true;
+ },
+
+ hasFailedToOverrideTimezone() { + hasFailedToOverrideTimezone() {
+ return failedToOverrideTimezone; + return failedToOverrideTimezone;
+ }, + },