Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test(har): uncomment some raw header tests (#4273)

Browse source
This commit is contained in:
Pavel Feldman 2020-10-28 15:58:45 -07:00 committed by GitHub
parent efdb15470c
commit f384a864a8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/server/network.ts
View file

@ -183,6 +183,11 @@ export class Request {
this._headersMap.clear(); this._headersMap.clear();
for (const { name, value } of this._headers) for (const { name, value } of this._headers)
this._headersMap.set(name.toLowerCase(), value); this._headersMap.set(name.toLowerCase(), value);
if (!this._headersMap.has('host')) {
const host = new URL(this._url).host;
this._headers.push({ name: 'host', value: host });
this._headersMap.set('host', host);
}
} }
} }

4
test/network-request.spec.ts
View file

@ -82,7 +82,7 @@ it('should return headers', async ({page, server, isChromium, isFirefox, isWebKi
}); });
it('should get the same headers as the server', (test, { browserName, platform }) => { it('should get the same headers as the server', (test, { browserName, platform }) => {
test.fail(browserName === 'webkit' && platform !== 'darwin', 'Provisional headers differ from those in network stack'); test.fail(browserName === 'webkit' && platform === 'win32', 'Curl does not show accept-encoding and accept-language');
}, async ({ page, server }) => { }, async ({ page, server }) => {
let serverRequest; let serverRequest;
server.setRoute('/empty.html', (request, response) => { server.setRoute('/empty.html', (request, response) => {
@ -94,7 +94,7 @@ it('should get the same headers as the server', (test, { browserName, platform }
}); });
it('should get the same headers as the server CORP', (test, { browserName, platform }) => { it('should get the same headers as the server CORP', (test, { browserName, platform }) => {
test.fail(browserName === 'webkit' && platform !== 'darwin', 'Provisional headers differ from those in network stack'); test.fail(browserName === 'webkit' && platform === 'win32', 'Curl does not show accept-encoding and accept-language');
}, async ({page, server}) => { }, async ({page, server}) => {
await page.goto(server.PREFIX + '/empty.html'); await page.goto(server.PREFIX + '/empty.html');
let serverRequest; let serverRequest;

2
test/resource-timing.spec.ts
View file

@ -48,7 +48,7 @@ it('should work for subresource', async ({ page, server, isWindows, isWebKit })
expect(timing.secureConnectionStart).toBe(-1); expect(timing.secureConnectionStart).toBe(-1);
expect(timing.connectEnd).toBeGreaterThan(timing.secureConnectionStart); expect(timing.connectEnd).toBeGreaterThan(timing.secureConnectionStart);
} else { } else {
expect(timing.domainLookupStart).toBe(-1); expect(timing.domainLookupStart === 0 || timing.domainLookupStart === -1).toBeTruthy();
expect(timing.domainLookupEnd).toBe(-1); expect(timing.domainLookupEnd).toBe(-1);
expect(timing.connectStart).toBe(-1); expect(timing.connectStart).toBe(-1);
expect(timing.secureConnectionStart).toBe(-1); expect(timing.secureConnectionStart).toBe(-1);