Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

browser(webkit): exit inspector pause loop when page closes (#13185)

Browse source
This commit is contained in:
Yury Semikhatsky 2022-03-30 12:13:44 -07:00 committed by GitHub
parent c200321402
commit f45656aa5d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
browser_patches/webkit/BUILD_NUMBER
View file

@ -1,2 +1,2 @@
1622
Changed: yurys@chromium.org Tue 29 Mar 2022 08:03:00 PM PDT
1623
Changed: yurys@chromium.org Wed 30 Mar 2022 12:13:18 PM PDT

24
browser_patches/webkit/patches/bootstrap.diff
View file

@ -2918,10 +2918,28 @@ index a2906d7ce7a65e1ac4ceaf8e6426e1d013469e44..7e9aec8d1acc676e502cfb7c86ed9594
return;
diff --git a/Source/WebCore/inspector/InspectorController.cpp b/Source/WebCore/inspector/InspectorController.cpp
index ea02ba6e973b974da0c4a2985ed057a6c62f2b37..559b14d71f32a086d2631eee7880880c9b341a00 100644
index ea02ba6e973b974da0c4a2985ed057a6c62f2b37..8574670b289d5fc5c57b60c8b261199ddc1eb4c3 100644
--- a/Source/WebCore/inspector/InspectorController.cpp
+++ b/Source/WebCore/inspector/InspectorController.cpp
@@ -392,8 +392,8 @@ void InspectorController::inspect(Node* node)
@@ -285,6 +285,8 @@ void InspectorController::disconnectFrontend(FrontendChannel& frontendChannel)
// Unplug all instrumentations since they aren't needed now.
InspectorInstrumentation::unregisterInstrumentingAgents(m_instrumentingAgents.get());
+
+ m_pauseWhenShown = false;
}
m_inspectorClient->frontendCountChanged(m_frontendRouter->frontendCount());
@@ -304,6 +306,8 @@ void InspectorController::disconnectAllFrontends()
// The frontend should call setInspectorFrontendClient(nullptr) under closeWindow().
ASSERT(!m_inspectorFrontendClient);
+ m_pauseWhenShown = false;
+
if (!m_frontendRouter->hasFrontends())
return;
@@ -392,8 +396,8 @@ void InspectorController::inspect(Node* node)
if (!enabled())
return;
@ -2932,7 +2950,7 @@ index ea02ba6e973b974da0c4a2985ed057a6c62f2b37..559b14d71f32a086d2631eee7880880c
ensureDOMAgent().inspect(node);
}
@@ -534,4 +534,24 @@ void InspectorController::didComposite(Frame& frame)
@@ -534,4 +538,24 @@ void InspectorController::didComposite(Frame& frame)
InspectorInstrumentation::didComposite(frame);
}