From f4640d145fa8572ba1fd782a4393266910a36f0f Mon Sep 17 00:00:00 2001 From: Joel Einbinder Date: Thu, 30 Jan 2020 13:38:24 -0800 Subject: [PATCH] Revert "tests(accessibility): Remove unused browser goldens (#758)" (#763) Not dead code, this caused these tests to fail in firefox. Reverts #758 --- test/accessibility.spec.js | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/test/accessibility.spec.js b/test/accessibility.spec.js index e5bb8bd9df..64ab278d4a 100644 --- a/test/accessibility.spec.js +++ b/test/accessibility.spec.js @@ -234,10 +234,18 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT, this is the inner content yo `); - const golden = { + const golden = FFOX ? { + role: 'textbox', + name: 'my favorite textbox', + value: 'this is the inner content yo' + } : CHROMIUM ? { role: 'textbox', name: 'my favorite textbox', value: 'this is the inner content ' + } : { + role: 'textbox', + name: 'my favorite textbox', + value: 'this is the inner content ', }; const snapshot = await page.accessibility.snapshot(); expect(snapshot.children[0]).toEqual(golden); @@ -262,7 +270,11 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT, this is the inner content yo `); - const golden = { + const golden = FFOX ? { + role: 'checkbox', + name: 'this is the inner content yo', + checked: true + } : { role: 'checkbox', name: 'this is the inner content yo', checked: true