Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: make wheel event work on different host dsf (#14123)

Browse source 
Turns out, different mac bots have different device scale factor.
This commit is contained in:
Dmitry Gozman 2022-05-12 17:29:03 +01:00 committed by GitHub
parent c5face5ecc
commit f562058805
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 27 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
tests/page/wheel.spec.ts
View file

@ -21,26 +21,39 @@ it.skip(({ isElectron, browserMajorVersion, isAndroid }) => {
return (isElectron && browserMajorVersion <= 11) || isAndroid; return (isElectron && browserMajorVersion <= 11) || isAndroid;
}); });
let deltaScale = 1; let ignoreDelta = false;
it.beforeAll(async ({ browserMajorVersion, browserName, platform }) => { it.beforeAll(async ({ browserMajorVersion, browserName, platform }) => {
if (browserName === 'chromium' && browserMajorVersion >= 102 && platform === 'darwin') { if (browserName === 'chromium' && browserMajorVersion >= 102 && platform === 'darwin') {
// Chromium reports deltaX/deltaY scaled by host device scale factor. // Chromium reports deltaX/deltaY scaled by host device scale factor.
// https://bugs.chromium.org/p/chromium/issues/detail?id=1324819 // https://bugs.chromium.org/p/chromium/issues/detail?id=1324819
// https://github.com/microsoft/playwright/issues/7362 // https://github.com/microsoft/playwright/issues/7362
deltaScale = 2; // Different bots have different scale factors (usually 1 or 2), so we just ignore the values
// instead of guessing the host scale factor.
ignoreDelta = true;
} }
}); });
async function expectEvent(page: Page, expected: any) {
const received = await page.evaluate('window.lastEvent') as any;
if (ignoreDelta) {
delete received.deltaX;
delete received.deltaY;
delete expected.deltaX;
delete expected.deltaY;
}
expect(received).toEqual(expected);
}
it('should dispatch wheel events @smoke', async ({ page, server }) => { it('should dispatch wheel events @smoke', async ({ page, server }) => {
await page.setContent(`<div style="width: 5000px; height: 5000px;"></div>`); await page.setContent(`<div style="width: 5000px; height: 5000px;"></div>`);
await page.mouse.move(50, 60); await page.mouse.move(50, 60);
await listenForWheelEvents(page, 'div'); await listenForWheelEvents(page, 'div');
await page.mouse.wheel(0, 100); await page.mouse.wheel(0, 100);
await page.waitForFunction('window.scrollY === 100'); await page.waitForFunction('window.scrollY === 100');
expect(await page.evaluate('window.lastEvent')).toEqual({ await expectEvent(page, {
deltaX: 0 * deltaScale, deltaX: 0,
deltaY: 100 * deltaScale, deltaY: 100,
clientX: 50, clientX: 50,
clientY: 60, clientY: 60,
deltaMode: 0, deltaMode: 0,
@ -64,9 +77,9 @@ it('should set the modifiers', async ({ page }) => {
await listenForWheelEvents(page, 'div'); await listenForWheelEvents(page, 'div');
await page.keyboard.down('Shift'); await page.keyboard.down('Shift');
await page.mouse.wheel(0, 100); await page.mouse.wheel(0, 100);
expect(await page.evaluate('window.lastEvent')).toEqual({ await expectEvent(page, {
deltaX: 0 * deltaScale, deltaX: 0,
deltaY: 100 * deltaScale, deltaY: 100,
clientX: 50, clientX: 50,
clientY: 60, clientY: 60,
deltaMode: 0, deltaMode: 0,
@ -82,9 +95,9 @@ it('should scroll horizontally', async ({ page }) => {
await page.mouse.move(50, 60); await page.mouse.move(50, 60);
await listenForWheelEvents(page, 'div'); await listenForWheelEvents(page, 'div');
await page.mouse.wheel(100, 0); await page.mouse.wheel(100, 0);
expect(await page.evaluate('window.lastEvent')).toEqual({ await expectEvent(page, {
deltaX: 100 * deltaScale, deltaX: 100,
deltaY: 0 * deltaScale, deltaY: 0,
clientX: 50, clientX: 50,
clientY: 60, clientY: 60,
deltaMode: 0, deltaMode: 0,
@ -104,9 +117,9 @@ it('should work when the event is canceled', async ({ page }) => {
document.querySelector('div').addEventListener('wheel', e => e.preventDefault()); document.querySelector('div').addEventListener('wheel', e => e.preventDefault());
}); });
await page.mouse.wheel(0, 100); await page.mouse.wheel(0, 100);
expect(await page.evaluate('window.lastEvent')).toEqual({ await expectEvent(page, {
deltaX: 0 * deltaScale, deltaX: 0,
deltaY: 100 * deltaScale, deltaY: 100,
clientX: 50, clientX: 50,
clientY: 60, clientY: 60,
deltaMode: 0, deltaMode: 0,