Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: update "X fatal errors" message (#16325)

Browse source 
Also, exlude certain errors from triggering this message:
- `no tests found`
- `duplicate test titles are not allowed`
- `--forbid-only found a focused test`
- `Timed out waiting 3600s for the entire test run`
This commit is contained in:
Dmitry Gozman 2022-08-05 21:21:43 -07:00 committed by GitHub
parent 8ed238843b
commit f6d94f0ac9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/playwright-test/src/reporters/base.ts
View file

@ -98,7 +98,8 @@ export class BaseReporter implements ReporterInternal {
} }
onError(error: TestError) { onError(error: TestError) {
this._fatalErrors.push(error); if (!(error as any).__isNotAFatalError)
this._fatalErrors.push(error);
} }
async onEnd(result: FullResult) { async onEnd(result: FullResult) {
@ -136,8 +137,6 @@ export class BaseReporter implements ReporterInternal {
protected generateSummaryMessage({ skipped, expected, interrupted, unexpected, flaky, fatalErrors }: TestSummary) { protected generateSummaryMessage({ skipped, expected, interrupted, unexpected, flaky, fatalErrors }: TestSummary) {
const tokens: string[] = []; const tokens: string[] = [];
if (fatalErrors.length)
tokens.push(colors.red(` ${fatalErrors.length} fatal ${fatalErrors.length === 1 ? 'error' : 'errors'}`));
if (unexpected.length) { if (unexpected.length) {
tokens.push(colors.red(` ${unexpected.length} failed`)); tokens.push(colors.red(` ${unexpected.length} failed`));
for (const test of unexpected) for (const test of unexpected)
@ -159,6 +158,8 @@ export class BaseReporter implements ReporterInternal {
tokens.push(colors.green(` ${expected} passed`) + colors.dim(` (${milliseconds(this.duration)})`)); tokens.push(colors.green(` ${expected} passed`) + colors.dim(` (${milliseconds(this.duration)})`));
if (this.result.status === 'timedout') if (this.result.status === 'timedout')
tokens.push(colors.red(` Timed out waiting ${this.config.globalTimeout / 1000}s for the entire test run`)); tokens.push(colors.red(` Timed out waiting ${this.config.globalTimeout / 1000}s for the entire test run`));
if (fatalErrors.length)
tokens.push(colors.red(` ${fatalErrors.length === 1 ? '1 error was not a part of any test' : fatalErrors.length + ' errors were not a part of any test'}, see above for details`));
return tokens.join('\n'); return tokens.join('\n');
} }

2
packages/playwright-test/src/runner.ts
View file

@ -971,7 +971,7 @@ function createNoTestsError(): TestError {
} }
function createStacklessError(message: string): TestError { function createStacklessError(message: string): TestError {
return { message }; return { message, __isNotAFatalError: true } as any;
} }
export const builtInReporters = ['list', 'line', 'dot', 'json', 'junit', 'null', 'github', 'html'] as const; export const builtInReporters = ['list', 'line', 'dot', 'json', 'junit', 'null', 'github', 'html'] as const;

2
tests/playwright-test/reporter-base.spec.ts
View file

@ -316,5 +316,5 @@ test('should report fatal errors at the end', async ({ runInlineTest }) => {
}, { reporter: 'list' }); }, { reporter: 'list' });
expect(result.exitCode).toBe(1); expect(result.exitCode).toBe(1);
expect(result.passed).toBe(2); expect(result.passed).toBe(2);
expect(stripAnsi(result.output)).toContain('2 fatal errors'); expect(stripAnsi(result.output)).toContain('2 errors were not a part of any test, see above for details');
}); });