update expectations

This commit is contained in:
Max Schmitt 2024-10-29 16:26:44 +01:00
parent e91c041b79
commit f806c73806
3 changed files with 10 additions and 4 deletions

View file

@ -21,6 +21,10 @@ import net from 'net';
import type { SocksSocketClosedPayload, SocksSocketDataPayload, SocksSocketRequestedPayload } from '../../packages/playwright-core/src/common/socksProxy';
import { SocksProxy } from '../../packages/playwright-core/lib/common/socksProxy';
const kConnectHostsToIgnore = new Set([
'www.bing.com:443',
]);
export class TestProxy {
readonly PORT: number;
readonly URL: string;
@ -63,6 +67,8 @@ export class TestProxy {
this._prependHandler('connect', (req: IncomingMessage) => {
if (!options?.allowConnectRequests)
return;
if (kConnectHostsToIgnore.has(req.url))
return;
this.connectHosts.push(req.url);
req.url = `127.0.0.1:${port}`;
});

View file

@ -239,7 +239,7 @@ it('should not generate dispatchers for subresources w/o listeners', async ({ pa
});
});
it('should work with the domain module', async ({ browserType, server, browserName }) => {
it('should work with the domain module', async ({ browserType, server, browserName, channel }) => {
const local = domain.create();
local.run(() => { });
let err;
@ -262,7 +262,7 @@ it('should work with the domain module', async ({ browserType, server, browserNa
if (browserName === 'firefox')
expect(message).toBe('CLOSE_ABNORMAL');
else
expect(message).toContain(': 400');
expect(message).toContain(channel.includes('msedge') ? '' : ': 400');
await browser.close();

View file

@ -137,7 +137,7 @@ it('should emit binary frame events', async ({ page, server }) => {
expect(sent[1][i]).toBe(i);
});
it('should emit error', async ({ page, server, browserName }) => {
it('should emit error', async ({ page, server, browserName, channel }) => {
let callback;
const result = new Promise(f => callback = f);
page.on('websocket', ws => ws.on('socketerror', callback));
@ -148,7 +148,7 @@ it('should emit error', async ({ page, server, browserName }) => {
if (browserName === 'firefox')
expect(message).toBe('CLOSE_ABNORMAL');
else
expect(message).toContain(': 400');
expect(message).toContain(channel.includes('msedge') ? '' : ': 400');
});
it('should not have stray error events', async ({ page, server }) => {