Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

update expectations

Browse source
This commit is contained in:
Max Schmitt 2024-10-29 16:26:44 +01:00
parent e91c041b79
commit f806c73806
3 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/config/proxy.ts
View file

@ -21,6 +21,10 @@ import net from 'net';
import type { SocksSocketClosedPayload, SocksSocketDataPayload, SocksSocketRequestedPayload } from '../../packages/playwright-core/src/common/socksProxy'; import type { SocksSocketClosedPayload, SocksSocketDataPayload, SocksSocketRequestedPayload } from '../../packages/playwright-core/src/common/socksProxy';
import { SocksProxy } from '../../packages/playwright-core/lib/common/socksProxy'; import { SocksProxy } from '../../packages/playwright-core/lib/common/socksProxy';
const kConnectHostsToIgnore = new Set([
'www.bing.com:443',
]);
export class TestProxy { export class TestProxy {
readonly PORT: number; readonly PORT: number;
readonly URL: string; readonly URL: string;
@ -63,6 +67,8 @@ export class TestProxy {
this._prependHandler('connect', (req: IncomingMessage) => { this._prependHandler('connect', (req: IncomingMessage) => {
if (!options?.allowConnectRequests) if (!options?.allowConnectRequests)
return; return;
if (kConnectHostsToIgnore.has(req.url))
return;
this.connectHosts.push(req.url); this.connectHosts.push(req.url);
req.url = `127.0.0.1:${port}`; req.url = `127.0.0.1:${port}`;
}); });

4
tests/library/channels.spec.ts
View file

@ -239,7 +239,7 @@ it('should not generate dispatchers for subresources w/o listeners', async ({ pa
}); });
}); });
it('should work with the domain module', async ({ browserType, server, browserName }) => { it('should work with the domain module', async ({ browserType, server, browserName, channel }) => {
const local = domain.create(); const local = domain.create();
local.run(() => { }); local.run(() => { });
let err; let err;
@ -262,7 +262,7 @@ it('should work with the domain module', async ({ browserType, server, browserNa
if (browserName === 'firefox') if (browserName === 'firefox')
expect(message).toBe('CLOSE_ABNORMAL'); expect(message).toBe('CLOSE_ABNORMAL');
else else
expect(message).toContain(': 400'); expect(message).toContain(channel.includes('msedge') ? '' : ': 400');
await browser.close(); await browser.close();

4
tests/library/web-socket.spec.ts
View file

@ -137,7 +137,7 @@ it('should emit binary frame events', async ({ page, server }) => {
expect(sent[1][i]).toBe(i); expect(sent[1][i]).toBe(i);
}); });
it('should emit error', async ({ page, server, browserName }) => { it('should emit error', async ({ page, server, browserName, channel }) => {
let callback; let callback;
const result = new Promise(f => callback = f); const result = new Promise(f => callback = f);
page.on('websocket', ws => ws.on('socketerror', callback)); page.on('websocket', ws => ws.on('socketerror', callback));
@ -148,7 +148,7 @@ it('should emit error', async ({ page, server, browserName }) => {
if (browserName === 'firefox') if (browserName === 'firefox')
expect(message).toBe('CLOSE_ABNORMAL'); expect(message).toBe('CLOSE_ABNORMAL');
else else
expect(message).toContain(': 400'); expect(message).toContain(channel.includes('msedge') ? '' : ': 400');
}); });
it('should not have stray error events', async ({ page, server }) => { it('should not have stray error events', async ({ page, server }) => {