Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(launcher): check libs required for playing h.264 (#3715)

Browse source
This commit is contained in:
Yury Semikhatsky 2020-09-01 16:29:38 -07:00 committed by GitHub
parent 76ab82faa7
commit f8408cb840
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/server/validateDependencies.ts
View file

@ -35,7 +35,7 @@ export async function validateHostRequirements(browserPath: string, browser: Bro
const DL_OPEN_LIBRARIES = { const DL_OPEN_LIBRARIES = {
chromium: [], chromium: [],
webkit: ['libGLESv2.so.2'], webkit: ['libGLESv2.so.2', 'libx264.so'],
firefox: [], firefox: [],
}; };
@ -123,6 +123,7 @@ async function validateDependenciesLinux(browserPath: string, browser: BrowserDe
libraryToPackageNameMapping = LIBRARY_TO_PACKAGE_NAME_UBUNTU_18_04; libraryToPackageNameMapping = LIBRARY_TO_PACKAGE_NAME_UBUNTU_18_04;
else if (ubuntuVersion === '20.04') else if (ubuntuVersion === '20.04')
libraryToPackageNameMapping = LIBRARY_TO_PACKAGE_NAME_UBUNTU_20_04; libraryToPackageNameMapping = LIBRARY_TO_PACKAGE_NAME_UBUNTU_20_04;
libraryToPackageNameMapping = Object.assign({}, libraryToPackageNameMapping, MANUAL_LIBRARY_TO_PACKAGE_NAME_UBUNTU);
if (libraryToPackageNameMapping) { if (libraryToPackageNameMapping) {
// Translate missing dependencies to package names to install with apt. // Translate missing dependencies to package names to install with apt.
for (const missingDep of missingDeps) { for (const missingDep of missingDeps) {
@ -416,3 +417,11 @@ const LIBRARY_TO_PACKAGE_NAME_UBUNTU_20_04: { [s: string]: string} = {
'libXt.so.6': 'libxt6', 'libXt.so.6': 'libxt6',
'libXtst.so.6': 'libxtst6', 'libXtst.so.6': 'libxtst6',
}; };
const MANUAL_LIBRARY_TO_PACKAGE_NAME_UBUNTU: { [s: string]: string} = {
// libgstlibav.so (the only actual library provided by gstreamer1.0-libav) is not
// in the ldconfig cache, so we detect the actual library required for playing h.264
// and if it's missing recommend installing missing gstreamer lib.
// gstreamer1.0-libav -> libavcodec57 -> libx264-152
'libx264.so': 'gstreamer1.0-libav'
};