From f8d0204d2ff33374fcef84a87211db53debf6aa3 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Thu, 14 Dec 2023 13:49:11 -0800 Subject: [PATCH] chore: provide better message for unhandled internal server errors (#28653) This changes error message from `Error: ` to `Error: Protocol error (Fetch.continueRequest): Internal server error, session closed.` when running `npm run ctest -- --repeat-each 100 -x --headed --timeout 3000 --workers 1 library/browsercontext-route.spec.ts:172` prior to 9d91b7caf51003cb5c11ec0cdeb8431ca0411aa9. --- packages/playwright-core/src/server/chromium/crConnection.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/playwright-core/src/server/chromium/crConnection.ts b/packages/playwright-core/src/server/chromium/crConnection.ts index 0f36e280c9..bcf883f238 100644 --- a/packages/playwright-core/src/server/chromium/crConnection.ts +++ b/packages/playwright-core/src/server/chromium/crConnection.ts @@ -190,6 +190,7 @@ export class CRSession extends EventEmitter { this._closed = true; this._connection._sessions.delete(this._sessionId); for (const callback of this._callbacks.values()) { + callback.error.setMessage(`Internal server error, session closed.`); callback.error.type = this._crashed ? 'crashed' : 'closed'; callback.error.logs = this._connection._browserDisconnectedLogs; callback.reject(callback.error);