Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore(tracing): render error snapshot as Action (#6241)

Browse source
This commit is contained in:
Pavel Feldman 2021-04-20 00:19:17 -07:00 committed by GitHub
parent 23dfaf9e9b
commit f9af4c3755
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/web/traceViewer/ui/actionList.css
View file

@ -27,7 +27,6 @@
color: #555; color: #555;
overflow: auto; overflow: auto;
outline: none; outline: none;
padding: 5px 0 0 5px;
} }
.action-entry { .action-entry {
@ -37,7 +36,7 @@
align-items: center; align-items: center;
white-space: nowrap; white-space: nowrap;
line-height: 28px; line-height: 28px;
padding-left: 3px; padding-left: 5px;
} }
.action-entry.highlighted, .action-entry.highlighted,
@ -68,7 +67,6 @@
.action-error { .action-error {
color: red; color: red;
top: 2px;
position: relative; position: relative;
margin-right: 2px; margin-right: 2px;
} }

2
src/web/traceViewer/ui/snapshotTab.tsx
View file

@ -32,7 +32,7 @@ export const SnapshotTab: React.FunctionComponent<{
const snapshotMap = new Map<string, { title: string, snapshotName: string }>(); const snapshotMap = new Map<string, { title: string, snapshotName: string }>();
for (const snapshot of actionEntry?.snapshots || []) for (const snapshot of actionEntry?.snapshots || [])
snapshotMap.set(snapshot.title, snapshot); snapshotMap.set(snapshot.title, snapshot);
const actionSnapshot = snapshotMap.get('action') || snapshotMap.get('before'); const actionSnapshot = snapshotMap.get('action') || snapshotMap.get('after');
const snapshots = [actionSnapshot ? { ...actionSnapshot, title: 'action' } : undefined, snapshotMap.get('before'), snapshotMap.get('after')].filter(Boolean) as { title: string, snapshotName: string }[]; const snapshots = [actionSnapshot ? { ...actionSnapshot, title: 'action' } : undefined, snapshotMap.get('before'), snapshotMap.get('after')].filter(Boolean) as { title: string, snapshotName: string }[];
if (snapshotIndex >= snapshots.length) if (snapshotIndex >= snapshots.length)