From f9c4955fe812aad3e73c452e2bfeafc814b76dd3 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Thu, 2 Nov 2023 23:30:40 +0100 Subject: [PATCH] fix(msedge): install with multiple artifacts (#27939) The API response looked like this: image -> multiple entries for `Windows` and `X64`, but some without artifacts. -> We filter now for `artifacts.length > 0` which seems like a healthy change. Fixes https://github.com/microsoft/playwright/issues/22841 --- packages/playwright-core/src/server/registry/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/playwright-core/src/server/registry/index.ts b/packages/playwright-core/src/server/registry/index.ts index 8bd9693676..707507ac09 100644 --- a/packages/playwright-core/src/server/registry/index.ts +++ b/packages/playwright-core/src/server/registry/index.ts @@ -918,7 +918,7 @@ export class Registry { darwin: { platform: 'MacOS', arch: 'universal', artifact: 'pkg' }, win32: { platform: 'Windows', arch: 'x64', artifact: 'msi' }, } as any)[process.platform]; - const release = searchConfig ? product.releases.find((release: any) => release.platform === searchConfig.platform && release.architecture === searchConfig.arch) : null; + const release = searchConfig ? product.releases.find((release: any) => release.platform === searchConfig.platform && release.architecture === searchConfig.arch && release.artifacts.length > 0) : null; const artifact = release ? release.artifacts.find((artifact: any) => artifact.artifactname === searchConfig.artifact) : null; if (artifact) scriptArgs.push(artifact.location /* url */);