Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: playwright.locator.hasText RegExp flag serialisation in Console API (#11516)

Browse source
This commit is contained in:
Max Schmitt 2022-01-21 01:05:37 +01:00 committed by GitHub
parent 33c82a42c0
commit fb139cefac
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/playwright-core/src/server/supplements/injected/consoleApi.ts
View file

@ -28,9 +28,10 @@ function createLocator(injectedScript: InjectedScript, initial: string, options?
this.selector = selector; this.selector = selector;
if (options?.hasText) { if (options?.hasText) {
const text = options.hasText; const text = options.hasText;
const matcher = text instanceof RegExp ? 'text-matches' : 'has-text'; if (text instanceof RegExp)
const source = escapeWithQuotes(text instanceof RegExp ? text.source : text, '"'); this.selector += ` >> :scope:text-matches(${escapeWithQuotes(text.source, '"')}, "${text.flags}")`;
this.selector += ` >> :scope:${matcher}(${source})`; else
this.selector += ` >> :scope:has-text(${escapeWithQuotes(text)})`;
} }
const parsed = injectedScript.parseSelector(this.selector); const parsed = injectedScript.parseSelector(this.selector);
this.element = injectedScript.querySelector(parsed, document, false); this.element = injectedScript.querySelector(parsed, document, false);

7
tests/inspector/console-api.spec.ts
View file

@ -54,6 +54,9 @@ it('should support playwright.locator.value', async ({ page }) => {
it('should support playwright.locator.values', async ({ page }) => { it('should support playwright.locator.values', async ({ page }) => {
await page.setContent('<div>Hello<div>Bar</div></div>'); await page.setContent('<div>Hello<div>Bar</div></div>');
const length = await page.evaluate(`playwright.locator('div', { hasText: 'Hello' }).elements.length`); expect(await page.evaluate(`playwright.locator('div', { hasText: 'Hello' }).elements.length`)).toBe(1);
expect(length).toBe(1); expect(await page.evaluate(`playwright.locator('div', { hasText: 'HElLo' }).elements.length`)).toBe(1);
expect(await page.evaluate(`playwright.locator('div', { hasText: /ELL/ }).elements.length`)).toBe(0);
expect(await page.evaluate(`playwright.locator('div', { hasText: /ELL/i }).elements.length`)).toBe(1);
expect(await page.evaluate(`playwright.locator('div', { hasText: /Hello/ }).elements.length`)).toBe(1);
}); });