Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(codegen): constructed CSSStyleSheet was not for the injected window

Browse source 
It caused the following error:

DOMException: Failed to set the 'adoptedStyleSheets' property on 'ShadowRoot': Sharing constructed stylesheets in multiple documents is not allowed

See https://developer.mozilla.org/en-US/docs/Web/API/Document/adoptedStyleSheets#notallowederror
This commit is contained in:
Rui Figueira 2024-04-14 10:45:06 +01:00
parent 513272e78c
commit fb69e334f8
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-core/src/server/injected/highlight.ts
View file

@ -75,7 +75,7 @@ export class Highlight {
this._actionPointElement = document.createElement('x-pw-action-point'); this._actionPointElement = document.createElement('x-pw-action-point');
this._actionPointElement.setAttribute('hidden', 'true'); this._actionPointElement.setAttribute('hidden', 'true');
this._glassPaneShadow = this._glassPaneElement.attachShadow({ mode: this._isUnderTest ? 'open' : 'closed' }); this._glassPaneShadow = this._glassPaneElement.attachShadow({ mode: this._isUnderTest ? 'open' : 'closed' });
const sheet = new CSSStyleSheet(); const sheet = new injectedScript.window.CSSStyleSheet();
sheet.replaceSync(highlightCSS); sheet.replaceSync(highlightCSS);
this._glassPaneShadow.adoptedStyleSheets = [sheet]; this._glassPaneShadow.adoptedStyleSheets = [sheet];
this._glassPaneShadow.appendChild(this._actionPointElement); this._glassPaneShadow.appendChild(this._actionPointElement);

2
packages/playwright-core/src/server/injected/recorder/recorder.ts
View file

@ -1024,7 +1024,7 @@ export class Recorder {
this.overlay = new Overlay(this); this.overlay = new Overlay(this);
this.overlay.setUIState(this.state); this.overlay.setUIState(this.state);
} }
this._stylesheet = new CSSStyleSheet(); this._stylesheet = new injectedScript.window.CSSStyleSheet();
this._stylesheet.replaceSync(` this._stylesheet.replaceSync(`
body[data-pw-cursor=pointer] *, body[data-pw-cursor=pointer] *::after { cursor: pointer !important; } body[data-pw-cursor=pointer] *, body[data-pw-cursor=pointer] *::after { cursor: pointer !important; }
body[data-pw-cursor=text] *, body[data-pw-cursor=text] *::after { cursor: text !important; } body[data-pw-cursor=text] *, body[data-pw-cursor=text] *::after { cursor: text !important; }