From fe41bbd303cb58fe0d39bc90b7c23132eadda98a Mon Sep 17 00:00:00 2001
From: Dmitry Gozman <dgozman@gmail.com>
Date: Thu, 24 Sep 2020 04:38:01 -0700
Subject: [PATCH] test: enable videos on tracing bots (#3930)

---
 .github/workflows/tests.yml | 2 +-
 test/playwright.fixtures.ts | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index c6232c1371..5476e798dc 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -207,7 +207,7 @@ jobs:
     # XVFB-RUN merges both STDOUT and STDERR, whereas we need only STDERR
     # Wrap `npm run` in a subshell to redirect STDERR to file.
     # Enable core dumps in the subshell.
-    - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- bash -c "ulimit -c unlimited && npx test-runner test/ --jobs=1 --forbid-only --timeout=30000 --global-timeout=5400000 --retries=3 --reporter=dot,json"
+    - run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- bash -c "ulimit -c unlimited && npx test-runner test/ --jobs=1 --forbid-only --timeout=60000 --global-timeout=5400000 --retries=3 --reporter=dot,json"
       env:
         BROWSER: ${{ matrix.browser }}
         TRACING: true
diff --git a/test/playwright.fixtures.ts b/test/playwright.fixtures.ts
index f8a6323088..33a9365440 100644
--- a/test/playwright.fixtures.ts
+++ b/test/playwright.fixtures.ts
@@ -278,9 +278,7 @@ defineTestFixture('context', async ({ browser, testOutputDir, testConfig }, runT
   const contextOptions: BrowserContextOptions = {
     relativeArtifactsPath: path.relative(testConfig.outputDir, testOutputDir),
     recordTrace: !!options.TRACING,
-    // TODO: enable videos. Currently, long videos are slowly processed by Chromium
-    // and (sometimes) Firefox, which causes test timeouts.
-    // recordVideos: !!options.TRACING,
+    recordVideos: !!options.TRACING,
   };
   const context = await browser.newContext(contextOptions);
   await runTest(context);