From ff0799e297b2d9bd38a95b74b0edf78c5d08016a Mon Sep 17 00:00:00 2001 From: Adam Gastineau Date: Tue, 17 Dec 2024 10:40:49 -0800 Subject: [PATCH] Fix type errors due to changes --- packages/playwright-core/src/server/frames.ts | 2 +- packages/playwright/src/isomorphic/teleSuiteUpdater.ts | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/playwright-core/src/server/frames.ts b/packages/playwright-core/src/server/frames.ts index 042f07c544..e931bdcf5f 100644 --- a/packages/playwright-core/src/server/frames.ts +++ b/packages/playwright-core/src/server/frames.ts @@ -908,7 +908,7 @@ export class Frame extends SdkObject { result.dispose(); return null; } - const element = state === 'attached' || state === 'visible' ? await result.evaluateHandle(r => r.element) : null; + const element = state === 'attached' || state === 'visible' ? await result.evaluateHandle(r => r.element as Element) : null; result.dispose(); if (!element) { return null; diff --git a/packages/playwright/src/isomorphic/teleSuiteUpdater.ts b/packages/playwright/src/isomorphic/teleSuiteUpdater.ts index 82ef9b9fc4..3629450c63 100644 --- a/packages/playwright/src/isomorphic/teleSuiteUpdater.ts +++ b/packages/playwright/src/isomorphic/teleSuiteUpdater.ts @@ -162,7 +162,8 @@ export class TeleSuiteUpdater { processTestReportEvent(message: any) { // The order of receiver dispatches matters here, we want to assign `lastRunTestCount` // before we use it. - this._lastRunReceiver?.dispatch(message).catch(() => { }); + // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition + this._lastRunReceiver?.dispatch(message)?.catch(() => { }); this._receiver.dispatch(message)?.catch(() => { }); }