Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(close): actually mark the page as closing (#2798)

Browse source 
Currently double-closing flakiness is seen on Firefox bots.
This commit is contained in:
Dmitry Gozman 2020-07-01 16:05:56 -07:00 committed by GitHub
parent 5c4751d5dd
commit ff1fe3ac39
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/page.ts
View file

@ -480,6 +480,7 @@ export class Page extends EventEmitter {
return; return;
const runBeforeUnload = !!options && !!options.runBeforeUnload; const runBeforeUnload = !!options && !!options.runBeforeUnload;
if (this._closedState !== 'closing') { if (this._closedState !== 'closing') {
this._closedState = 'closing';
assert(!this._disconnected, 'Protocol error: Connection closed. Most likely the page has been closed.'); assert(!this._disconnected, 'Protocol error: Connection closed. Most likely the page has been closed.');
await this._delegate.closePage(runBeforeUnload); await this._delegate.closePage(runBeforeUnload);
} }