Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(wk): call setViewport on the new session (#302)

Browse source
This commit is contained in:
Yury Semikhatsky 2019-12-18 18:37:27 -07:00 committed by Pavel Feldman
parent 8cc682c7b8
commit ff474b88e0
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/webkit/FrameManager.ts
View file

@ -100,7 +100,7 @@ export class FrameManager implements PageDelegate {
if (this._page._state.extraHTTPHeaders !== null) if (this._page._state.extraHTTPHeaders !== null)
promises.push(this._setExtraHTTPHeaders(session, this._page._state.extraHTTPHeaders)); promises.push(this._setExtraHTTPHeaders(session, this._page._state.extraHTTPHeaders));
if (this._page._state.viewport) if (this._page._state.viewport)
promises.push(this.setViewport(this._page._state.viewport)); promises.push(FrameManager._setViewport(session, this._page._state.viewport));
await Promise.all(promises); await Promise.all(promises);
} }
@ -284,11 +284,15 @@ export class FrameManager implements PageDelegate {
} }
async setViewport(viewport: types.Viewport): Promise<void> { async setViewport(viewport: types.Viewport): Promise<void> {
return FrameManager._setViewport(this._session, viewport);
}
private static async _setViewport(session: TargetSession, viewport: types.Viewport): Promise<void> {
if (viewport.isMobile || viewport.isLandscape || viewport.hasTouch) if (viewport.isMobile || viewport.isLandscape || viewport.hasTouch)
throw new Error('Not implemented'); throw new Error('Not implemented');
const width = viewport.width; const width = viewport.width;
const height = viewport.height; const height = viewport.height;
await this._session.send('Emulation.setDeviceMetricsOverride', { width, height, deviceScaleFactor: viewport.deviceScaleFactor || 1 }); await session.send('Emulation.setDeviceMetricsOverride', { width, height, deviceScaleFactor: viewport.deviceScaleFactor || 1 });
} }
setCacheEnabled(enabled: boolean): Promise<void> { setCacheEnabled(enabled: boolean): Promise<void> {