diff --git a/packages/html-reporter/src/metadataView.tsx b/packages/html-reporter/src/metadataView.tsx index 188de10fda..df8de54bac 100644 --- a/packages/html-reporter/src/metadataView.tsx +++ b/packages/html-reporter/src/metadataView.tsx @@ -95,7 +95,18 @@ const GitCommitInfoView: React.FC<{ info: GitCommitInfo }> = ({ info }) => {
{author}
on {shortTimestamp}
- {info['ci.link'] && <>·logs} + {info['ci.link'] && ( + <> + · + logs + + )} + {info['pull.link'] && ( + <> + · + pull request + + )}
{!!info['revision.link'] && diff --git a/packages/playwright/src/isomorphic/types.d.ts b/packages/playwright/src/isomorphic/types.d.ts index 213f350514..e6ba20019f 100644 --- a/packages/playwright/src/isomorphic/types.d.ts +++ b/packages/playwright/src/isomorphic/types.d.ts @@ -22,6 +22,7 @@ export interface GitCommitInfo { 'revision.timestamp'?: number | Date; 'revision.link'?: string; 'revision.diff'?: string; + 'pull.id'?: string; 'pull.link'?: string; 'pull.diff'?: string; 'pull.base'?: string; diff --git a/packages/playwright/src/plugins/gitCommitInfoPlugin.ts b/packages/playwright/src/plugins/gitCommitInfoPlugin.ts index 7695f81313..7975177d88 100644 --- a/packages/playwright/src/plugins/gitCommitInfoPlugin.ts +++ b/packages/playwright/src/plugins/gitCommitInfoPlugin.ts @@ -44,8 +44,8 @@ interface GitCommitInfoPluginOptions { directory?: string; } -function linksFromEnv(): Pick { - const out: { 'revision.link'?: string; 'ci.link'?: string; 'pull.link'?: string; 'pull.base'?: string; } = {}; +function linksFromEnv() { + const out: Partial = {}; // Jenkins: https://www.jenkins.io/doc/book/pipeline/jenkinsfile/#using-environment-variables if (process.env.BUILD_URL) out['ci.link'] = process.env.BUILD_URL; @@ -60,8 +60,8 @@ function linksFromEnv(): Pick on/ - link "logs" + - link "pull request" - link /^[a-f0-9]{7}$/ - text: 'foo: value1 bar: {"prop":"value2"} baz: ["value3",123]' `);