Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: skip Intl.ListFormat test on ubuntu20.04 (#28185)

Browse source 
It was failing across the Ubuntu 20.04 bots:


![image](https://github.com/microsoft/playwright/assets/17984549/3b80f04d-cae8-4288-8fd3-b94d9bf1ce03)

This is most likely because on Ubuntu 20 libicu-dev has version 66.1.
And according to

https://wksearch.azurewebsites.net/#path=%2Fhome%2Fjoe%2Fwebkit%2FSource%2FJavaScriptCore%2Fruntime%2FIntlListFormat.h&line=32
the ListFormatter requires 67 which is the case in Ubuntu 22 (70).
This commit is contained in:
Max Schmitt 2023-11-16 20:39:32 +01:00 committed by GitHub
parent 2bd7d67adc
commit ff706ec8bd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/library/capabilities.spec.ts
View file

@ -17,6 +17,7 @@
import os from 'os'; import os from 'os';
import url from 'url'; import url from 'url';
import { contextTest as it, expect } from '../config/browserTest'; import { contextTest as it, expect } from '../config/browserTest';
import { hostPlatform } from '../../packages/playwright-core/src/utils/hostPlatform';
it('SharedArrayBuffer should work @smoke', async function({ contextFactory, httpsServer, browserName }) { it('SharedArrayBuffer should work @smoke', async function({ contextFactory, httpsServer, browserName }) {
it.fail(browserName === 'webkit', 'no shared array buffer on webkit'); it.fail(browserName === 'webkit', 'no shared array buffer on webkit');
@ -284,8 +285,9 @@ it('should send no Content-Length header for GET requests with a Content-Type',
expect(request.headers['content-length']).toBe(undefined); expect(request.headers['content-length']).toBe(undefined);
}); });
it('Intl.ListFormat should work', async ({ page, server }) => { it('Intl.ListFormat should work', async ({ page, server, browserName }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/23978' }); it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/23978' });
it.skip(browserName === 'webkit' && hostPlatform.startsWith('ubuntu20.04'), 'libicu is too old and WebKit disables Intl.ListFormat by default then');
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
const formatted = await page.evaluate(() => { const formatted = await page.evaluate(() => {
const data = ['first', 'second', 'third']; const data = ['first', 'second', 'third'];