Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity
14131 commits 34 branches 141 tags 223 MiB
Commit graph

167 commits

Author SHA1 Message Date
Pavel Feldman 4340d153df
chore: deprecate locator.frameLocator() (#32306) 2024-08-26 10:28:54 -07:00
Max Schmitt 6988194c97
test: unflake contextmenu recorder test (#31749) 2024-07-26 12:43:05 +02:00
Matt Kleinsmith e06481a332
fix(recorder): address custom context menus (#31634) 2024-07-17 11:45:48 -07:00
4ydx 4089f4593b
fix(codgen): assertValue works with disabled select (#31315) 2024-06-28 13:04:59 -07:00
Fumiaki MATSUSHIMA 838c572209
fix: select issue in Windows with Edge (#31270) 2024-06-17 10:28:07 +02:00
Dmitry Gozman ae1e07de10
test: skip/improve some tests that are flaky (#30993) 2024-05-23 17:40:27 -07:00
Viktor Szépe 150cbcbdf3
chore: fix typos (#30645) 2024-05-08 19:40:03 +01:00
Pavel Feldman 96f3d19819
feat(ctrl_or_meta): add a universal ctrl-meta modifier (#30572) 
Fixes https://github.com/microsoft/playwright/issues/12168
 2024-04-29 08:15:12 -07:00
Rui Figueira c80b851422
fix(codegen): prevent csp directive violations (#30366) 2024-04-23 07:33:12 -07:00
Dmitry Gozman c1400a3db5
Revert "feat(codegen): add button to generate toHaveScreenshot statement (#29996)" (#30064) 
This reverts commit 1bb463163b. Decided to
wait for a better VRT story.

References #29250.
 2024-03-22 13:26:22 -07:00
Yury Semikhatsky 69e90f38c7
fix(codegen): import re in python (#30026) 
Fixes https://github.com/microsoft/playwright/issues/30019
 2024-03-20 16:38:28 -07:00
Dmitry Gozman 1bb463163b
feat(codegen): add button to generate toHaveScreenshot statement (#29996) 
Fixes #29250.
 2024-03-19 14:01:04 -07:00
Rui Figueira 73ffaf65d7
fix(codegen): fill action prevents omnibox navigation recording (#29790) 
This PR is a fix proposal for a bug when trying to record a omnibox
navigation after a recorded action (e.g., `fill`).

The following test, included in this PR, reproduces the problem:

```ts
  test('should record omnibox navigations after recordAction', async ({ page, openRecorder, server }) => {
    const recorder = await openRecorder();
    await recorder.setContentAndWait(`<textarea></textarea>`);
    await Promise.all([
      recorder.waitForOutput('JavaScript', 'fill'),
      page.locator('textarea').fill('Hello world'),
    ]);
    // for performed actions, 5 seconds is the time needed to ensure they are committed
    await page.waitForTimeout(5000);
    await page.goto(server.PREFIX + `/empty.html`);
    await recorder.waitForOutput('JavaScript', `await page.goto('${server.PREFIX}/empty.html');`);
  });
```

After performed actions (e.g., `click`), it successfully records the
navigation as long as there's at least a 5 sec. gap between both
actions. That happens because after that 5 sec. interval the performed
action is automatically commited and therefore the navigation is not
stored as a signal of that action.

The proposed fix for recorded actions also forces that action to be
automatically commited after 5 sec (for testing, I'm using 500ms to
speed up the test execution).
 2024-03-04 12:31:03 -08:00
Jean-François Greffier 6494bb30a0
JUnit codegen (#29424) 
Codegen for JUnit

Fixes https://github.com/microsoft/playwright-java/issues/1039

Following JUnit5 integration
https://github.com/microsoft/playwright-java/issues/1369
 2024-02-20 11:08:53 -08:00
Max Schmitt 84fefdaac6
fix(console-api): locator filter with hasText (#29563) 
Relates https://github.com/microsoft/playwright/issues/29546
 2024-02-20 17:35:11 +01:00
Rui Figueira b88a008a87
feat(codegen): slider support (#29087) 2024-02-01 13:45:19 -08:00
Dmitry Gozman acc72c2663
fix(codegen): assertValue works with disabled input (#29205) 
Also add tests for new codegen functionality.

Fixes #29161.
 2024-01-27 14:54:22 -08:00
Pavel Feldman cec2ff1772
chore: split cli processing into cli endpoint and program (#29131) 2024-01-23 15:22:09 -08:00
Max Schmitt e551506c9e
Revert "feat(codegen): add range input recording support (#28767)" (#29069) 2024-01-19 19:47:59 +01:00
Rui Figueira 778828cc43
feat(codegen): add range input recording support (#28767) 2023-12-30 17:22:57 -08:00
Max Schmitt 39bdbbf029
test: codegen #28663 follow-up (#28673) 2023-12-15 12:05:13 -08:00
Max Schmitt 44c3ad5ceb
chore: make csharp library codegen more csharp like (#28663) 2023-12-15 10:24:26 -08:00
Dmitry Gozman 16aee8b5d0
fix(codegen): comment-out generated expects for library scripts (#28118) 
- reverts "fix(codegen): generate expect import for library
(https://github.com/microsoft/playwright/pull/28107)";
- comments-out generated expects.
 2023-11-13 16:56:27 -08:00
Max Schmitt 8b1c637c16
fix(codegen): generate expect import for library (#28107) 2023-11-13 21:54:30 +01:00
Dmitry Gozman f401a482d2
fix(codegen): consume pointer events alongside mouse events (#27949) 
Fixes #27926.
 2023-11-03 13:41:51 -07:00
Max Schmitt 59b8cf008e
fix(codegen): don't generate page.frame() calls anymore (#27820) 
Fixes https://github.com/microsoft/playwright/issues/27650
 2023-10-30 21:56:45 +01:00
Pavel Feldman 5752a28f87
chore: make tests strict (1) (#27731) 2023-10-23 09:31:30 -07:00
Max Schmitt 6d7d37061d
fix(recorder): Locator picker had wrong initial language in language bindings (#27706) 
**Description**

When a language port was using Inspector with the "Locator Picker"
feature, it only recognised JavaScript as a language by default. As a
workaround the user was able to click record, interact with the page and
then the language would be correctly used -> csharp e.g. would work in
the "Locator Picker".

**Why?**

Our language bindings are setting `PW_LANG_NAME=<sdkLanguage>` env var
-> good. Our recorder harness also uses this along its internal state
here:


b9b289b641/packages/playwright-core/src/server/recorder.ts (L369)

and it gets used here (no parameter means: we use the first language
aka. primary language):


b9b289b641/packages/playwright-core/src/server/recorder.ts (L95)

The only issue is that the Inspector frontend in the beginning does not
know which language it should use and pass over to the server side, it
then falls back to JavaScript.

**Proposed fix**

Instead of passing it over from the frontend to the server side, we just
always use it from the server side, aka. "currentLanguage". When the
user switches languages in the frontend, "currentLanguage" already gets
updated properly via the "fileChanged" event.

https://github.com/microsoft/playwright-dotnet/issues/2718

---------

Signed-off-by: Max Schmitt <max@schmitt.mx>
 2023-10-22 13:02:14 +02:00
Dmitry Gozman d1d5fc67dc
fix(recorder): show action point in main frame only (#27719) 2023-10-20 20:58:09 -07:00
Pavel Feldman 527d260cbf
chore: hide tracing calls from traces (#27096) 2023-09-15 12:55:49 -07:00
Pavel Feldman 61a1924328
chore: align recorder drawer with trace viewer (#26922) 2023-09-06 17:13:25 -07:00
Andrey Lushnikov 0bb4dac28f
tests: fix race condition in codegen tests (#26405) 
The console message comes in once the page navigates, not in the
`page.setContent()` call below.
 2023-08-10 07:51:38 -07:00
Pavel Feldman b39fd7283f
chore: skip tests that fail in cross-machine service mode (#24412) 2023-07-25 16:47:04 -07:00
Max Schmitt 0f9f863183
fix(codegen): generate no Enter keyboard events for textareas (#23775) 
Fixes https://github.com/microsoft/playwright/issues/23774
 2023-06-19 17:07:37 +02:00
Dmitry Gozman 4f8680f7a3
fix(pause): revert timeouts after pause (#23578) 
Fixes #23523.
 2023-06-07 12:30:10 -07:00
Max Schmitt 3c2a8fa306
chore: enable no-floating-promises ESLint rule for tests (#23376) 
https://github.com/microsoft/playwright/issues/23339
 2023-06-02 21:59:12 +02:00
Pavel Feldman fd75b85510 Revert "chore: more tree gardening (#23119)" 
This reverts commit e6bc32b022.
 2023-05-23 12:04:44 -07:00
Pavel Feldman 631edc9744
chore(internal): generate code in jsonl (#23124) 2023-05-20 10:15:33 -07:00
Andrey Lushnikov e6bc32b022
chore: more tree gardening (#23119) 
https://github.com/microsoft/playwright/issues/23114
https://github.com/microsoft/playwright/issues/23115
https://github.com/microsoft/playwright/issues/23116
https://github.com/microsoft/playwright/issues/23117
https://github.com/microsoft/playwright/issues/23118
 2023-05-17 18:57:35 -07:00
Dmitry Gozman 62146b946c
fix(codegen): ignore previously hovered detached nodes (#23057) 
Fixes #23043.
 2023-05-16 11:13:19 -07:00
Dmitry Gozman 160888df99
feat(locators): reland locator.and(locator) (#22850) 
Removed in #22223.
Fixes #22585.
 2023-05-05 11:14:01 -07:00
Pavel Feldman 116fb349ce
chore: allow configuring test id attribute for codegen (#22716) 
Fixes: https://github.com/microsoft/playwright/issues/22653
 2023-04-29 12:04:33 -07:00
Andrey Lushnikov 2977c2b539
test: refer to the upstream Firefox bug (#22364) 
There's no action on our side to fix this.

Fixes https://github.com/microsoft/playwright/issues/21550
 2023-04-12 10:37:21 -07:00
Andrey Lushnikov 8bb708be70
test: unflake inspector-cli tests (#22347) 
This patch:
- changes the `childProcess` fixture to reliably SIGKILL all descendants
  (children and grand-children, regardless of their process group).
This is achieved using the `ps` command to build the process tree, and
then send
  `SIGKILL` to the descendant process groups.
- changes the `runCLI` fixture to **not** auto-close codegen by default;
  the `childProcess` fixture will clean up all processes. This makes
sure that all `runCLI.waitFor()` commands actually wait until the
necessary
  output.
- for a handful of tests that do actually want to auto-close codegen,
  introduce an optional `autoCloseWhen` flag for the `runCLI` fixture
that makes sure to close the codegen once a certain output was reached.
 2023-04-12 09:37:24 -07:00
Max Schmitt 2df0f0738d
test: report and kill child processes which are leaking after test (#22237) 2023-04-06 20:09:19 +02:00
Dmitry Gozman 08cef43e82
feat(locator): remove locator.and and locator.not (#22223) 
Not shipping for now, after API review.
 2023-04-05 16:28:13 -07:00
Dmitry Gozman 35afb056ea
feat(locator): filter({ hasNotText }) (#22222) 
The opposite of `filter({ hasText })`.
 2023-04-05 14:13:28 -07:00
Dmitry Gozman bc1de5f28d
feat(locator): filter({ hasNot }) (#22219) 
This is the opposite of `filter({ has })`.
 2023-04-05 12:45:46 -07:00
Dmitry Gozman 539d9873c2
feat: rename Locator.filter(locator) to Locator.and (#22101) 2023-03-30 14:41:30 -07:00
Dmitry Gozman e6148bb725
feat: Locator.not(locator) (#22066) 2023-03-30 08:52:30 -07:00
Pavel Feldman 968abd27d5
chore: do not use attributes for trace target annotation (#22075) 
Fixes: https://github.com/microsoft/playwright/issues/22004
 2023-03-29 23:17:17 -07:00
Dmitry Gozman 525097d465
feat: Locator.filter(locator) (#21975) 
Produces a locator that matches both locators.
Implemented through `internal:and` selector.

Fixes #19551.
 2023-03-27 14:29:30 -07:00
Dmitry Gozman d10fac4f6a
feat: Locator.or(locator) (#21884) 2023-03-22 15:28:59 -07:00
Pavel Feldman e45a496850
chore(tv): render error in-line (#21586) 2023-03-10 16:22:19 -08:00
Andrey Lushnikov 7a1c5b2aa3
test: make the tree green (#21551) 
References https://github.com/microsoft/playwright/issues/20522
References https://github.com/microsoft/playwright/issues/20993
References https://github.com/microsoft/playwright/issues/21435
References https://github.com/microsoft/playwright/issues/21512
References https://github.com/microsoft/playwright/issues/21549
References https://github.com/microsoft/playwright/issues/21550
 2023-03-09 16:56:29 -08:00
Dmitry Gozman 821949d580
test: update stale test expectations (#20423) 2023-01-27 21:52:34 -08:00
Max Schmitt a7495c3326
fix: use no internal selectors for frame locators (#19964) 
Fixes https://github.com/microsoft/playwright/issues/19406
 2023-01-11 21:53:19 +01:00
Dmitry Gozman f58015281a
test: attempt to unflake inspector tests (#19845) 
On headed bots, we might get `locator('body')` from initial mouse
position.
 2023-01-03 16:26:21 -08:00
Dmitry Gozman 1bb019ac81
chore: migrate most of rerunnable tasks to element callback (#19713) 2022-12-27 09:22:22 -08:00
Dmitry Gozman 1263bc3edd
feat(console api): first/last/nth (#19485) 2022-12-15 11:17:59 -08:00
Dmitry Gozman 3c17a2603a
feat(console api): support locator.filter (#19389) 2022-12-09 15:25:12 -08:00
Dmitry Gozman 0be4fa768a
fix(codegen): do not generate Promise.all (#19182) 
Drive-by: fix `download`, `dialog` and `popup` signals to use different
variable names in all languages.
 2022-12-02 17:33:01 -08:00
Dmitry Gozman c547416e24
test: unflake "should highlight locators with custom testId" (#19236) 2022-12-02 17:32:29 -08:00
Max Schmitt 3565d97a36
feat(recorder): make it work with [contenteditable] (#19066) 
https://github.com/microsoft/playwright/issues/19029
 2022-12-01 12:41:03 -08:00
Dmitry Gozman 307a0b6ea7
fix(dotnet): codegen/docs use Name instead of NameString (#19156) 2022-11-29 20:56:18 -08:00
Dmitry Gozman 43a6bf4d45
fix(inspector): support custom test id attribute (#18996) 
Fixes #18959.
 2022-11-29 11:43:47 -08:00
Dmitry Gozman 4f72a895e9
fix(inspector): render expect.not correctly (#19125) 
Also fixes the same in expect logs.

References #19083.
 2022-11-28 20:50:16 -08:00
Pavel Feldman 59418aa6f3
chore: ignore untrusted clicks when recording (#18796) 
Fixes https://github.com/microsoft/playwright/issues/18776
 2022-11-14 15:16:25 -08:00
Max Schmitt 56d7d47d43
fix(codegen): make select work with size attribute (#18712) 
Fixes https://github.com/microsoft/playwright/issues/18711
 2022-11-10 15:06:53 -08:00
Dmitry Gozman cafa558845
fix(codegen): update priorites in selector generator (#18688) 
- prefer `role=checkbox` over `input[type=checkbox]`
- prefer `#id` over `input[type=checkbox]` and `role=checkbox`
- prefer `text=foo` over `internal:has-text=foo`
- ignore `none` and `presentation` roles
- remove non-strict support
 2022-11-09 17:22:13 -08:00
Dmitry Gozman 6a65a43e9a
chore: use consistent asLocator() in all logs (#18586) 
References #18524.
 2022-11-04 15:19:16 -07:00
Pavel Feldman 17c8554255
chore(recorder): explore using codemirror (#18529) 2022-11-03 09:55:23 -07:00
Dmitry Gozman 20f2e0049c
test: unflake codegen tests waiting for highlight (#18518) 
Clear existing highlights to avoid resolving with the old highlight
value.
 2022-11-02 17:00:33 -07:00
Pavel Feldman 2183d9e9a2
chore: use codemirror for editor (#18482) 2022-11-01 15:04:30 -07:00
Pavel Feldman 37250cde17
chore: switch to the new debug controller harness (#18308) 2022-10-25 09:55:20 -07:00
Pavel Feldman d8ec7cba47
chore: don't generate new lines in codegen (#18309) 2022-10-25 09:02:06 -07:00
Pavel Feldman 3f850d27e9
fix(highlight): fix the testing harness to be real (#18294) 2022-10-24 15:01:48 -07:00
Pavel Feldman 84daeafb3a
chore: use internal locator for role (#18187) 2022-10-19 19:38:47 -07:00
Yury Semikhatsky 69092b153a
chore(codegen): do not generate waitForURL (#18167) 
Fixes https://github.com/microsoft/playwright/issues/17179
 2022-10-19 11:26:19 -07:00
Pavel Feldman 739b64a09a
chore: render typed locators in the recorder (#18162) 2022-10-18 16:39:58 -07:00
Pavel Feldman 304a4ee8ec
chore: migrate to the internal:text selector (#18135) 2022-10-18 13:09:54 -07:00
Max Schmitt a60073d664
fix(generator): .NET getByRole w/ name (#18060) 2022-10-13 08:23:43 -07:00
Pavel Feldman ec1f8d17f0
fix(generator): generate nice locators for arbitrary selectors (#18010) 2022-10-11 17:50:41 -07:00
Pavel Feldman 35a5e805b3
fix(codegen): use constants when generating C# and Java roles (#17961) 
Fixes #[17960](https://github.com/microsoft/playwright/issues/17960)
 2022-10-10 12:25:56 -07:00
Pavel Feldman c168f5494f
chore: generate getByLabel for inputs (#17845) 2022-10-05 12:02:15 -07:00
Dmitry Gozman 2bcd9ce9ae
chore: internal selectors (#17827) 
- Rename internal selectors `has`, `control` and `attr` to
`internal:has`, `internal:control` and `internal:attr`.
- Fix `getByLabel()` to respect strictness, by introducing
`internal:label` selector.
- Move tests essential for ports to `selectors-by.spec`.
 2022-10-05 08:45:10 -07:00
Pavel Feldman 8810b55504
feat(api): shorted getByLabel, getByPlaceholder (#17816) 2022-10-04 10:29:26 -07:00
Pavel Feldman 1311767f87
chore: generate api calls (#17794) 2022-10-03 17:14:02 -07:00
Pavel Feldman 42a4d8a829
chore(codegen): prioritize role selectors (#17750) 2022-10-03 08:44:24 -07:00
Pavel Feldman 5754fb9c6d
chore: do not emit comments from codegen (#17747) 2022-09-30 12:36:54 -07:00
Pavel Feldman 3abbe0d850
chore: migrate codegen to controller events (#17450) 2022-09-20 14:32:21 -07:00
Max Schmitt 59c32bf2c6
Revert "chore(generator): use new .NET test attributes (#17172)" (#17344) 
This reverts commit 15add13a6a.
 2022-09-14 22:44:38 +02:00
Max Schmitt 15add13a6a
chore(generator): use new .NET test attributes (#17172) 2022-09-08 01:44:58 +02:00
Max Schmitt 74ab343e2b
feat(codegen): add NUnit/MSTest (#16803) 2022-08-25 11:58:58 +02:00
Max Schmitt 7e2aec7454
chore: align more ESLint rules with VSCode formatting (#16647) 2022-08-18 20:12:33 +02:00
Max Schmitt 13596b7be3
chore: language specific dropdowns in codegen (#16452) 2022-08-15 19:44:46 +02:00
Max Schmitt e911eead9b
test: unflake 'should fill japanese text' (#16431) 2022-08-11 08:48:55 +02:00
Max Schmitt 699a52ec74
fix(codegen): make sure input recording with japanese IME Work (#16400) 
Co-authored-by: kawasaki.taiga <kigtaiga@gmail.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2022-08-10 09:46:30 +02:00
Yury Semikhatsky 11391910e7
Revert "fix(codegen): make sure input recording with japanese IME Wor… (#16393) 
Revert "fix(codegen): make sure input recording with japanese IME Work (#16210)"

This reverts commit 925de8da2b.
 2022-08-09 16:47:32 -07:00
YA2KM 925de8da2b
fix(codegen): make sure input recording with japanese IME Work (#16210) 
Co-authored-by: kawasaki.taiga <kigtaiga@gmail.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2022-08-10 01:02:42 +02:00