playwright

Author SHA1 Message Date

Author	SHA1	Message	Date
Andrey Lushnikov	3536e81d77	chore: update browser patches as of May 26, 2023 (#23556 ) (#24079 ) Internal commit reference: `2e6d52519c`	2023-07-06 12:22:45 -07:00
Patrick Shaw	6e78dcb7dc	fix: Allow portable bash paths for systems including NixOS (#23889 ) Although very common, bash is not guaranteed to be located at `/bin/bash`. NixOS is an example of this. More commonly, `/bin/bash` can be quite out of date. An example of this is MacOS's version of `bash`. This realistically won't affect Playwright but it's worth noting. You can technically update MacOS's system version of bash but you need elevated permissions to do so. By using `/usr/bin/env bash` instead of `/bin/bash` we can execute Playwright's bash scripts in like NixOS and generally improve the selection behaviour for bash in other systems too. Some discussion of why it's worth favouring `/usr/bin/env bash` over `/bin/bash`: - Discusses `/bin/bash` missing in NixOS: https://discourse.nixos.org/t/add-bin-bash-to-avoid-unnecessary-pain/5673 - Some general commentary on why `/usr/bin/env bash` is favoured: https://askubuntu.com/a/1402721 - Points out how old bash is in MacOS: https://itnext.io/upgrading-bash-on-macos-7138bd1066ba Improves situation at #5501	2023-07-03 06:27:06 -07:00
Andrey Lushnikov	fda31dfca2	devops: build winldd on buildbots (#3917 ) This patch: - moves PrintDepsWindows folder to `//browser_patches/winldd` - adds `build.sh`, `archive.sh`, `clean.sh` and `BUILD_NUMBER` to power builds on buildbots - starts building `winldd-win64` on windows buildbot	2020-09-18 09:43:43 -07:00

Andrey Lushnikov

3536e81d77

chore: update browser patches as of May 26, 2023 (#23556 ) (#24079 )

Internal commit reference:

2e6d52519c

2023-07-06 12:22:45 -07:00

Patrick Shaw

6e78dcb7dc

fix: Allow portable bash paths for systems including NixOS (#23889 )

Although very common, bash is not guaranteed to be located at
`/bin/bash`. NixOS is an example of this.

More commonly, `/bin/bash` can be quite out of date. An example of this
is MacOS's version of `bash`. This realistically won't affect Playwright
but it's worth noting. You can technically update MacOS's system version
of bash but you need elevated permissions to do so.

By using `/usr/bin/env bash` instead of `/bin/bash` we can execute
Playwright's bash scripts in like NixOS and generally improve the
selection behaviour for bash in other systems too.

Some discussion of why it's worth favouring `/usr/bin/env bash` over
`/bin/bash`:
- Discusses `/bin/bash` missing in NixOS:
https://discourse.nixos.org/t/add-bin-bash-to-avoid-unnecessary-pain/5673
- Some general commentary on why `/usr/bin/env bash` is favoured:
https://askubuntu.com/a/1402721
- Points out how old bash is in MacOS:
https://itnext.io/upgrading-bash-on-macos-7138bd1066ba

Improves situation at #5501

2023-07-03 06:27:06 -07:00

Andrey Lushnikov

fda31dfca2

devops: build winldd on buildbots (#3917 )

This patch:
- moves PrintDepsWindows folder to `//browser_patches/winldd`
- adds `build.sh`, `archive.sh`, `clean.sh` and `BUILD_NUMBER` to
  power builds on buildbots
- starts building `winldd-win64` on windows buildbot

2020-09-18 09:43:43 -07:00

3 commits