Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity
12475 commits 34 branches 141 tags 223 MiB
Commit graph

12475 commits

This branch
This branch
All branches
Author SHA1 Message Date
Dmitry Gozman 7a3c002944
fix(ct): allow importing json files (#30067) 
While we are not fully resolving imports during compilation, do not
treat `json` as a non-importable asset.

Fixes #29926.
 2024-03-25 07:41:54 -07:00
Pavel Feldman 1539cde034
chore: allow passing path to config to the test server (#30068) 2024-03-22 16:04:59 -07:00
Pavel Feldman ee9432b9da
chore: send test params over the wire in ui mode (#30046) 2024-03-22 13:49:28 -07:00
Dmitry Gozman c8e8d8f8bb
test: fulfilling with gzip should allow to read the body (#30065) 
Fixes #29261.
 2024-03-22 13:32:28 -07:00
Playwright Service 2443d6560f
feat(firefox-beta): roll to r1446 (#30062) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-22 21:27:33 +01:00
Dmitry Gozman c1400a3db5
Revert "feat(codegen): add button to generate toHaveScreenshot statement (#29996)" (#30064) 
This reverts commit 1bb463163b. Decided to
wait for a better VRT story.

References #29250.
 2024-03-22 13:26:22 -07:00
Max Schmitt 14cd7953f3
devops(merge): validate zip before uploading (#30061) 2024-03-22 21:22:19 +01:00
Max Schmitt 4a67437704
devops(gha): move from always() to !cancelled() (#30060) 
**Investigation:**

- According to
[here](https://github.com/microsoft/playwright/actions/runs/8351676198),
the job got cancelled, because someone force-pushed and another commit
took priority.
- We have `if: always()` for uploading the blobs, even if they are
cancelled. We expect, that the task before (`npx playwright test`)
finished writing the blob, but it didn't - cancelled in between. We
still upload - a broken one.
- We download the broken zip and it breaks from there on.

Proposed change: Instead of uploading always, upload if it did not get
cancelled.

Quoting from the GitHub Actions docs about `always()`:

> Warning: Avoid using always for any task that could suffer from a
critical failure, for example: getting sources, otherwise the workflow
may hang until it times out. If you want to run a job or step regardless
of its success or failure, use the recommended alternative: if: `${{
!cancelled() }}`

This is phase 1/2 where it changes our code to use this new condition.
The actual roll-out happens once it works for us.

Relates https://github.com/microsoft/playwright/issues/29451
 2024-03-22 19:25:13 +01:00
Yury Semikhatsky a511731f55
fix(html): keep projects from different bots separate (#30051) 2024-03-22 10:02:00 -07:00
Playwright Service 9ce83e10f4
feat(firefox): roll to r1446 (#30053) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-22 13:00:38 +01:00
Playwright Service b834c0b9ed
feat(webkit): roll to r1991 (#30049) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-22 13:00:15 +01:00
Playwright Service 63cc132daa
feat(firefox-beta): roll to r1445 (#30028) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-22 12:59:21 +01:00
Dmitry Gozman 348d0c2bfa
test: can register service workers in an iframe (#30045) 
References #29267.
 2024-03-21 15:34:23 -07:00
Pavel Feldman a9fc4de37e
chore: queue run and list commands from ui (#30033) 2024-03-21 14:28:07 -07:00
Dmitry Gozman e0588446c0
feat(firefox): roll to 1445 (#30043) 2024-03-21 13:26:02 -07:00
Dmitry Gozman ef57489cf9
test: iframe is covered by service workers (#30042) 
References #29267.
 2024-03-21 11:27:27 -07:00
Max Schmitt 352cb7fa08
feat(browser): roll Chromium to 1110 (#30039) 
Browser roll bot was broken, got fixed by
3d4e0061bc.
 2024-03-21 14:26:42 +01:00
Playwright Service 86d43131e9
feat(chromium-tip-of-tree): roll to r1204 (#30038) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-21 14:23:38 +01:00
Max Schmitt 3d4e0061bc
devops: fix roll_browser script 
Signed-off-by: Max Schmitt <max@schmitt.mx>
 2024-03-21 13:39:24 +01:00
Pavel Feldman 7ad0a12c23
chore: remove ui mode update globals (#30031) 2024-03-20 21:09:49 -07:00
Dmitry Gozman 3e73a6ce69
feat(test runner): show multiple errors, at most one per stage (#30024) 
Previously, there was at most one "hard error", as opposite to multiple
"soft errors". This was done to preserve the historic behavior at the
time of introducing multiple `TestInfo.errors`.

With this change, every user callback that is executed `withRunnable()`
can throw an error and/or timeout, and both of these will end up in
`TestInfo.errors`.

Additionally, there is at most one "unhandled exception" error, to avoid
flooding the report with mass failures.

Drive-by: remove boolean arguments from `_failWithError()`.

Fixes #29876.
 2024-03-20 21:01:30 -07:00
Dmitry Gozman 6f360f7207
feat(trace): do not record events that are not used in the viewer (#30030) 
This is especially useful for network events that are already in the
har, but also get into the trace.
 2024-03-20 21:01:17 -07:00
Dmitry Gozman 9d40f619c4
feat: deprecate "devtools" launch option (#30025) 
References #29899.
 2024-03-20 16:48:00 -07:00
Yury Semikhatsky 69e90f38c7
fix(codegen): import re in python (#30026) 
Fixes https://github.com/microsoft/playwright/issues/30019
 2024-03-20 16:38:28 -07:00
Pavel Feldman 8a1ff34578
chore: split ui mode view into files (#30029) 2024-03-20 16:00:35 -07:00
Yury Semikhatsky 69f2ae1e4d
test: intercepted requests bypass disk cache (#30011) 
Reference https://github.com/microsoft/playwright/issues/30000
 2024-03-20 15:43:29 -07:00
Pavel Feldman 48ccc9cbcd
chore: prepare to reuse test server from ui mode (6) (#30008) 2024-03-20 13:43:26 -07:00
Max Schmitt 2bd3e104ab
chore: remove run-driver wrapper in driver (#30027) 2024-03-20 21:15:46 +01:00
dependabot[bot] 980fa90d3c
chore(deps): bump black from 23.3.0 to 24.3.0 in /utils/doclint/linting-code-snippets/python (#30022) 2024-03-20 19:10:19 +01:00
Max Schmitt dd0b6f7ec5
test: generate debug controller channel (#30018) 2024-03-20 16:56:29 +01:00
Playwright Service c712b365ad
feat(chromium-tip-of-tree): roll to r1203 (#30017) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-20 13:31:12 +01:00
Yury Semikhatsky da2b099b5c
docs: note on locator handler trigger (#30004) 
Fixes https://github.com/microsoft/playwright/issues/30003
 2024-03-19 16:54:49 -07:00
Max Schmitt 911fd204cf
devops: fix WebView2 tests (#30009) 
Turns out we were using version 119.0.2151.58 before where the tests are
failing. After this change we are using 122.0.2365.92.

Fixes https://github.com/microsoft/playwright/issues/29695
Relates https://github.com/actions/runner-images/issues/9538
 2024-03-19 23:18:20 +01:00
Pavel Feldman 0a22a86e2e
chore: prepare to reuse test server from ui mode (5) (#30005) 2024-03-19 14:08:21 -07:00
Dmitry Gozman 1bb463163b
feat(codegen): add button to generate toHaveScreenshot statement (#29996) 
Fixes #29250.
 2024-03-19 14:01:04 -07:00
Pavel Feldman 54aca430b0
chore: prepare to reuse test server from ui mode (4) (#29995) 2024-03-19 13:00:49 -07:00
Playwright Service 3ee13cbf2b
feat(webkit): roll to r1990 (#29999) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-19 14:31:38 +01:00
jonghoonpark b929c0d8f7
feat(ui-mode): add key shortcuts for playwright uI test runner (#29868) 2024-03-19 12:36:42 +01:00
Playwright Service db7d40e4f2
feat(firefox-beta): roll to r1444 (#29851) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-19 11:50:19 +01:00
Playwright Service 3c993fbbda
feat(firefox): roll to r1444 (#29853) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-19 11:50:12 +01:00
Dmitry Gozman be1af15d57
feat: always enable ESM loader with the new API (#29991) 
It does not require a process restart anymore, so safe to enable.

Fixes #29747.
 2024-03-18 21:54:25 -07:00
Dmitry Gozman b41b802662
fix(test runner): avoid dependency tracking colliding between esm and cjs (#29994) 
When collecting dependencies both from CJS loader and from ESM loader,
the latter would overwrite the dependencies set instead of appending.

Also make sure cts/cjs/mts/mjs are all supported equally.

References #29747.
 2024-03-18 17:17:58 -07:00
Pavel Feldman c7b074d39e
chore: prepare to reuse test server from ui mode (3) (#29989) 2024-03-18 17:14:21 -07:00
Dmitry Gozman 70e6cdac57
feat: enterFrame/exitFrame (#29992) 
This introduces `Locator.enterFrame()` and `FrameLocator.exitFrame()` to
convert between locator and frame locator.

Fixes #29336.
 2024-03-18 13:42:08 -07:00
Max Schmitt a6d1fb93de
fix(trace-viewer): encode attachment filenames as UTF-8 (#29993) 
Fixes https://github.com/microsoft/playwright/issues/29967

Tested in Firefox, Chromium, and Safari. This now leads to "good
attachment names" in Chromium and Safari, for Firefox, it won't produce
attachments, it will open them inline, but this is not a regression, was
before like that already.

See here for the spec:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition#filename_2

---------

Signed-off-by: Max Schmitt <max@schmitt.mx>
 2024-03-18 21:26:45 +01:00
Yury Semikhatsky 35db70ea1d
chore: trim file names longer than 60 chars (was 100) (#29725) 
Test-specific output dir and snapshot names are trimmed to 60 chars
instead of just 100. The snapshot names are still trimmed at 100 chars
for backwards compatibility.


Reference https://github.com/microsoft/playwright/issues/29719
 2024-03-18 12:53:15 -07:00
Pavel Feldman ef4438ee99
chore: prepare to reuse test server from ui mode (2) (#29966) 2024-03-18 09:59:02 -07:00
Pavel Feldman 6faadf5160
chore: prepare to reuse test server from ui mode (#29965) 2024-03-18 09:50:11 -07:00
Max Schmitt 0db1d40abc
fix(types): evaluate should not unpack return unions (#29971) 2024-03-18 16:42:33 +01:00
Playwright Service 306db80d03
feat(chromium-tip-of-tree): roll to r1202 (#29963) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
 2024-03-15 20:04:22 +01:00