Simon Knott
1b589c4bd3
Revert "fix(har timing): record connect timing for proxied connections" ( #32989 )
...
Reverts microsoft/playwright#32855 . This broke two tests on main, and we
don't yet know how to fix it other than downgrading.
2024-10-08 10:13:21 +02:00
Mark
04bf425268
feat(base-reporter): Add tags to test output ( #32930 )
2024-10-07 17:14:46 -07:00
Pavel Feldman
7047c3a6c6
fix(codegen): do not codegen non-existing fixtures ( #32993 )
...
Closes https://github.com/microsoft/playwright/issues/32981
2024-10-07 17:12:36 -07:00
Yury Semikhatsky
6ba5ee3a83
chore(ui-mode): expand all button ( #32994 )
...
<img width="230" alt="image"
src="https://github.com/user-attachments/assets/dd7fa3a1-39ec-4b88-9279-d664c9c4e5cd ">
Reference https://github.com/microsoft/playwright/issues/32825
2024-10-07 15:42:12 -07:00
Yury Semikhatsky
4ab857ce8e
test: fetch header propagation on redirect ( #32970 )
...
Documenting current behavior with and without interception.
Reference https://github.com/microsoft/playwright/issues/32939
2024-10-07 14:06:28 -07:00
Dmitry Gozman
e6afb650be
test: mark a few tests as fixme ( #32985 )
2024-10-07 02:58:03 -07:00
Max Schmitt
001ba37706
test: update webview2 skipme's ( #32984 )
...
This leaves only reasonable skipmes for WebView2 in the code base.
2024-10-07 11:08:07 +02:00
Simon Knott
de4a4d1ce1
fix(har timing): record connect timing for proxied connections ( #32855 )
...
Fixes a bug discovered in
https://github.com/microsoft/playwright/pull/32647 . When using http
proxy, the `connect` event isn't emitted so we don't populate
`tcpConnectionAt`. The updated version of `https-proxy-agent` emits a
`proxyConnect` as a replacement, so this PR updates and listens to that
event.
For socks proxies, the `on("socket")` event is emitted once the SOCKS
connection is established, which is the equivalent of having a TCP
connection available.
---------
Signed-off-by: Simon Knott <info@simonknott.de>
Co-authored-by: Max Schmitt <max@schmitt.mx>
2024-10-07 09:59:13 +02:00
Dmitry Gozman
b284df984b
test: enable test after chromium roll to 1140 ( #32965 )
...
Fixes #32355 . Fixed after the last roll #32949 .
2024-10-04 09:23:11 -07:00
Dmitry Gozman
9f842da8b3
fix: throw when element handle is detached while waiting for selector ( #32961 )
2024-10-04 08:23:25 -07:00
Dmitry Gozman
eaeaa0b158
test: remove tests that we are not going to ever fix ( #32962 )
2024-10-04 08:22:36 -07:00
Dmitry Gozman
34ad67659f
test: remove some fixmes ( #32953 )
2024-10-04 08:22:27 -07:00
Dmitry Gozman
84b4fd4e40
feat: wait for pending navigation to resolve before many actions ( #32899 )
...
This includes all actions that perform locator handler check.
Note this makes it impossible to interact with the page while a main
frame navigation is ongoing. This was already the case for Chromium, but
now WebKit and Firefox align with it.
Setting `PLAYWRIGHT_SKIP_NAVIGATION_CHECK` environment variable disables
this behavior.
2024-10-04 07:25:18 -07:00
Simon Knott
ff0c498904
fix(ct-vue): update default slot should work ( #32952 )
...
Closes https://github.com/microsoft/playwright/issues/32809
We were writing onto the wrong object.
2024-10-04 14:18:21 +02:00
Max Schmitt
dfa4ab8726
test: speed up only-changed CT test ( #32947 )
2024-10-04 10:06:56 +02:00
Yury Semikhatsky
d7020cba63
test: scroll mobile page with background-attachment: fixed ( #31992 )
...
Reference: https://github.com/microsoft/playwright/issues/31551
Reference: https://github.com/microsoft/playwright/issues/23573
2024-10-03 18:16:49 -07:00
Dmitry Gozman
6b1d0361cd
fix(chromium): reset mouse position upon page reuse ( #32944 )
...
Similarly to Firefox, move the mouse to (-1, -1) upon page reuse. This
fixes the corresponding test on all platforms.
2024-10-03 08:09:00 -07:00
Dmitry Gozman
d98fa5da2f
test: update some expectations for headed chromium, unskip tests ( #32943 )
2024-10-03 07:59:48 -07:00
Dmitry Gozman
0ffac886e8
test: fix android tests ( #32932 )
...
One test is removed, since it's impossible to fix. Hopefully, the rest
will pass.
2024-10-03 03:37:43 -07:00
Dmitry Gozman
3c5967d4f5
fix(trace viewer): clear old highlighted elements upon change ( #32917 )
...
When the list of highlighted elements changes over time, we should
update the elements marked as `__playwright_target__` in the snapshot.
A good example is an `expect(locator).toHaveText([...])` where the list
of elements changes from 4 items to 3 after clicking a "Delete" button.
2024-10-02 23:48:26 -07:00
Max Schmitt
8715652a0d
devops: don't run codegen tests in trace-events mode ( #32810 )
2024-10-02 23:22:00 +02:00
Simon Knott
29ffcdfc4e
test(html reporter): filtering by type works ( #32931 )
...
The folks who opened
https://github.com/microsoft/playwright/issues/32925 would benefit from
filtering by annotation existence. Turns out we already have it! This PR
adds a test to ensure it stays that way.
2024-10-02 16:29:27 +02:00
Dmitry Gozman
face24dc66
test: unflake/skip a few tests ( #32929 )
2024-10-02 06:58:21 -07:00
Simon Knott
3a5bf1cc1d
fix(trace viewer): reveal stack for highlighted action ( #32919 )
...
Closes https://github.com/microsoft/playwright/issues/32915 .
In the `Call` and `Logs` tabs, we update the contents based on the
hovered action. We document that this is also the case for the `Source`
tab:
78054a7652/docs/src/test-ui-mode-js.md
2024-10-02 13:30:44 +02:00
Simon Knott
208a54529d
fix(ct-react): support shorthand fragment notation ( #32900 )
...
Closes https://github.com/microsoft/playwright/issues/32853
Vite turns the shorthand fragment notation `<></>` into `import {
Fragment } from "react"; <Fragment></Fragment>`. On the Node.js side of
things, this `react` import resolves to our mock version of React, which
currently mocks `Fragment` as `{}`. Currently, we pass that straight to
`React.createElement`, which throws an error.
The fix is to make our `Fragment` mock detectable with a tag, and when
we render it replace it with the real `__pwReact.Fragment`.
2024-10-02 11:19:09 +02:00
Dmitry Gozman
773202867d
feat(trace): highlight strict mode violation elements in the snapshot ( #32893 )
...
This is fixing a case where the test failed with strict mode violation,
but all the matched elements are not highlighted in the trace.
For example, all the buttons will be highlighted when the following line
fails due to strict mode violation:
```ts
await page.locator('button').click();
```
To achieve this, we mark elements during `querySelector` phase instead
of inside `onBeforeInputAction`. This allows us to only mark from inside
the `InjectedScript` and remove the other way of marking from inside the
`Snapshotter`.
2024-10-02 00:00:45 -07:00
Max Schmitt
daac0ddd24
fix(fetch): fallback to given URL if baseURL is invalid ( #32911 )
2024-10-01 22:43:32 +02:00
Max Schmitt
c84305ed73
test: retry installation tests up to 3 times ( #32910 )
...
Installation tests can fail due to e.g. network issues. Lets align with
library tests and retry up to 3 times.
2024-10-01 13:12:38 -07:00
Yury Semikhatsky
228eb141db
chore(bidi): enable logs in Firefox on CI ( #32908 )
2024-10-01 11:15:27 -07:00
Max Schmitt
6f16b6cc08
chore: unflake 'should record' ( #32880 )
2024-09-30 20:32:04 +02:00
Dmitry Gozman
6f99d48a12
test: unflake two tests ( #32879 )
...
- the test that closes a context must not be a "page test";
- account for stray browser requests in the proxy test.
2024-09-30 07:49:18 -07:00
Simon Knott
c67a7335ab
chore(ui): ensure that --ignore-snapshots is respected ( #32875 )
...
Closes https://github.com/microsoft/playwright/issues/32868 .
The actual fix was already delivered in
https://github.com/microsoft/playwright/pull/32798/files#diff-98ff2ff92b08ca7e8b274abb3ba6b2eec9bab332e340d062cc18ad1dfe505bf2R299 ,
this PR adds a test to ensure we don't regress.
2024-09-30 15:12:37 +02:00
Max Schmitt
df16f6efb4
test: skip avif test on linux/webkit ( #32869 )
2024-09-30 10:30:45 +02:00
Max Schmitt
ded567d8f8
test: add test for avif image format ( #32815 )
...
Fixes https://github.com/microsoft/playwright/issues/32673
2024-09-27 10:02:54 -07:00
Dmitry Gozman
5947c21dc7
test: brush up fixtures, unflake some tests ( #32854 )
2024-09-27 07:06:37 -07:00
Dmitry Gozman
a395fb22c4
feat(routeWebSocket): address api review feedback ( #32850 )
2024-09-27 04:01:31 -07:00
Pavel Feldman
bcb6860ef5
chore: fix cross browser leak tests ( #32843 )
2024-09-26 19:33:07 -07:00
Yury Semikhatsky
728b4814b4
test: fix recently added junit tests ( #32844 )
2024-09-26 19:32:54 -07:00
Pavel Feldman
1a3d3f699b
chore: render recorded action list in tv mode ( #32841 )
2024-09-26 16:46:27 -07:00
Yury Semikhatsky
5b85c71722
fix(junit): env variable should take precedence over config ( #32842 )
...
Fixes https://github.com/microsoft/playwright/issues/32826
2024-09-26 15:29:09 -07:00
Max Schmitt
0d79291604
chore: hide screenshot instead of snapshot Trace Viewer feature ( #32832 )
2024-09-26 22:30:41 +02:00
Playwright Service
463bd55cf0
feat(webkit): roll to r2083 ( #32813 )
2024-09-26 21:49:02 +02:00
Pavel Feldman
9bff4d7eab
chore: move sw files into the sw/ folder ( #32837 )
2024-09-26 11:22:20 -07:00
Dmitry Gozman
6465f0b1bd
test: make sure custom asymmetric matchers work ( #32829 )
...
This adds a test for a regression introduced by #32366 and fixed by
#32795 .
2024-09-26 06:27:37 -07:00
Dmitry Gozman
a9d5c39d40
chore: address api review for page.forceGarbageCollection ( #32824 )
...
- Renamed to `page.requestGC`.
- Added a useful snippet to the docs.
References #32278 .
---------
Signed-off-by: Dmitry Gozman <dgozman@gmail.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
2024-09-26 05:08:33 -07:00
Dmitry Gozman
ff954b58eb
fix(test runner): cleanup DEBUG_COLORS usage ( #32764 )
...
`DEBUG_COLORS` we default to `1`, but we should not do that when it is
already defined to some value supplied by the user.
Closes #32543 .
2024-09-26 03:15:46 -07:00
Pavel Feldman
61801aa1ee
chore: more codegen fixes ( #32816 )
2024-09-25 18:18:36 -07:00
Yury Semikhatsky
b6783bb18b
fix(ui-mode): respect --tsconfig option ( #32798 )
...
Fixes https://github.com/microsoft/playwright/issues/32797
2024-09-24 19:59:15 -07:00
Pavel Feldman
35158feec0
chore: fix codegen flakiness ( #32799 )
2024-09-24 19:56:31 -07:00
Pavel Feldman
755edfba5b
chore: fallback expect.extend to legacy ( #32795 )
2024-09-24 14:00:13 -07:00
