Max Schmitt
a1d32d997c
fix(client-certificates): improve close handling from target and proxy ( #32158 )
2024-08-15 10:21:10 +02:00
Max Schmitt
aac3a84321
fix(client-certificates): stall on tls handshake errors ( #32163 )
...
Extracted from https://github.com/microsoft/playwright/pull/32158 .
2024-08-15 08:51:40 +02:00
Yury Semikhatsky
60900f8541
chore(webkit): add listeners directly without eventsHelper ( #32149 )
...
The listeners are never removed, so there is no point in wrapping them
with the helper
2024-08-14 08:38:49 -07:00
Max Schmitt
4daf5c2303
fix(client-certificates): when server does tls renegotiation ( #32155 )
...
Certain https servers like Microsoft IIS aka. TLS servers do the TLS
renegotiation after the TLS handshake. This ends up in two
`'secureConnect'` events due to an upstream Node.js bug:
https://github.com/nodejs/node/issues/54362
Drive-by: Move other listeners like `'close'` / `'end'` to `once()` as
well.
Relates https://github.com/microsoft/playwright/issues/32004
2024-08-14 15:11:29 +02:00
Playwright Service
856c4509a2
feat(chromium-tip-of-tree): roll to r1249 ( #32148 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-08-14 00:46:53 +02:00
Dmitry Gozman
f8eef3897c
chore: move urlMatch to isomorphic ( #32142 )
...
To be reused in injected code.
2024-08-13 12:47:02 -07:00
Yury Semikhatsky
6cc53cfce6
chore: move output parsing to concrete browsers ( #32129 )
2024-08-13 12:20:41 -07:00
Kuba Janik
0588834307
feat: allow URLSearchParams and string as params in APIRequestContext (follow-up) ( #32143 )
...
Follow-up to https://github.com/microsoft/playwright/pull/32120
I made some changes suggested by @yury-s in the previous PR that make a
lot of sense:
- added an example to the documentation
- improved tests
- check params on the client and server end
- reverted to non-English characters being used as params
2024-08-13 10:39:56 -07:00
Max Schmitt
b7ed4d7b9e
docs: deprecate: Request.serviceWorker() ( #32136 )
2024-08-13 15:59:30 +02:00
Yury Semikhatsky
a28f51a0f3
chore: use base BrowserType to reference browser types ( #32125 )
2024-08-12 22:20:58 -07:00
Kuba Janik
308381eeae
feat: allow URLSearchParams and string as params in APIRequestContext ( #32120 )
2024-08-12 14:22:03 -07:00
Yury Semikhatsky
2ae196f708
fix(docs): API types do not extend EventEmitter ( #32124 )
...
Fixes https://github.com/microsoft/playwright/issues/32097
2024-08-12 11:22:48 -07:00
Max Schmitt
0d575b4ef6
chore: less 'as any' in html-reporter ( #32117 )
...
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Simon Knott <info@simonknott.de>
2024-08-12 15:17:42 +02:00
Dmitry Gozman
a30a8805c9
fix(expect): account for timeout during the first locator handler check ( #32095 )
...
Also considered an alternative to not perform the locator handler check
during one-shot, but that would be somewhat against the promise of the
locator handler that is supposed to run **before** every expect check.
Fixes #32089 .
2024-08-12 01:57:15 -07:00
Playwright Service
e8d845be64
feat(webkit): roll to r2061 ( #32109 )
2024-08-10 11:44:32 +02:00
Playwright Service
4d26036b7b
feat(webkit): roll to r2060 ( #32082 )
...
Reference: https://github.com/microsoft/playwright/pull/32108
2024-08-09 15:31:35 -07:00
Dmitry Gozman
9b3e0e5667
chore: simplify binding result dispatch ( #32092 )
...
We can now pass an Error object through evaluate.
2024-08-09 03:46:52 -07:00
Playwright Service
5cc1e7b299
feat(firefox): roll to r1462 ( #32086 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-08-08 22:41:49 +02:00
Playwright Service
83b807385d
feat(firefox-beta): roll to r1462 ( #32087 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-08-08 22:41:09 +02:00
Playwright Service
69287f26bc
feat(chromium-tip-of-tree): roll to r1248 ( #32077 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-08-08 14:24:47 +02:00
Playwright Service
05732b50c8
feat(chromium): roll to r1130 ( #32074 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-08-08 14:13:18 +02:00
Playwright Service
48627ad484
feat(firefox-beta): roll to r1461 ( #32068 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-08-08 11:37:37 +02:00
Playwright Service
3d2b5e6801
feat(firefox-beta): roll to r1460 ( #32059 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-08-08 08:48:12 +02:00
Playwright Service
f8a7a301e6
feat(chromium-tip-of-tree): roll to r1247 ( #32030 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-08-08 08:37:38 +02:00
faulpeltz
ca25d2c802
fix: ubuntu version detection for linux mint 22 ( #32049 )
...
Add Linux Mint 22 (Ubuntu based distro) version detection for dependency
installation
Linux Mint 22.x -> Ubuntu 24.04
(also see original Linux Mint support PR #28085 )
2024-08-07 14:28:03 -07:00
Playwright Service
7449ca21f4
feat(firefox-beta): roll to r1459 ( #32054 )
2024-08-07 14:21:54 -07:00
Dmitry Gozman
ea747afcdd
chore: use a single binding for all Playwright needs ( #32039 )
...
This makes it easier to manage bindings, being just init scripts.
Fixes the BFCache binding problem.
Makes bindings removable in Firefox.
Fixes #31515 .
2024-08-07 06:20:12 -07:00
Yury Semikhatsky
43e852334b
docs: route.fallback() vs. route.continue() ( #32035 )
...
Fixes https://github.com/microsoft/playwright/issues/31983
2024-08-06 11:35:53 -07:00
Pavel Feldman
3c87f217df
feat(events): allow waiting for removeAllListeners ( #31941 )
2024-08-05 21:14:35 -07:00
Yury Semikhatsky
193013c9ee
docs(har): default update mode is minimal ( #32016 )
...
Update the documentation to match actual behavior.
The actual behavior today:
* Default mode is `full` when `recordHar` is passed to
`browser.newContext`
* Default mode is `minimal` when calling `context.routeFromHAR` and
`page.routeFromHAR`
Reference https://github.com/microsoft/playwright/issues/31983
2024-08-05 11:29:43 -07:00
Max Schmitt
613ccb8d5b
chore(client-certificates): rewrite error for unsupported PFX errors ( #32008 )
2024-08-05 14:42:29 +02:00
Max Schmitt
71e614dc5a
fix(client-certificates): report error to the browser if incorrect passphrase ( #32007 )
2024-08-05 10:54:33 +02:00
Playwright Service
c54567a46b
feat(webkit): roll to r2056 ( #31999 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-08-05 06:12:38 +02:00
Max Schmitt
d0c840f639
fix(clock): mock time in Event.prototype.timeStamp ( #31986 )
...
Ideally we generate the timestamp when the Event gets created. This
patch adds a best-effort logic, since we can't override the constructor
of natively created events, e.g. `MouseEvent`.
Fixes https://github.com/microsoft/playwright/issues/31924
2024-08-02 15:27:54 +02:00
Max Schmitt
878a6a499b
chore: prefer executablePath for page.pause() ( #31985 )
...
Motivation: For scenarios where
[`findChromiumChannel`](f17de8222f/packages/playwright-core/src/server/registry/index.ts (L1016)f17de8222f/packages/playwright-core/src/server/recorder.ts (L79)#6214 , but regressed since then.
Fixes https://github.com/microsoft/playwright/issues/31967
2024-08-02 11:18:51 +02:00
Max Schmitt
f17de8222f
chore: run client-certificate tests in service mode ( #31973 )
2024-08-02 08:34:28 +02:00
Yury Semikhatsky
db0980a850
chore(fetch): include response text into failOnStatusCode errors ( #31978 )
...
Fixes https://github.com/microsoft/playwright/issues/31834
2024-08-01 17:53:43 -07:00
Simon Knott
76cca7fc2c
fix(ui): only populate settings once ( #31958 )
...
We populate `localStorage` using an init script. Currently, this script
isn't just run for the UI though, but also for all iframes. So we're
resetting `localStorage` every time the UI loads an iframe.
This hasn't been a problem in the past, because the only consumer of
`localStorage`, `Settings`, only read from `localStorage` once and kept
most state in `useState` afterwards. With
https://github.com/microsoft/playwright/pull/31911 , this is no longer
true, so the bug starts biting us!
The fix is to ensure the init script isn't run on iframes.
2024-08-01 17:28:48 +02:00
Playwright Service
c858554dca
feat(chromium-tip-of-tree): roll to r1246 ( #31951 )
2024-08-01 15:13:15 +02:00
Playwright Service
6c6f10b678
feat(chromium): roll to r1129 ( #31955 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-08-01 14:32:44 +02:00
Playwright Service
a83134b270
feat(ffmpeg): roll to r1010 ( #31949 )
2024-08-01 13:17:11 +02:00
Playwright Service
6af2635343
feat(chromium-tip-of-tree): roll to r1245 ( #31948 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-08-01 10:27:02 +02:00
Yury Semikhatsky
edb89dcb66
chore: make sure error stack includes message as before #31691 ( #31934 )
...
This brings stack formatting to how it was prior to
1686e5174d
2024-07-31 10:58:37 -07:00
Max Schmitt
55187207e4
chore: various roll fixes for .NET ( #31914 )
2024-07-30 19:09:20 +02:00
Playwright Service
947f925443
feat(webkit): roll to r2054 ( #31910 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-07-30 12:24:14 +02:00
Max Schmitt
bd186640df
fix(client-certificates): use matching origin for connections on :443 ( #31913 )
...
Motivation: When using client-certificates on a website on port `443`,
we would normalise the user input with `new URL` but still generate a
"bad" representation of the "origin" internally, since the just do
concatenated "host:port".
(The origin doesn't contain the port in case of :443)
We use `clientCertificatesToTLSOptions` in two places:
a) for APIRequestContext, there we pass one from the URL constructor
over and
b) from the socks proxy, there we **now** also pass a "good one" over.
Test plan: We don't want to run the tests on port :443, so only manually
validated the fix.
Relates https://github.com/microsoft/playwright/issues/31906
2024-07-30 12:23:57 +02:00
Pavel Feldman
58b0c76f20
chore: use soft event emitter ( #31868 )
2024-07-29 17:11:31 -07:00
Max Schmitt
7e7319da7d
fix(client-certificates): don't use proxy when using BrowserContext.request ( #31898 )
2024-07-29 16:44:53 +02:00
Max Schmitt
f45cf65921
chore: add maxRetries to APIRequestContext.delete ( #31893 )
2024-07-29 14:39:30 +02:00
Max Schmitt
cc313f3290
fix(client-certificates): error response body Content-Length calculation ( #31897 )
2024-07-29 14:39:14 +02:00
Playwright Service
1a7d6749da
feat(webkit): roll to r2053 ( #31885 )
...
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
2024-07-26 20:32:12 +02:00
Playwright Service
7690694677
feat(webkit): roll to r2052 ( #31882 )
2024-07-26 20:29:31 +02:00
Max Schmitt
e784e2df01
chore: mark 1.47.0-next ( #31879 )
2024-07-26 17:50:11 +02:00
Max Schmitt
6988194c97
test: unflake contextmenu recorder test ( #31749 )
2024-07-26 12:43:05 +02:00
Max Schmitt
47e4e45bc2
chore: update WebKit version to 18.0 ( #31873 )
2024-07-26 11:32:51 +02:00
Max Schmitt
09581b615d
fix(client-certificates): return target errors on response when using http2 ( #31867 )
2024-07-26 11:28:45 +02:00
Max Schmitt
81b3c0c402
fix(client-certificates): include socks-certs in npm package ( #31872 )
2024-07-26 11:04:38 +02:00
Max Schmitt
a02ed38e60
chore: reduce file reads in client-certificates internal TLS server ( #31865 )
2024-07-25 22:36:25 +02:00
Dmitry Gozman
d8d5289e86
fix(remote): make sure api calls reject before browser is closed ( #31858 )
...
Upon calling `browser.close()` or dropping remote connection, make sure
to reject api calls before resolving `browser.close()` and firing a
`disconnected` event.
This change aligns the order guarantee with non-remote case.
2024-07-25 09:57:34 -07:00
Max Schmitt
0c6ecf8df4
chore: use happy eyeballs for client-certificates ( #31859 )
2024-07-25 18:55:47 +02:00
Playwright Service
d3e2c6cbb2
feat(chromium-tip-of-tree): roll to r1244 ( #31856 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-07-25 18:54:24 +02:00
Max Schmitt
90af289ba2
test: use managed http2 server for client-certificates ( #31844 )
2024-07-25 18:53:38 +02:00
Playwright Service
bdbe4795f1
feat(chromium): roll to r1128 ( #31848 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-07-25 09:42:53 +02:00
Max Schmitt
7570c25b3d
chore: remove glob from client-certificate matching ( #31846 )
...
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2024-07-24 19:13:03 +02:00
Max Schmitt
c5b7ce86dc
feat(client-certificates): add http2 support ( #31786 )
2024-07-24 11:39:39 +02:00
Pavel Feldman
c74843a914
chore(fetch): pass flush and finishFlush options to brotli ( #31833 )
...
Fixes https://github.com/microsoft/playwright/issues/31814
2024-07-23 18:28:34 -07:00
Yury Semikhatsky
1918ae5c4a
fix(webkit): reenable CrossOriginOpenerPolicy ( #31765 )
...
Depends on https://github.com/microsoft/playwright-browsers/pull/1160
Fixes: https://github.com/microsoft/playwright/issues/14043
2024-07-23 15:02:47 -07:00
Max Schmitt
c4862c022c
chore: client certificates api review ( #31826 )
2024-07-23 22:56:36 +02:00
Yury Semikhatsky
383e4b3c73
Revert "feat: introduce touchscreen.touch() for dispatching raw touch… ( #31823 )
...
… events (#31457 )"
This reverts commit a3e31fd2c4
2024-07-23 10:29:37 -07:00
Max Schmitt
b9c4b6bff0
chore: client certificates refactorings ( #31822 )
2024-07-23 19:18:31 +02:00
Simon Knott
2cc4e14756
fix(core): update maxRetries docs ( #31810 )
2024-07-23 08:27:27 -07:00
Max Schmitt
526e4118fa
chore: use socks.Duplex constructor instead of extending ( #31816 )
2024-07-23 15:44:16 +02:00
Playwright Service
d5a77c0f0b
feat(chromium-tip-of-tree): roll to r1243 ( #31812 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-07-23 15:22:06 +02:00
Andrey Lushnikov
d23ea26947
feat(firefox): roll Firefox & Firefox-Beta to 1458 ( #31807 )
...
Fixes https://github.com/microsoft/playwright/issues/31525
Closes https://github.com/microsoft/playwright/pull/31806
Closes https://github.com/microsoft/playwright/pull/31805
2024-07-23 10:37:00 +02:00
Yury Semikhatsky
e269092ef9
Revert "fix: add 'window-management' to chromium browser ( #31687 )" ( #31801 )
...
This reverts commit 0aa2f06f68https://github.com/microsoft/playwright/issues/27198
2024-07-22 11:27:12 -07:00
Josh Soref
7abbbd0c84
docs: spelling ( #31779 )
...
Fixes misspellings identified by the [check-spelling
action](https://github.com/marketplace/actions/check-spelling ).
The misspellings have been reported at
https://github.com/jsoref/playwright/actions/runs/10015023629#summary-27685777352
The action will report that the changes in this PR would make it happy:
https://github.com/jsoref/playwright/actions/runs/10015023971#summary-27685778305
---
I understand that the commit messages will need to be reworded to match
house style. For the time being, these are merely noting the changes
they contain so that when I rebase or need to drop things, I can. --
I've already rebased once as someone fixed one of the items that my
draft work was going to fix.
---
## Testing
* The tests _mostly_ passed when I managed to trigger them, but there
were a handful of things that I didn't quite understand
* There are a large number of warnings relating to a bad interaction
between any workflow that uses this local action
b535139b32/.github/actions/run-test/action.yml (L74-L80)Azure/login#474 asking them to
refactor their action so that it doesn't cause so much noise while
running this repository's tests
* I'm vaguely curious as to why this repository has a `branch`
constraint for its `pull_request` events in its workflows -- that
constraint gave me a number of additional headaches while trying to
prepare this branch for this PR.
---------
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2024-07-22 06:45:22 -07:00
Playwright Service
af3d2ba9fe
feat(webkit): roll to r2048 ( #31778 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-07-20 14:27:41 +02:00
Max Schmitt
f104e920e0
fix(client-certificates): pass TLS servername for SNI ( #31761 )
2024-07-19 12:55:20 +02:00
Yury Semikhatsky
d007ff3b62
chore: make WKInterceptableRequest._requestId private ( #31762 )
...
With COOP navigation we may need to take over request in the new
provisional page where it will have different id. This is preparation to
that.
2024-07-18 15:19:53 -07:00
Max Schmitt
708def8804
fix(client-certificates): keep ignoreHTTPSErrors false by default ( #31760 )
2024-07-18 22:37:11 +02:00
Playwright Service
097f28def9
feat(chromium-tip-of-tree): roll to r1242 ( #31751 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-07-18 14:46:42 +02:00
Playwright Service
26c9478648
feat(chromium): roll to r1127 ( #31755 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-07-18 14:46:19 +02:00
Max Schmitt
453e3bdf9d
test: fix client-certificates tests on Windows ( #31750 )
2024-07-18 13:43:56 +02:00
Dmitry Gozman
e78ce8521d
feat(chromium-tip-of-tree): roll to r1241 ( #31748 )
...
Closes https://github.com/microsoft/playwright/pull/31650
Closes https://github.com/microsoft/playwright/pull/31705
Relates https://github.com/microsoft/playwright/issues/31747
2024-07-18 12:11:03 +02:00
Dmitry Gozman
6491e5b415
chore: deprecate/remove noWaitAfter from some actions ( #31739 )
...
The following actions keep `noWaitAfter` option: `click`, `selectOption`
and `press`.
All other actions that used to have `noWaitAfter` now behave like it was
set to true, not waiting for follow-up navigations. In the docs, this
option is marked as completely ignored.
A small logic change was made to compensate for this behavior: when
waiting for the `hitTargetInterceptor`, we now race it against
navigations to avoid stalling when navigation stalls. Previously,
waiting for the interceptor was disabled when `noWaitAfter` was passed,
and since it's impossible to pass this option now, we mitigate by never
stalling instead.
Fixes #31469 .
2024-07-18 00:19:08 -07:00
Matt Kleinsmith
e06481a332
fix(recorder): address custom context menus ( #31634 )
2024-07-17 11:45:48 -07:00
Playwright Service
3cb41739a0
feat(firefox-beta): roll to r1457 ( #31733 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-07-17 18:33:47 +02:00
Max Schmitt
e11c0c0cbb
fix(connect): annotate internal api calls correctly ( #31715 )
2024-07-17 09:00:47 +02:00
Yury Semikhatsky
8021312c99
chore: enable notification permission tests in WebKit ( #31699 )
...
The Notifications API has been supported in WebKit since 2022, enable
related permission and tests.
2024-07-16 09:44:38 -07:00
Max Schmitt
7ce9b7e56b
fix(setInputFiles): throw when uploading file in directory upload ( #31706 )
2024-07-16 15:55:35 +02:00
Playwright Service
a5ca9b7d37
feat(webkit): roll to r2047 ( #31701 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-07-16 08:28:58 +02:00
Ismael Onilearan
0aa2f06f68
fix: add 'window-management' to chromium browser ( #31687 )
2024-07-15 14:34:57 -07:00
Dmitry Gozman
6ee8f1de2d
Revert "chore: move artifacts recording to TestLifecycleInstrumentation ( #30935 )" ( #31686 )
...
This reverts commit ba5b460444
2024-07-15 07:01:51 -07:00
Dmitry Gozman
1686e5174d
chore: allow evaluating Error objects ( #31691 )
...
Previously, Error objects were replaced with strings.
Now, Error objects are reconstructed back from the serialized value.
2024-07-15 05:47:40 -07:00
Dmitry Gozman
074cc7d467
Revert "feat(trace): record trace upon browser closure ( #31563 )" ( #31677 )
...
This reverts commit bc27ca225e
2024-07-15 01:08:51 -07:00
Yury Semikhatsky
1b4d9003c6
fix(har): ignore boundary when matching multipart/form-data body ( #31672 )
...
Fixes https://github.com/microsoft/playwright/issues/31495
2024-07-12 16:59:48 -07:00
Max Schmitt
459b762565
chore: remove unused kTestSdkObjects ( #31665 )
2024-07-12 11:56:16 -07:00
Pavel Feldman
297143885a
fix(clock): ensure Date.now() is an integer ( #31648 )
...
Fixes https://github.com/microsoft/playwright/issues/31644
2024-07-12 11:44:25 -07:00
Max Schmitt
3127571b24
Revert "fix(chromium): pass --enable-gpu when running headless ( #30937 )"
...
This reverts commit d0b052e1e0
2024-07-12 20:12:56 +02:00
Playwright Service
68595ac385
feat(webkit): roll to r2045 ( #31664 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2024-07-12 19:24:38 +02:00
