Max Schmitt
4dfa55d1f1
chore(trace-viewer): move call tab copy button next to the value ( #31586 )
2024-07-08 10:23:19 +02:00
Dmitry Gozman
48db1b1663
fix(ui mode): allow --updateSnapshots ( #31584 )
...
Fixes #31408 .
2024-07-08 01:08:57 -07:00
ryanrosello-og
e36ebb6ede
feat(trace-viewer) add request urls for actions initiated via APIRequestContext ( #31534 )
2024-07-04 11:59:56 +02:00
ryanrosello-og
262586a46a
feat(trace-viewer) add copy to clipboard on the Source > Stacktrace tab ( #31394 )
2024-07-02 09:09:39 -07:00
Rui Figueira
9bc45ea2fc
feature(trace-viewer): embedded mode support PoC ( #30885 )
...
Companion PR of https://github.com/microsoft/playwright-vscode/pull/483
2024-06-28 10:36:11 -07:00
Yury Semikhatsky
a2b116aa39
fix(trace): ensure har entry _monotonicTime is always start time ( #31385 )
...
* Revert harTracer change from
aeba083da0https://github.com/microsoft/playwright/issues/31133
2024-06-19 15:06:20 -07:00
ryanrosello-og
ee63843f7d
feat(trace-viewer): add request method/status to the network details tab ( #31274 )
2024-06-19 09:05:20 -07:00
Carter Sande
701a405bdf
fix(trace-viewer): Rewrite file URIs in snapshots, like blob URIs. ( #31113 )
...
This allows snapshots of file:/// pages with external stylesheets,
images, etc to be rendered correctly in the trace viewer. (Otherwise, it
tries to request the file:/// URIs directly and the requests get blocked
by the browser.)
Fixes #31112 .
2024-06-10 11:44:52 +02:00
Yury Semikhatsky
9a11be3305
chore(trace-viewer): grid view z-index, source column in resource details ( #31094 )
...
New look for multiple contexts:
<img width="585" alt="image"
src="https://github.com/microsoft/playwright/assets/9798949/02dc5f54-0946-40a9-9459-942c4362a32e ">
2024-05-30 14:45:33 -07:00
Yury Semikhatsky
4c020c9861
chore(trace-viewer): preserve column widths after showing resource details ( #31093 )
...
* Column widths are now stored on in the NetworkPanel context, this way
they are not reset after selecting an empty range (and changing position
of the NetworkGridView in the component tree).
* Column widths values are now preserved if column set changes (e.g.
selecting entries from a single context and then from multiple
contexts).
2024-05-30 12:21:32 -07:00
Rui Figueira
f254290ab4
fix(trace-viewer): fix snapshot.html ( #31033 )
...
Actual path to get trace contexts is /contexts, not /context
2024-05-28 13:14:22 -07:00
Pavel Feldman
bff1e41add
chore: do not render post data if there is none ( #31008 )
...
Fixes https://github.com/microsoft/playwright/issues/30992
2024-05-24 09:27:49 -07:00
Pavel Feldman
7b27fc3916
chore: pass outputDir to uimode ( #30941 )
...
Fixes https://github.com/microsoft/playwright/issues/30886
2024-05-21 14:36:31 -07:00
Yury Semikhatsky
2734a05342
feat(trace-viewer): show nework request source id ( #30810 )
...
<img width="1392" alt="image"
src="https://github.com/microsoft/playwright/assets/9798949/dcfd4d71-4a41-48ac-9f24-2996200f966a ">
Fixes https://github.com/microsoft/playwright/issues/28903
2024-05-15 16:29:26 -07:00
Yury Semikhatsky
fb319e6d3d
fix: match client step and server action by explicit stepId ( #30641 )
...
Matching bu `apiName@wallTime` fails when two actions start at the same
time, e.g. two parallel api requests. Moreover, it results in trace
actions that have parent set to themselves, which in turn causes
infinite loop in the trace viewer. To avoid this problems we write
stepId explicitly to the library trace and use those step ids to find
corresponding test runner steps.
The stepId is passed via zone in case of expect, because the protocol
step is quite deep in the call chain after or explicitly in case of API
call steps created by the test runner instrumentation.
2024-05-14 12:10:46 -07:00
Yury Semikhatsky
873f3a03ac
chore(trace): add context create event for test runner ( #30697 )
...
Adding metadata event to the test.trace to simplify time computation
logic.
2024-05-14 09:00:33 -07:00
Yury Semikhatsky
00bf7ea815
chore(trace-viewer): more clear classification of trace contexts ( #30737 )
2024-05-09 17:28:39 -07:00
Yury Semikhatsky
a50cd30519
chore: use monotonic time for sorting ( #30735 )
...
* Use only monotonicTime for sorting, do not use wallTime for that
* Since test runner and the library can be running on different
machines, those machines may have clocks which are not synchronized. To
avoid problems in such cases we compute delta between test runner and
and library contexts based on a start time of action that exists in both
contexts.
2024-05-09 15:31:23 -07:00
Yury Semikhatsky
1a22e06062
chore: only patch callIds when there are multiple trace files ( #30721 )
2024-05-09 09:33:16 -07:00
Yury Semikhatsky
7a0c7730e7
fix(trace-viewer): make call ids unique across trace files ( #30720 )
2024-05-08 17:33:31 -07:00
Rui Figueira
cf3ff6531a
chore: make NodeSnapshot type recursive and more ( #30619 )
...
Also, deviceDescriptors are now imported with ESM import instead of require()
2024-05-08 11:08:40 -07:00
Yury Semikhatsky
0164dca302
chore: extract trace modernizer into its own class ( #30696 )
2024-05-07 11:42:28 -07:00
Dmitry Gozman
ab3df111c9
chore: remove TeleTestCase._resultsMap ( #30567 )
2024-04-26 10:11:01 -07:00
Pavel Feldman
ff3d3ae8f2
fix(ui): print config and global setup errors ( #30531 )
...
Fixes: https://github.com/microsoft/playwright/issues/30513
2024-04-24 18:54:48 -07:00
Yury Semikhatsky
8c181f7e2b
fix: rebuild project tree from scratch when listing tests ( #30407 )
...
Instead of filtering tests assuming there are no two projects with same
name we always rebuild test tree from scratch and restore previos test
results in the list mode.
Fixes https://github.com/microsoft/playwright/issues/30396
2024-04-18 16:49:07 -07:00
Max Schmitt
15b423106f
fix(ui-mode): do not loose run information after writing into testDir ( #30312 )
...
Partially reverts https://github.com/microsoft/playwright/pull/30008
that started to reset all test results upon listing tests, including the
test that did just run and triggered re-listing.
https://github.com/microsoft/playwright/issues/30300 .
2024-04-10 19:01:51 +02:00
Pavel Feldman
8ee286b366
chore: migrate to the testserver.initialize ( #30226 )
2024-04-03 12:50:56 -07:00
Pavel Feldman
7afd4170ea
chore: opt into stdio forwarding ( #30185 )
2024-03-30 18:45:10 -07:00
Max Schmitt
ffffb81c3b
fix: UI Mode tags without theme applied ( #30138 )
...
Trace Viewer theming is override based. By default you should have
something applied - an optional `dark-mode` class might be there too.
2024-03-27 16:46:26 +01:00
Dmitry Gozman
dd1eca2a9d
fix(trace viewer): show correct number of pages without screencast ( #30124 )
...
Exposed by the flaky "should open two trace files" test.
2024-03-26 10:25:12 -07:00
Max Schmitt
599185dd07
feat(ui-mode): show native tags in test tree ( #30092 )
...
This brings up the question that we would show the tag name twice if its
a tag in a title. This would be aligned to how HTML report is doing it.
Fixes https://github.com/microsoft/playwright/issues/29927
---------
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2024-03-26 01:06:22 +01:00
Pavel Feldman
7039ad0d11
chore: follow up to the api review for test server ( #30097 )
2024-03-25 15:42:58 -07:00
Max Schmitt
253a2f9a9c
chore: address UI Mode keyboard shortcut feedback ( #30088 )
...
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2024-03-25 19:48:20 +01:00
Pavel Feldman
ee9432b9da
chore: send test params over the wire in ui mode ( #30046 )
2024-03-22 13:49:28 -07:00
Pavel Feldman
a9fc4de37e
chore: queue run and list commands from ui ( #30033 )
2024-03-21 14:28:07 -07:00
Pavel Feldman
7ad0a12c23
chore: remove ui mode update globals ( #30031 )
2024-03-20 21:09:49 -07:00
Pavel Feldman
8a1ff34578
chore: split ui mode view into files ( #30029 )
2024-03-20 16:00:35 -07:00
Pavel Feldman
48ccc9cbcd
chore: prepare to reuse test server from ui mode (6) ( #30008 )
2024-03-20 13:43:26 -07:00
Pavel Feldman
0a22a86e2e
chore: prepare to reuse test server from ui mode (5) ( #30005 )
2024-03-19 14:08:21 -07:00
Pavel Feldman
54aca430b0
chore: prepare to reuse test server from ui mode (4) ( #29995 )
2024-03-19 13:00:49 -07:00
jonghoonpark
b929c0d8f7
feat(ui-mode): add key shortcuts for playwright uI test runner ( #29868 )
2024-03-19 12:36:42 +01:00
Max Schmitt
a6d1fb93de
fix(trace-viewer): encode attachment filenames as UTF-8 ( #29993 )
...
Fixes https://github.com/microsoft/playwright/issues/29967
Tested in Firefox, Chromium, and Safari. This now leads to "good
attachment names" in Chromium and Safari, for Firefox, it won't produce
attachments, it will open them inline, but this is not a regression, was
before like that already.
See here for the spec:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition#filename_2
---------
Signed-off-by: Max Schmitt <max@schmitt.mx>
2024-03-18 21:26:45 +01:00
Pavel Feldman
ef4438ee99
chore: prepare to reuse test server from ui mode (2) ( #29966 )
2024-03-18 09:59:02 -07:00
Max Schmitt
be465c6a1c
fix(trace-viewer): allow Chrome extension fallback in SW ( #29954 )
...
https://github.com/microsoft/playwright/issues/29144
2024-03-15 16:27:07 +01:00
Max Schmitt
3e78426acc
fix(trace-viewer): report upload error as aria-role=alert ( #29956 )
...
Turns out NVDA and Narrator work differently. This is a follow-up to
https://github.com/microsoft/playwright/pull/29838 which was not working
in NVDA before - looks like a NVDA bug. Using alert instead.
Relates
https://github.com/microsoft/playwright/issues/29095#issuecomment-1999332067
2024-03-15 16:25:36 +01:00
Pavel Feldman
94348bb3c5
chore: align test tree with vscode ( #29864 )
2024-03-14 15:44:35 -07:00
Dmitry Gozman
2ce421b27a
fix(trace viewer): synchronize monotonic times between context entries ( #29908 )
...
When displaying remote context trace and local test runner trace
together, we should not compare monotonic time between the two.
This change reuses existing logic for merging actions timing to also
update context boundaries and events by the same time delta.
Fixes #29767 .
2024-03-12 16:32:58 -07:00
Max Schmitt
84d3308969
chore: limit trace-viewer minimum viewport ( #29850 )
...
https://github.com/microsoft/playwright/issues/29100
2024-03-07 22:42:21 +01:00
Max Schmitt
9ca895dea0
fix(trace-viewer): trap focus inside drop-target popup ( #29845 )
...
https://github.com/microsoft/playwright/issues/29099
2024-03-07 22:24:21 +01:00
Max Schmitt
591d327eac
chore: trace-viewer a11y fixes ( #29838 )
2024-03-07 16:02:31 +01:00
Sarkis Matinyan
0c3f60e95e
fix(ui): show stack frames in ui mode ( #29560 )
...
#29558 , #29500
2024-03-06 12:29:35 -08:00
Pavel Feldman
8bf8091cb1
chore: extract the tele test tree ( #29824 )
2024-03-05 15:11:56 -08:00
Dmitry Gozman
abfd2c4e66
feat(ui mode): text filter should filter by explicit tags ( #29821 )
...
Fixes #29815 .
2024-03-05 10:58:55 -08:00
Pavel Feldman
e314b83e56
chore: iterate towards tele reporter reuse in vscode (2) ( #29812 )
2024-03-04 19:52:20 -08:00
Pavel Feldman
68284b0505
chore: inject string pool into the tele receiver ( #29781 )
2024-03-04 08:46:32 -08:00
Pavel Feldman
ef924c14e7
chore: do not use project id in telereporter ( #29776 )
2024-03-01 21:44:08 -08:00
Pavel Feldman
bbcc3c1238
chore: remove private config usage from telereporter ( #29771 )
2024-03-01 13:14:12 -08:00
Lukas Bockstaller
bd8d044433
feat(uimode) uses relative paths to establish websocket connection ( #29617 )
2024-02-26 15:09:24 -08:00
Dmitry Gozman
18ce0fa370
fix(trace viewer): replace blue dot with red dot+warning ( #29380 )
...
Also how the explanation on hover.
Fixes #29263 .
2024-02-06 08:27:45 -08:00
Max Schmitt
7d64ca4c54
fix(trace viewer): correctly trim locations on Windows ( #29321 )
...
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2024-02-02 18:18:34 +01:00
Pavel Feldman
020a39860d
chore: polish network panel highlight ( #29299 )
...
Fixes https://github.com/microsoft/playwright/issues/29287
2024-02-01 13:44:26 -08:00
Dmitry Gozman
cf6549687c
fix(trace viewer): reveal error location when it comes from the test ( #29268 )
...
Errors coming from the test runner do not have an associated `action`,
but have a `stack` that we can reveal.
2024-02-01 08:23:07 -08:00
Max Schmitt
36ebdfb441
fix: provisional fix for Trace Viewer source 404 ( #29192 )
...
Motivation: Sometimes the files are not available anymore on the Service
Worker side. The Trace Viewer frontend then falls back to `file?path=`
and uses its response, no matter what the response status is.
This patch checks for the response status code before using its
response.
e.g. https://github.com/microsoft/playwright-dotnet/issues/2775 after
some time / and some other reports.
---------
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2024-01-27 14:05:15 +01:00
Dmitry Gozman
8e607d509f
fix(recorder): disallow external imports ( #29129 )
...
Previously, new `Recorder` instance was given an existing
`InjectedScript`. However, we built a separate source for
`InjectedScript` vs `Recorder`, and both bundles contain their own copy
of all helper modules, e.g. `roleUtils`.
This resulted in two copies of helper modules, which is troublesome for
any module-level globals like a top-level cache. Depending on whether
`Recorder` or `InjectedScript` called into the helper, they would access
the different value of a module global, which lead to bugs.
To prevent this, we force any external dependencies to be imported
through the `InjectedScript.utils`.
2024-01-23 11:29:40 -08:00
Dmitry Gozman
300a0127de
Revert "feat(trace): allow Trace Viewer to include credentials when fetching traces cross-origin ( #28502 )" ( #29024 )
...
This reverts commit 3f3f332060#29019 .
2024-01-17 10:40:58 -08:00
Dmitry Gozman
48317af1cc
feat(trace): preserve noscript when javascript is disabled ( #28971 )
...
Closes #27504 , closes #27532 .
2024-01-12 12:11:39 -08:00
Pavel Feldman
a0750b7854
chore: network panel polish ( #28924 )
2024-01-10 15:28:33 -08:00
Pavel Feldman
fc5f34369a
chore: only highlight uncaught errors in source ( #28772 )
2023-12-22 14:19:53 -08:00
Pavel Feldman
f5c57d0e98
chore: reuse image diff component in trace/html ( #28727 )
...
Fixes https://github.com/microsoft/playwright/issues/28685
2023-12-22 10:17:35 -08:00
Max Schmitt
696237205a
fix(ui-mode): disconnected error styling ( #28681 )
...
Fixes https://github.com/microsoft/playwright/issues/28679
Fixes https://github.com/microsoft/playwright/issues/28680
2023-12-18 17:32:57 +01:00
Matt Jennings
3f3f332060
feat(trace): allow Trace Viewer to include credentials when fetching traces cross-origin ( #28502 )
...
Add the `'credentials': include` option on the trace fetch so the
browser can include cookies when fetching from a different origin,
assuming the origin returns the correct Access-Control-Allow-Origin and
Access-Control-Allow-Credentials headers.
Fixes #28501
2023-12-14 10:41:01 -08:00
Dmitry Gozman
d587435efa
feat(trace): show target point for raw mouse apis ( #28459 )
...
Fixes #27931 .
2023-12-07 06:27:49 -08:00
Dmitry Gozman
c7018951e5
fix(trace): title should not wrap over to the timeline ( #28496 )
2023-12-05 09:21:51 -08:00
Max Schmitt
f44ef81af7
fix(snapshot): broken snapshot after use of setInputFiles ( #28444 )
2023-12-01 09:38:50 -08:00
Max Schmitt
8efa8dbc1d
fix(ui-mode): make UI Mode projects scrollable ( #28438 )
...
Fixes https://github.com/microsoft/playwright/issues/28393
https://github.com/microsoft/playwright/assets/17984549/5791e422-f4e6-4202-b66c-b77bbb476c04
2023-11-30 13:26:03 -08:00
Max Schmitt
c137b23a6c
fix(trace-viewer): scroll over multiple pages ( #28316 )
...
Fixes https://github.com/microsoft/playwright/issues/28208
2023-11-29 11:27:19 -08:00
Pavel Feldman
022b36332d
chore: do not add to the internal action logs ( #28365 )
...
Fixes https://github.com/microsoft/playwright/issues/28319
2023-11-27 16:43:47 -08:00
Dmitry Gozman
5488c03d7f
chore: make asLocator() always safe ( #28207 )
2023-11-16 16:31:34 -08:00
Pavel Feldman
2bd7d67adc
chore: render testInfo errors in the Errors tab ( #28179 )
...
Fixes https://github.com/microsoft/playwright/issues/28056
2023-11-16 11:37:57 -08:00
Pavel Feldman
eeda25c47f
chore(recorder): glue the overlay to the top ( #28021 )
2023-11-07 12:58:41 -08:00
Dmitry Gozman
810382c074
chore(recorder): more UX fixes for text assertions ( #27995 )
2023-11-06 16:40:33 -08:00
Dmitry Gozman
ffd2e02aa3
feat(recorder): various UX fixes ( #27967 )
2023-11-04 21:18:27 -07:00
Pavel Feldman
e84dd4d708
fix(ui): do not fail on clashing groups ( #27943 )
...
Fixes https://github.com/microsoft/playwright/issues/27929
2023-11-02 20:50:08 -07:00
Dmitry Gozman
3dedbced13
feat(recorder): in-page overlay ( #27904 )
2023-11-01 15:56:49 -07:00
Max Schmitt
08b8181632
chore: make Trace Viewer start page AAA compliant ( #27879 )
2023-10-31 16:35:13 +01:00
Pavel Feldman
462e70ab82
chore: render sidebar tab selector as drop down ( #27844 )
2023-10-27 15:31:31 -07:00
Pavel Feldman
4d82d6801f
chore: render full pathname in network panel ( #27843 )
...
Fixes #27618
2023-10-27 14:14:24 -07:00
Dmitry Gozman
88f30d1ce2
feat: support firefoxUserPrefs in launchPersistentContext ( #27840 )
...
Fixes #27773 .
2023-10-27 09:24:41 -07:00
Dmitry Gozman
24deac458b
feat(expect): generate toHaveText ( #27824 )
2023-10-26 18:49:14 -07:00
Pavel Feldman
ff206bd9c1
chore: render time in the trace viewer log ( #27825 )
2023-10-26 14:45:15 -07:00
Pavel Feldman
778047facc
chore: stream trace viewer logs ( #27807 )
2023-10-26 11:15:43 -07:00
Pavel Feldman
47733b04fb
chore: do not select after hooks automatically ( #27805 )
2023-10-25 17:05:06 -07:00
Pavel Feldman
0bb9f7cdf7
feat(ui): show test status in trace view ( #27785 )
2023-10-24 16:41:40 -07:00
Max Schmitt
5fe77f9a6f
chore: better error for trace viewer over http:// ( #27722 )
...
We saw in the past a lot of users reporting issues like this. Maybe a
more readable error helps.
Before they just saw:
```
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'register')
at index.38834ec3.js:1:3775
at index.38834ec3.js:1:4006
```
Fixes https://github.com/microsoft/playwright/issues/27655
2023-10-23 18:21:19 +02:00
Pavel Feldman
f46c889449
chore: fix total progress reporting w/ deps ( #27716 )
2023-10-19 20:07:47 -07:00
Pavel Feldman
d003945a7b
chore(ui): do not watch output folders ( #27694 )
2023-10-19 15:53:57 -07:00
Pavel Feldman
70dbb9d83a
feat(trace): allow navigating from error to source ( #27464 )
2023-10-05 14:59:59 -07:00
Pavel Feldman
5a7b405bdb
chore: add console icon titles ( #27416 )
...
Fixes https://github.com/microsoft/playwright/issues/27411
2023-10-03 15:52:37 -07:00
Pavel Feldman
c7d9ae1c8b
ui(trace): make drawer appear under action list ( #27260 )
2023-09-22 10:43:44 -07:00
Dmitry Gozman
2af7d672ef
fix(tracing): bump trace version to V5, migrate V4 traces to consoleMessage.args ( #27162 )
...
This moves the fix in #27095 from `modernize` to `appendEvent`. The
reason is that `trace V4` is used both for older traces that do not have
`consoleMessage.args` and the new ones with `args`. Since we do not call
`modernize` for traces of the same version, the original fix does not
help in this case.
Fixes #27144 .
2023-09-19 16:21:09 -07:00
