playwright

Filip/playwright

Fork 0

Commit graph

Author	SHA1	Message	Date
Simon Knott	c8cc4f9c8b	chore(ui): update to react 18 (#32079 ) Part of https://github.com/microsoft/playwright/issues/31863. Updates most of our React usage to React 18. `recorder` doesn't seem to like it yet. I suspect that some of our code isn't compatible with concurrent mode, i've investigated that in https://github.com/microsoft/playwright/pull/32101. --------- Signed-off-by: Simon Knott <info@simonknott.de> Co-authored-by: Max Schmitt <max@schmitt.mx>	2024-08-12 13:50:11 +02:00
Simon Knott	99724d0322	refactor(ui): some react refactorings (#31900 ) Addresses https://github.com/microsoft/playwright/issues/31863. This PR is chonky, but the individual commits should be easy to review. If they're not, i'm happy to break them out into individual PRs. There's two main things this does: 1. Remove some unused imports 2. Add a `clsx`-inspired helper function for classname templating I wasn't able to replace `ReactDOM.render` with `ReactDOM.createRoot`. This is the new recommended way starting with React 18, and the existing one is going to be deprecated at some point. But it somehow breaks our tests, i'll have to investigate that separately.	2024-07-31 12:12:06 +02:00
Rui Figueira	9bc45ea2fc	feature(trace-viewer): embedded mode support PoC (#30885 ) Companion PR of https://github.com/microsoft/playwright-vscode/pull/483	2024-06-28 10:36:11 -07:00

Author

SHA1

Message

Date

Simon Knott

c8cc4f9c8b

chore(ui): update to react 18 (#32079 )

Part of https://github.com/microsoft/playwright/issues/31863. Updates
most of our React usage to React 18. `recorder` doesn't seem to like it
yet. I suspect that some of our code isn't compatible with concurrent
mode, i've investigated that in
https://github.com/microsoft/playwright/pull/32101.

---------

Signed-off-by: Simon Knott <info@simonknott.de>
Co-authored-by: Max Schmitt <max@schmitt.mx>

2024-08-12 13:50:11 +02:00

Simon Knott

99724d0322

refactor(ui): some react refactorings (#31900 )

Addresses https://github.com/microsoft/playwright/issues/31863. This PR
is chonky, but the individual commits should be easy to review. If
they're not, i'm happy to break them out into individual PRs.

There's two main things this does:

1. Remove some unused imports
2. Add a `clsx`-inspired helper function for classname templating

I wasn't able to replace `ReactDOM.render` with `ReactDOM.createRoot`.
This is the new recommended way starting with React 18, and the existing
one is going to be deprecated at some point. But it somehow breaks our
tests, i'll have to investigate that separately.

2024-07-31 12:12:06 +02:00

Rui Figueira

9bc45ea2fc

feature(trace-viewer): embedded mode support PoC (#30885 )

Companion PR of https://github.com/microsoft/playwright-vscode/pull/483

2024-06-28 10:36:11 -07:00

3 commits