Dmitry Gozman
734705e9b3
chore: elementHandle getters implemented through Frame ( #23557 )
...
This is a step towards not using handles for locator operations.
2023-06-09 07:18:13 -07:00
Dmitry Gozman
11659ceb73
fix(role): handle display:contents elements ( #23607 )
...
Fixes #23521 .
2023-06-08 16:00:48 -07:00
Dmitriy Dudkevich
187cfdc328
feat: ability to pass additional headers to selenium ( #23348 )
2023-06-08 10:41:36 -07:00
Dmitry Gozman
5cfd6d9fe9
fix(cr network): emit sw-handled requests when routing is enabled ( #23589 )
...
Previously, such requests were skipped because they never receive
`Fetch.requestPaused` as there was no real network.
Also cleanup some redundant tests and move them from chromium-only file.
Fixes #23424 .
2023-06-08 10:33:28 -07:00
Playwright Service
54a35dd108
feat(chromium): roll to r1067 ( #23593 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-06-08 19:03:48 +02:00
Pavel Feldman
0b30f2017c
chore: make trace server work over http ( #23561 )
2023-06-06 18:36:05 -07:00
Andrey Lushnikov
2e327c9d0c
fix: miscellaneous improvements for tracing UI ( #23558 )
...
- feat(tracing): mark API requests with "API" label
- feat(tracing): do not attribute any resources to `route.` API calls;
otherwise, network traffic might get inside the `route.` actions.
- fix(tracing): map actionIds from primary contexts to actionIds from
non-primary contexts
- fix(tracing): show leading `/` in URL path in network panel
This is a result of a pair-programming session with @pavelfeldman
2023-06-06 17:38:44 -07:00
Pavel Feldman
7579572688
chore: unflake the network status test ( #23551 )
2023-06-06 16:55:53 -07:00
Max Schmitt
8bc26a2b44
chore: wait for downloads getting removed on context.close() ( #23500 )
...
Before there was a race, that we ran into this code:
9cd49d5dd5/packages/playwright-core/src/server/browserContext.ts (L236-L237)9cd49d5dd5/packages/playwright-core/src/server/browserContext.ts (L429-L431)https://github.com/microsoft/playwright/pull/6151 where it
got introduced. So something for @yury-s.
Fixes https://github.com/microsoft/playwright/issues/22525
2023-06-06 20:38:36 +02:00
Pavel Feldman
6351630af2
chore: do not show the open error ( #23547 )
2023-06-06 11:09:08 -07:00
Pavel Feldman
d4349e5d6f
chore: print listening on message in terminal for web trace modes ( #23546 )
2023-06-06 09:36:49 -07:00
Pavel Feldman
699ac3a0f2
chore: allow opening ui mode over http ( #23536 )
2023-06-06 08:31:52 -07:00
Andrey Lushnikov
3a00fc4edf
fix: call focus() twice to workaround firefox not focusing element ( #23535 )
...
When focus is moved from one tab to another, it might require calling
`focus()` twice to actually focus an element in Firefox.
Fixes https://github.com/microsoft/playwright/issues/23117
2023-06-05 16:46:52 -07:00
Pavel Feldman
eacfff8127
chore: make trace viewer work over http ( #23531 )
2023-06-05 16:30:30 -07:00
Playwright Service
d95b6f40a4
feat(webkit): roll to r1860 ( #23494 )
...
Fixes https://github.com/microsoft/playwright/issues/20489
2023-06-05 09:51:39 -07:00
Dmitry Gozman
b518d1f6da
chore: update error message when using wrong cli ( #23512 )
...
Now recommends uninstalling other packages. Fixes #23314 .
Example messages:
```
Please install @playwright/test package before running "npx playwright show-report"
npm uninstall playwright playwright-firefox
npm install -D @playwright/test
```
```
Please install @playwright/test package before running "yarn playwright show-report"
yarn remove playwright playwright-chromium playwright-firefox playwright-webkit
yarn add -D @playwright/test
```
```
Please install @playwright/test package before running "pnpm exec playwright show-report"
pnpm remove playwright
pnpm add -D @playwright/test
```
2023-06-05 09:51:08 -07:00
Max Schmitt
75971af55b
feat(cli): introduce npx playwright uninstall ( #23128 )
...
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2023-06-05 18:50:21 +02:00
Max Schmitt
00f662531e
Revert "fix(tracing): workaround chromium scrollTop slowness" ( #23486 )
...
This commit reverts f6712ec43ahttps://github.com/microsoft/playwright/issues/14037#issuecomment-1122256514
and made sure that the performance did not regress. ~same.
Fixes https://github.com/microsoft/playwright/issues/23455
2023-06-02 23:25:55 +02:00
Yury Semikhatsky
401fc4cb9e
fix(tracing): record available response headers without waiting for extra info ( #23483 )
...
Fixes #23115
2023-06-02 14:15:20 -07:00
Ivaylo Pavlov
e3f91bbabf
Fix header to pass Selenium Grid Capabilities ( #23346 )
...
Fixes : #23345
2023-06-02 13:28:23 -07:00
Dmitriy Dudkevich
7ab754f5d5
fix: render actions in ui mode with browsers from selenium ( #23382 )
2023-06-02 13:24:21 -07:00
Pavel Feldman
5a14619bab
chore: render route markers in the trace network panel ( #23476 )
...
Fixes https://github.com/microsoft/playwright/issues/23040
2023-06-02 13:00:27 -07:00
Max Schmitt
b21c81d344
devops: add bot for Chromium --headless=new ( #23440 )
...
https://github.com/microsoft/playwright/issues/23389
2023-06-02 20:40:12 +02:00
Dmitry Gozman
835f14d7c9
fix(pause): ignore page.pause on the server ( #23417 )
...
Fixes #23051 .
2023-06-02 08:32:30 -07:00
Dmitry Gozman
14a1eaa474
chore: add Playwright to attribution ( #23447 )
...
This makes it easier to plumb all kinds of options around.
2023-06-01 17:54:43 -07:00
Playwright Service
3e73906027
feat(chromium): roll to r1066 ( #23433 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-06-01 16:03:49 +02:00
Dmitry Gozman
6bb5c0a549
fix: make evaluate not wait for scheduled navigations ( #23402 )
...
Fixes #23141 .
2023-05-31 14:08:44 -07:00
Pavel Feldman
658b1dfea3
chore: trace viewer server for vscode ( #23383 )
2023-05-30 18:31:15 -07:00
João Neves
7e6e5f0706
feat: Support React forwards refs and memo ( #23262 )
...
This PR fixes the react selector behavior to support components that are
wrapped by the memo or forwardRef React builtin functions.
Previously these components couldn't be selected. This PR fixes that
behavior, enabling selecting those components.
Current behavior:
```
const Foo = memo(() => <div id="foo_component" />);
Foo.displayName = "Foo";
...
playwright.$("_react=Foo") -> undefined
```
Fixed behavior:
```
const Foo = memo(() => <div id="foo_component" />);
Foo.displayName = "Foo";
...
playwright.$("_react=Foo") -> <div id ="foo_component" />
```
2023-05-30 17:14:47 -07:00
Max Schmitt
13f70b6d89
chore: have type modifiers directly on file import ( #23337 )
2023-05-30 21:11:35 +02:00
Max Schmitt
f819b1c72d
fix: trace viewer with global applied background-color ( #23362 )
...
Fixes https://github.com/microsoft/playwright/issues/23275
2023-05-30 17:58:29 +02:00
Pavel Feldman
ec972fb7c1
chore: make trace viewer self-desctruct on input disconnect ( #23291 )
2023-05-26 14:54:54 -07:00
Pavel Feldman
1e95b6d906
chore: allow sending trace URLs over stdin ( #23288 )
2023-05-25 15:38:47 -07:00
Playwright Service
c5c0b9a78b
feat(chromium): roll to r1065 ( #23281 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-05-25 13:04:36 -07:00
Yury Semikhatsky
bcc711145e
feat(webkit): roll to r1855 ( #23267 )
2023-05-24 16:09:58 -07:00
Dmitry Gozman
848f1dff3f
feat(trace): instantiate consoleAPI in popout with correct testIdAttribute ( #23238 )
2023-05-23 12:17:26 -07:00
Jasiel Guillén
700062c836
feat(screenshot): Add customizable color option for masked elements ( #23185 )
...
I added a new option to the screenshot method to customize the color of
the box when we want to mask some elements for the screenshot.
The default color is pink `#FF00FF`, but with this new option you can
specify the color you like the most, like a nice green `#00FF00`:
```js
await page.screenshot({
mask: [page.locator('div').nth(5)],
maskColor: "#00FF00",
})
```
---------
Signed-off-by: Jasiel Guillén <darkensses@gmail.com>
2023-05-22 18:44:44 -07:00
Andrey Lushnikov
5f36a2946e
fix: add missing webkit deps on ubuntu 20.04 ( #23209 )
...
Fixes https://github.com/microsoft/playwright/issues/23186
2023-05-22 15:43:09 -07:00
Pavel Feldman
631edc9744
chore(internal): generate code in jsonl ( #23124 )
2023-05-20 10:15:33 -07:00
Pavel Feldman
bd090e67df
lint: prevent object string concatenation ( #23172 )
2023-05-19 15:17:43 -07:00
Dmitry Gozman
bd33e5f8c0
fix(tracing): when zipping remotely, use correct file name ( #23171 )
...
Fixes #23108 .
2023-05-19 14:42:01 -07:00
Playwright Service
5957d8f306
feat(chromium): roll to r1064 ( #23130 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-05-18 15:52:45 +02:00
Playwright Service
f1e0aed03c
feat(chromium): roll to r1063 ( #23104 )
...
Fixes https://github.com/microsoft/playwright/issues/22967
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-05-18 00:49:13 +02:00
Max Schmitt
e80ff0df77
chore: don't install gstreamer for WebKit Ubuntu 20 ( #23062 )
2023-05-17 18:31:24 +02:00
Pavel Feldman
fbc461ede0
chore(trace): do not flush console events ( #23073 )
...
Fixes https://github.com/microsoft/playwright/issues/20626
2023-05-16 18:44:27 -07:00
Dmitry Gozman
fec5059fee
feat(connect): print debug log when remote connection failed ( #23069 )
2023-05-16 16:46:02 -07:00
Dmitry Gozman
62146b946c
fix(codegen): ignore previously hovered detached nodes ( #23057 )
...
Fixes #23043 .
2023-05-16 11:13:19 -07:00
Max Schmitt
17ab777db5
chore: set min viewport for WK on Win to 250x240 ( #22969 )
...
Follow-up for https://github.com/microsoft/playwright/pull/22956 .
2023-05-14 16:59:15 +02:00
Dmitry Gozman
9472f79d32
fix(reuse): reset mouse position in Firefox ( #22973 )
...
Otherwise, Firefox sometimes keeps the current position and triggers
unexpected hover effects.
Fixes #22432 .
2023-05-12 13:21:49 -07:00
Andrey Lushnikov
bf1aba885b
chore: fix lint
2023-05-12 13:04:11 -07:00
Andrey Lushnikov
eea7a8e638
browser(firefox): roll Firefoxes ( #22998 )
...
Fixes https://github.com/microsoft/playwright/issues/15405
Fixes https://github.com/microsoft/playwright/issues/22618
2023-05-12 11:27:19 -07:00
Andrey Lushnikov
d7f5f1f5fe
feat: default screenshot jpeg quality to 80 ( #22966 )
...
Fixes https://github.com/microsoft/playwright/issues/22436
2023-05-11 11:09:19 -07:00
Max Schmitt
00187172f2
chore: introduce minimal viewport for WebKit/Windows/headed ( #22956 )
...
Fixes https://github.com/microsoft/playwright/issues/22616
2023-05-11 17:54:05 +02:00
Playwright Service
d17d43c4fa
feat(firefox): roll to r1406 ( #22962 )
...
Fixes https://github.com/microsoft/playwright/issues/22580
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-05-11 08:18:51 -07:00
Dmitry Gozman
f2ad5bbfbb
fix(isVisible): return false during navigation ( #22943 )
...
Instead of throwing "Execution context was destroyed" error.
Drive-by: improve internal error messages for `ScopedRace` errors.
Fixes #22925 .
2023-05-10 16:56:59 -07:00
Dmitry Gozman
80f46892cd
fix(getByLabel): ignore empty aria-label ( #22935 )
...
Accessible name computation ignores empty aria-label, and so should
getByLabel.
Fixes #22915 .
2023-05-10 10:38:46 -07:00
Alexander Sorokin
cbf4f39957
fix: React selectors should work after unmount ( #22750 )
...
Fixes #22729
2023-05-10 06:18:01 -07:00
Yury Semikhatsky
75e106745f
fix(fetch): support proxy.bypass ( #22914 )
...
Fixes #21916
2023-05-09 14:51:49 -07:00
Pavel Feldman
5fb426e7db
fix(webkit): do not update console counter on unhandled rejections ( #22890 )
...
Fixes https://github.com/microsoft/playwright/issues/22886
2023-05-08 18:50:40 -07:00
Yury Semikhatsky
02a1a2e6a9
fix(webkit): define window.GestureEvent ( #22768 )
...
Polyfill GestureEvent so that Safari detection works.
Fixes #22735
2023-05-05 11:37:28 -07:00
Dmitry Gozman
160888df99
feat(locators): reland locator.and(locator) ( #22850 )
...
Removed in #22223 .
Fixes #22585 .
2023-05-05 11:14:01 -07:00
Dmitry Gozman
42328478ea
feat: make console/dialog events based on subscription ( #22835 )
...
This way we do not send events from the server unless the client is
interested.
Fixes #22621 .
2023-05-05 11:12:33 -07:00
Dmitry Gozman
2393602e8c
fix(reuse): ignore late bindings after dispatchers were disposed ( #22838 )
...
When reusing the context, we first dispose all dispatchers, and then
reset the page/context. If bindings are triggered during the reset, they
try to send messages on disposed dispatchers.
Since there is no way to unregister bindings, just ignore them after
disposal.
Fixes #22803 .
2023-05-05 11:10:53 -07:00
Dmitry Gozman
236c329ea9
feat: browserContext.on('dialog'/'console') ( #22805 )
...
Relanding #22033 and #21943 .
2023-05-04 15:11:46 -07:00
Dmitry Gozman
ca3629186c
fix(role): fix native controls text alternative when aria-labelledby is present ( #22800 )
...
Fixes #22779 .
2023-05-03 16:09:08 -07:00
Dmitry Gozman
3c724c2498
fix: do not crash upon download in unknown page ( #22774 )
...
Fixes #22551 .
2023-05-02 18:49:04 -07:00
Pavel Feldman
116fb349ce
chore: allow configuring test id attribute for codegen ( #22716 )
...
Fixes: https://github.com/microsoft/playwright/issues/22653
2023-04-29 12:04:33 -07:00
Playwright Service
e50e2e6bc9
feat(webkit): roll to r1840 ( #22686 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-04-27 17:37:19 +02:00
Max Schmitt
c5880f9994
chore(chromium): remove --disable-sync CLI switch ( #22667 )
...
Fixes https://github.com/microsoft/playwright/pull/22583
Fixes https://github.com/microsoft/playwright/issues/22560
Not relevant anymore, it only takes effect when profiles is signed in.
See https://bugs.chromium.org/p/chromium/issues/detail?id=1439737 .
2023-04-26 15:34:47 -07:00
Andrey Lushnikov
62bd41912d
chore: cleanup bandaid firefox pref ( #22570 )
...
This patch removes the bandaid preferences that got migrated
to the build.
2023-04-23 19:58:00 -07:00
Max Schmitt
f6aa9f49ce
chore: make evaluate work with busted Array.prototype.map/push ( #22528 )
...
Fixes https://github.com/microsoft/playwright/issues/22460
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2023-04-21 19:52:13 +02:00
Andrey Lushnikov
a919f5f66f
chore: attempt to fix firefox-beta WebGL tests on MacOS 12.6 ( #22548 )
...
Looks like https://phabricator.services.mozilla.com/D164016
disabled software rendering.
If Firefox-beta passes on MacOS, then this bandaid setting will be
migrated to the firefox-beta default settings.
2023-04-21 09:54:25 -07:00
Playwright Service
94b36a3805
feat(chromium): roll to r1060 ( #22529 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-04-20 18:21:29 +02:00
Pavel Feldman
0c70f6900e
chore: fix ui mode w/ multiple contexts ( #22514 )
...
Fixes: https://github.com/microsoft/playwright/issues/21895
2023-04-20 08:19:00 -07:00
Pavel Feldman
d45efe881f
chore: don't leak from waitFor ( #22465 )
...
Fixes https://github.com/microsoft/playwright/issues/22458
2023-04-18 11:11:46 -07:00
Playwright Service
4e9faba34d
feat(webkit): roll to r1834 ( #22462 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-04-18 19:41:56 +02:00
Pavel Feldman
9f661b710a
chore: bump the trace packet size to be 1Mb ( #22446 )
2023-04-17 18:36:08 -07:00
Pavel Feldman
00df08b3cf
chore: explicitly control actions with slow mo ( #22445 )
...
Fixes https://github.com/microsoft/playwright/issues/22273
2023-04-17 16:19:30 -07:00
Yury Semikhatsky
1fecc20238
feat(webkit): roll to r1830 ( #22412 )
...
https://github.com/microsoft/playwright/issues/22411
Fixes https://github.com/microsoft/playwright/issues/21892
2023-04-14 13:32:50 -07:00
Playwright Service
da8672711b
feat(firefox): roll to r1398 ( #22397 )
...
Fixes https://github.com/microsoft/playwright/issues/22343
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-04-14 07:24:54 -07:00
Andrey Lushnikov
8bb708be70
test: unflake inspector-cli tests ( #22347 )
...
This patch:
- changes the `childProcess` fixture to reliably SIGKILL all descendants
(children and grand-children, regardless of their process group).
This is achieved using the `ps` command to build the process tree, and
then send
`SIGKILL` to the descendant process groups.
- changes the `runCLI` fixture to **not** auto-close codegen by default;
the `childProcess` fixture will clean up all processes. This makes
sure that all `runCLI.waitFor()` commands actually wait until the
necessary
output.
- for a handful of tests that do actually want to auto-close codegen,
introduce an optional `autoCloseWhen` flag for the `runCLI` fixture
that makes sure to close the codegen once a certain output was reached.
2023-04-12 09:37:24 -07:00
Yury Semikhatsky
5cd9f83c7b
fix(webkit): properly set user agent in persistent context ( #22283 )
...
Fixes https://github.com/microsoft/playwright/issues/22274
2023-04-07 19:50:49 -07:00
Yury Semikhatsky
8d2502ee62
test: make page-leaks tests pass in electron ( #22277 )
...
They've been failing
https://devops.playwright.dev/flakiness.html#filter_spec=page%2Fpage-leaks.spec.ts&test_parameter_filters=%5B%5D×tamp=1680901928195
2023-04-07 17:20:49 -07:00
Playwright Service
26bbf8ca1b
feat(chromium): roll to r1058 ( #22264 )
2023-04-07 14:11:18 -07:00
Playwright Service
f610577a18
feat(webkit): roll to r1823 ( #22227 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-04-06 11:52:48 +02:00
Dmitry Gozman
08cef43e82
feat(locator): remove locator.and and locator.not ( #22223 )
...
Not shipping for now, after API review.
2023-04-05 16:28:13 -07:00
Dmitry Gozman
35afb056ea
feat(locator): filter({ hasNotText }) ( #22222 )
...
The opposite of `filter({ hasText })`.
2023-04-05 14:13:28 -07:00
Dmitry Gozman
bc1de5f28d
feat(locator): filter({ hasNot }) ( #22219 )
...
This is the opposite of `filter({ has })`.
2023-04-05 12:45:46 -07:00
Dmitry Gozman
d7b3836752
chore: revert console and dialog events on BrowserContext ( #22195 )
...
This reverts #22033 and #21943 , since there will be no immediate
benefits in v1.33.
2023-04-04 13:13:52 -07:00
Dmitry Gozman
ab85b23e67
fix(expect): report expect "Timed out" when it actually does ( #22174 )
...
Previously, it would say "Timed out" when page was closed at test
timeout, or not say "Timed out" when at least one element matched.
Fixes #21664 .
2023-04-03 15:06:13 -07:00
Dmitry Gozman
26c00a97a5
fix(expect): do not produce logs twice ( #22171 )
2023-04-03 15:05:40 -07:00
Pavel Feldman
3b9e62432d
chore: do not leak on clicks ( #22129 )
...
Fixes #22115
2023-03-31 18:18:45 -07:00
Dmitry Gozman
41e3e6d13f
fix(tracing): avoid clashing network file names ( #22126 )
...
With two contexts in the same test, we can get:
- `<testId>.network` and `<testId>-1.network` files;
- for export, we can copy `<testId>.network` into `<testId>-1.network`
and try to copy into a file when another trace is reading from it.
Fixes #22089 .
2023-03-31 17:29:39 -07:00
Pavel Feldman
0d9ec60dc7
chore: implement jsHandle._objectCount in chromium ( #22127 )
2023-03-31 15:52:01 -07:00
Dmitry Gozman
1fbefa694f
fix(role): update accessible name calculation for native buttons ( #22124 )
...
There is a new section in the spec:
https://w3c.github.io/html-aam/#button-element-accessible-name-computation
Fixes #21808 .
2023-03-31 14:17:18 -07:00
Dmitry Gozman
a95ced0fef
fix(waitFor): when frameLocator does not match, resolve hidden/detached states ( #22119 )
...
Fixes #21879 .
2023-03-31 10:54:07 -07:00
Dmitry Gozman
37d1659508
feat(connect): support special headers for debug/attachments ( #22106 )
...
`x-playwright-debug-log: value` headers are printed to `pw:browser`
debug log.
`x-playwright-attachment: name=value` headers are attached to each test.
Fixes #21619 .
2023-03-31 08:57:07 -07:00
Dmitry Gozman
539d9873c2
feat: rename Locator.filter(locator) to Locator.and ( #22101 )
2023-03-30 14:41:30 -07:00
Dmitry Gozman
e6148bb725
feat: Locator.not(locator) ( #22066 )
2023-03-30 08:52:30 -07:00
Playwright Service
da3f2c042e
feat(chromium): roll to r1057 ( #22093 )
...
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-03-30 15:36:15 +02:00
