Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity
10905 commits 34 branches 141 tags 223 MiB
Commit graph

490 commits

Author SHA1 Message Date
Pavel Feldman 53bf1995db
chore: do not leak internal page handles after closing page (#24169) 
Partial fix for https://github.com/microsoft/playwright/issues/6319

After this fix, the following scenario won't leak and the context state
(cookies, storage, etc) can be reused by the new page sessions:

```js
  for (let i = 0; i < 1000; ++i) {
    const page = await context.newPage();
    await page.goto('...');
    await page.close('...');
  }
```
 2023-07-12 14:51:13 -07:00
Yury Semikhatsky 700a925565
test: simplify emulate media + connectOverCDP test (#24166) 2023-07-11 14:20:05 -07:00
Yury Semikhatsky ee9f9e3239
test: emulate media should be isolated between CDP sessions (#24110) 
Failing test for #24109
 2023-07-11 11:34:18 -07:00
Pavel Feldman 067faa50d7
chore: migrate Promise.race to scopes to prevent leaks (#24160) 2023-07-11 10:38:08 -07:00
Dmitry Gozman aeba083da0
fix(snapshots): match resources by method (#24145) 
Fixes #24144.

Previously, we only matched by url, which confuses GET and HEAD requests
where the latter is usually zero-sized.

Also make sure that resources are sorted by their monotonicTime, since
that's not always the case in the trace file, where they are sorted by
the "response body retrieved" time.
 2023-07-10 20:04:48 -07:00
Pavel Feldman e234a6a037
chore: make tracing before/after test more robust (#24136) 2023-07-10 18:36:15 -07:00
Pavel Feldman 67ad2c2bf4
feat(ui): render all console / network messages in trace (#24115) 2023-07-10 12:56:56 -07:00
Pavel Feldman 50ba25e9a1
fix(trace): do not allow after w/o before (#24106) 
Fixes https://github.com/microsoft/playwright/issues/24087,
https://github.com/microsoft/playwright/issues/23802
 2023-07-07 17:16:26 -07:00
Dmitry Gozman 92c738b14a
test: unflake some tests (#23984) 2023-06-30 13:08:18 -07:00
zhengjitf 6f67f6b52b
fix(chromium): can get correct orientation angle on non-mobile devices (#23796) 
Fix #23772
 2023-06-23 11:34:09 -07:00
Dmitry Gozman 5821c547aa
fix(selector generator): use the same label definition as getByLabel (#23846) 
This extracts `getElementLabels` helper function to be used both for
generating and querying.
 2023-06-22 08:34:08 -07:00
Max Schmitt 0f9f863183
fix(codegen): generate no Enter keyboard events for textareas (#23775) 
Fixes https://github.com/microsoft/playwright/issues/23774
 2023-06-19 17:07:37 +02:00
Dmitry Gozman 132a5a4bf5
fix(trace viewer): prefer latest resource with the same url (#23763) 
When rendering snapshot, disregard earlier resources with the same url,
because it's most likely that the latest one was used for rendering.

An example would be reloading the page before the stylesheet has
finished loading. In this case, the stylesheet will be requested twice,
and the second copy that was not aborted should be used for the
snapshot.

Fixes #23709.
 2023-06-17 06:58:16 -07:00
Andrey Lushnikov 3c0fab489b
chore: miscellaneous trace viewer fixes (#23695) 
- properly annotate continued requests
- nest `attach` steps inside the related `expect` step
- fix primary-id-to-non-primary-id mapping
- make sure images in trace are not draggable

Fixes #23693

---------

Signed-off-by: Andrey Lushnikov <aslushnikov@gmail.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-06-14 09:37:19 -07:00
Dmitry Gozman 5b2e8a6a7a
chore: optional root for generateSelector (#23692) 2023-06-13 21:25:39 -07:00
Dmitry Gozman 734705e9b3
chore: elementHandle getters implemented through Frame (#23557) 
This is a step towards not using handles for locator operations.
 2023-06-09 07:18:13 -07:00
Dmitry Gozman 11659ceb73
fix(role): handle display:contents elements (#23607) 
Fixes #23521.
 2023-06-08 16:00:48 -07:00
Dmitry Gozman 5cfd6d9fe9
fix(cr network): emit sw-handled requests when routing is enabled (#23589) 
Previously, such requests were skipped because they never receive
`Fetch.requestPaused` as there was no real network.

Also cleanup some redundant tests and move them from chromium-only file.

Fixes #23424.
 2023-06-08 10:33:28 -07:00
Dmitry Gozman 4f8680f7a3
fix(pause): revert timeouts after pause (#23578) 
Fixes #23523.
 2023-06-07 12:30:10 -07:00
Andrey Lushnikov 2e327c9d0c
fix: miscellaneous improvements for tracing UI (#23558) 
- feat(tracing): mark API requests with "API" label
- feat(tracing): do not attribute any resources to `route.` API calls;
  otherwise, network traffic might get inside the `route.` actions.
- fix(tracing): map actionIds from primary contexts to actionIds from
  non-primary contexts
- fix(tracing): show leading `/` in URL path in network panel

This is a result of a pair-programming session with @pavelfeldman
 2023-06-06 17:38:44 -07:00
Pavel Feldman 7579572688
chore: unflake the network status test (#23551) 2023-06-06 16:55:53 -07:00
Pavel Feldman 2200892ac3
chore: unmute the console flush test (#23525) 
Closes https://github.com/microsoft/playwright/issues/23107
 2023-06-05 12:19:25 -07:00
Dmitry Gozman e4a1273afa
test: enable user agent override for download in Chromium (#23479) 
Fixes #22843.
 2023-06-02 15:02:54 -07:00
Pavel Feldman 5a14619bab
chore: render route markers in the trace network panel (#23476) 
Fixes https://github.com/microsoft/playwright/issues/23040


![net](https://github.com/microsoft/playwright/assets/883973/5191163e-63f9-4999-9197-d10dcd09a665)
 2023-06-02 13:00:27 -07:00
Max Schmitt 3c2a8fa306
chore: enable no-floating-promises ESLint rule for tests (#23376) 
https://github.com/microsoft/playwright/issues/23339
 2023-06-02 21:59:12 +02:00
Max Schmitt b21c81d344
devops: add bot for Chromium --headless=new (#23440) 
https://github.com/microsoft/playwright/issues/23389
 2023-06-02 20:40:12 +02:00
Dmitry Gozman 835f14d7c9
fix(pause): ignore page.pause on the server (#23417) 
Fixes #23051.
 2023-06-02 08:32:30 -07:00
Dmitry Gozman 14a1eaa474
chore: add Playwright to attribution (#23447) 
This makes it easier to plumb all kinds of options around.
 2023-06-01 17:54:43 -07:00
Dmitry Gozman 6bb5c0a549
fix: make evaluate not wait for scheduled navigations (#23402) 
Fixes #23141.
 2023-05-31 14:08:44 -07:00
Dmitry Gozman 2505d48b32
test: skip and unflake tests (#23399) 
- `should respect tracesDir and name` does not work with service mode;
- `isVisible during navigation should not throw` had a short timeout.
 2023-05-31 10:52:29 -07:00
Dmitry Gozman 6db6498565
chore: replace sigint handler per browser with a single one (#23317) 
Otherwise, multiple sigint handlers (one from each browser) would try to
`process.exit(130)` each.
 2023-05-30 13:54:04 -07:00
Max Schmitt 1f7223eb21
chore: test on Node.js 20 (#22651) 
Fixes https://github.com/microsoft/playwright/issues/22582
 2023-05-30 18:16:34 +02:00
Max Schmitt 9e75b95153
fix: display testId as regex in trace-viewer (#23361) 
Fixes https://github.com/microsoft/playwright/issues/23298
 2023-05-30 17:45:48 +02:00
Dmitry Gozman fa86f2aee0
chore: createHttpServer that destroys sockets upon close (#23294) 
This avoids the server hanging on close.
 2023-05-26 07:03:41 -07:00
Dmitry Gozman 00b34dddb2
chore: move TestServer under test/ (#23287) 2023-05-25 15:11:16 -07:00
Dmitry Gozman b1db4a8191
test: skip connecting 20 times on non-linux (#23239) 2023-05-23 12:16:22 -07:00
Pavel Feldman fd75b85510 Revert "chore: more tree gardening (#23119)" 
This reverts commit e6bc32b022.
 2023-05-23 12:04:44 -07:00
Pavel Feldman 6cce93b697
chore: explicit server mode control (#23215) 2023-05-23 10:56:37 -07:00
Pavel Feldman 631edc9744
chore(internal): generate code in jsonl (#23124) 2023-05-20 10:15:33 -07:00
Dmitry Gozman bd33e5f8c0
fix(tracing): when zipping remotely, use correct file name (#23171) 
Fixes #23108.
 2023-05-19 14:42:01 -07:00
Yury Semikhatsky 5004f908d9
devops: do not upload test-results artifacts (#23168) 2023-05-19 13:06:42 -07:00
Max Schmitt acdb71878e
test: unskip selenium driver test (#23129) 
Issue is that [when `stop()` is
called](28504f6dc7/tests/library/browsertype-launch-selenium.spec.ts (L202)),
`onExit()` gets called and then it throws an unhandled rejection.

This regressed in https://github.com/microsoft/playwright/pull/23028.

I didn't find a reason to keep onExit, so removed it for now since
transport should handle these scenarios.

Fixes https://github.com/microsoft/playwright/issues/23110
 2023-05-18 18:33:11 +02:00
Playwright Service 28504f6dc7
feat(chromium-tip-of-tree): roll to r1115 (#23109) 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
 2023-05-18 11:49:35 +02:00
Andrey Lushnikov e6bc32b022
chore: more tree gardening (#23119) 
https://github.com/microsoft/playwright/issues/23114
https://github.com/microsoft/playwright/issues/23115
https://github.com/microsoft/playwright/issues/23116
https://github.com/microsoft/playwright/issues/23117
https://github.com/microsoft/playwright/issues/23118
 2023-05-17 18:57:35 -07:00
Andrey Lushnikov 7ff82760de
chore: tree gardening (#23111) 
https://github.com/microsoft/playwright/issues/23107
https://github.com/microsoft/playwright/issues/23108
https://github.com/microsoft/playwright/issues/23110
 2023-05-17 17:54:34 -07:00
Dmitry Gozman be7984bdc9
fix(unroute): do not compare regexp instances (#23101) 
References #23092.
 2023-05-17 16:27:32 -07:00
Yury Semikhatsky 52feff39b3
chore: run primary tests with blob reporter (#23076) 2023-05-17 09:10:31 -07:00
Pavel Feldman fbc461ede0
chore(trace): do not flush console events (#23073) 
Fixes https://github.com/microsoft/playwright/issues/20626
 2023-05-16 18:44:27 -07:00
Max Schmitt 89aa02228f
devops: add macOS 13 coverage (#23065) 
Coverage https://github.com/microsoft/playwright/issues/22226
 2023-05-17 01:13:09 +02:00
Dmitry Gozman 62146b946c
fix(codegen): ignore previously hovered detached nodes (#23057) 
Fixes #23043.
 2023-05-16 11:13:19 -07:00