Commit graph

1104 commits

Author SHA1 Message Date
Max Schmitt 277eca1b98
devops: install all FF system dependencies with --full on build (#6657)
Before that it actually didn't install all needed dependencies and failed after that when starting the compiler suite. WebKit also installs dependencies with apt, so it should be fine to install them on OS level.
2021-05-19 15:16:33 -07:00
Andrey Lushnikov 4e979fd95e
browser(chromium): roll to latests Chromium (#6661) 2021-05-19 14:43:42 -07:00
Max Schmitt 8d4e6168aa
browser(webkit): added reduced motion emulation (#6645) 2021-05-19 22:42:54 +02:00
Yury Semikhatsky 5076cb3241
browsr(webkit): cherry-pick(mac-14): bootstrap script in utility world (#6591) (#6655) 2021-05-19 11:11:09 -07:00
Yury Semikhatsky c2de35e016
browser(webkit): roll to 05-18-21 (#6643) 2021-05-18 14:30:35 -07:00
Max Schmitt c4a6c2bcab
browser(firefox): added reduced motion emulation (#6618) 2021-05-18 21:23:12 +02:00
Andrey Lushnikov debffa7476
browser(firefox): make Juggler types compliant with protocol viewer (#6626)
Protocol viewer can't handle anonymous objects since it's not clear how
to refer to them.
2021-05-17 21:40:29 -07:00
Yury Semikhatsky ffa83f1f17
browser(webkit): bootstrap script in utility world (#6591) 2021-05-15 09:51:38 -07:00
Yury Semikhatsky 37d03e8b7b
browser(webkit): roll to safari-612.1.15-branch (#6587) 2021-05-14 13:06:55 -07:00
Joel Einbinder 5b223f92c8
browser(firefox): Browser.setScrollbarsHidden (#6457) 2021-05-14 08:06:34 -07:00
Andrey Lushnikov 654446a757
devops: fix Chromium windows archiving logic (#6568)
Turns out MINGW environment doesn't support Python-for-Windows
through shebang. Call python explicitly.
2021-05-13 15:10:08 -07:00
Andrey Lushnikov d02472a9e0
browser(firefox): fix uploads of large files in Firefox (#6547)
- to read post data of requests, we have to read stream
- to restore the stream later on, we have to rewind it back
- however, if the stream is large enough, it cannot be rewound back

This patch starts cloning post data streams if possible to avoid
back-rewinding them later on.

References #4704
2021-05-12 16:27:53 -07:00
Dmitry Gozman d627376147
browser(webkit): use correct request when navigation turns into download (#6516)
Currently, WebPageProxy uses `m_decidePolicyForResponseRequest` to create
the DownloadProxy form the navigation. However, this field is not properly
set for the following callstack:

```log
1 WebKit::WebProcessPool::createDownloadProxy(WebKit::WebsiteDataStore&, WebCore::ResourceRequest const&, WebKit::WebPageProxy*, WebKit::FrameInfoData const&)
2 WebKit::WebPageProxy::receivedPolicyDecision(WebCore::PolicyAction, API::Navigation*, WTF::RefPtr<API::WebsitePolicies, WTF::RawPtrTraits<API::WebsitePolicies>, WTF::DefaultRefDerefTraits<API::WebsitePolicies> >&&, WTF::Variant<WTF::Ref<API::NavigationResponse, WTF::RawPtrTraits<API::NavigationResponse> >, WTF::Ref<API::NavigationAction, WTF::RawPtrTraits<API::NavigationAction> > >&&, WTF::Ref<WebKit::WebPageProxy::PolicyDecisionSender, WTF::RawPtrTraits<WebKit::WebPageProxy::PolicyDecisionSender> >&&, WTF::Optional<WebKit::SandboxExtension::Handle>, WebKit::WebPageProxy::WillContinueLoadInNewProcess) +1ms
3 WebKit::WebPageProxy::receivedNavigationPolicyDecision(WebCore::PolicyAction, API::Navigation*, WTF::Ref<API::NavigationAction, WTF::RawPtrTraits<API::NavigationAction> >&&, WebKit::ProcessSwapRequestedByClient, WebKit::WebFrameProxy&, WTF::RefPtr<API::WebsitePolicies, WTF::RawPtrTraits<API::WebsitePolicies>, WTF::DefaultRefDerefTraits<API::WebsitePolicies> >&&, WTF::Ref<WebKit::WebPageProxy::PolicyDecisionSender, WTF::RawPtrTraits<WebKit::WebPageProxy::PolicyDecisionSender> >&&) +1ms
4 WebKit::WebPageProxy::decidePolicyForNavigationAction(WTF::Ref<WebKit::WebProcessProxy, WTF::RawPtrTraits<WebKit::WebProcessProxy> >&&, WebKit::WebFrameProxy&, WebKit::FrameInfoData&&, unsigned long long, WebKit::NavigationActionData&&, WebKit::FrameInfoData&&, WTF::Optional<WTF::ObjectIdentifier<WebKit::WebPageProxyIdentifierType> >, WebCore::ResourceRequest const&, WebCore::ResourceRequest&&, IPC::FormDataReference&&, WebCore::ResourceResponse&&, WebKit::UserData const&, WTF::Ref<WebKit::WebPageProxy::PolicyDecisionSender, WTF::RawPtrTraits<WebKit::WebPageProxy::PolicyDecisionSender> >&&)::$_6::operator()(WebCore::PolicyAction, API::WebsitePolicies*, WebKit::ProcessSwapRequestedByClient, WTF::RefPtr<WebKit::SafeBrowsingWarning, WTF::RawPtrTraits<WebKit::SafeBrowsingWarning>, WTF::DefaultRefDerefTraits<WebKit::SafeBrowsingWarning> >&&, WTF::Optional<WebKit::NavigatingToAppBoundDomain>)::'lambda'(WebCore::PolicyAction)::operator()(WebCore::PolicyAction) +0ms
```

This patch updates `m_decidePolicyForResponseRequest` on the above codepath,
and it is reset immediately in `WebPageProxy::receivedPolicyDecision`.
2021-05-12 12:38:59 -07:00
Yury Semikhatsky d540b4478b
browser(firefox-stable): simplify isolated world structures (#6542) 2021-05-12 10:46:19 -07:00
Yury Semikhatsky 84031d4a07
browser(firefox): simplify isolated world structures (#6521) 2021-05-12 08:52:08 -07:00
Yury Semikhatsky 958629fae7
browser(webkit): roll to safari-612.1.14-branch (#6517) 2021-05-11 15:34:28 -07:00
Yury Semikhatsky 269a1b6407
browser(firefox-stable): bindings in isolated worlds (#6504) 2021-05-11 09:34:10 -07:00
Yury Semikhatsky f8039bed10
browser(firefox): bindings in isolated worlds (#6493) 2021-05-11 09:27:39 -07:00
Pavel Feldman 8d21b12454
browser(firefox): fit screencast images into given frame (#6495) 2021-05-10 22:01:41 -07:00
Pavel Feldman a5143ebaa9
browser(webkit): fix the screencast scale and toolbar offset on Mac (#6474) 2021-05-09 14:47:33 -07:00
Dmitry Gozman f1a65820f4
browser(firefox): fix addBinding on pages with CSP (#6470) 2021-05-08 18:06:56 -07:00
Pavel Feldman b4261ec074
browser(ff-stable): pick up screencast changes (#6464) 2021-05-07 21:47:40 -07:00
Pavel Feldman edd2cc807c browser(ff): migrate screencast to client interfaces 2021-05-07 21:01:01 -07:00
Pavel Feldman 78ec057117
browser(firefox): implement screencast (#6452) 2021-05-06 19:11:42 -07:00
Andrey Lushnikov 262824deb7
devops: fix chromium archiving with FILES.cfg (#6450)
- unset `IFS` variable so that it doesn't affect future script execution
- use `\n\r` separator on windows
- fix script to be Python2/Python3 compliant
2021-05-06 13:55:55 -07:00
Pavel Feldman 45d92890af
fix(webkit): quick fix for screencast (#6448) 2021-05-06 13:10:17 -07:00
Andrey Lushnikov 1101268697
devops: fix //browser_patches/export.sh for deprecated-webkit (#6446) 2021-05-06 11:41:07 -07:00
Andrey Lushnikov b1f80bad39
browser(firefox-beta): roll Firefox to v89.0b9 (May 6, 2021) (#6443) 2021-05-06 11:03:58 -07:00
Andrey Lushnikov fa7b5f3cd0
browser(chromium): roll Chromium to 879910 (#6441) 2021-05-06 10:53:20 -07:00
Andrey Lushnikov c7751b9fc3
devops: use chromium's FILES.cfg to compute archive files (#6438)
Since the include list of files to pack with Chromium changes
eventually, we should use their list instead of hardcoded one
on our side.
2021-05-06 10:36:33 -07:00
Yury Semikhatsky e4272fab08
browser(webkit): add stdc++fs lib to wtf to fix Ubuntu 18.04 (#6437) 2021-05-06 10:09:28 -07:00
Pavel Feldman 765d74987f
chore(ff): remove some dead code (#6423) 2021-05-05 13:27:51 -07:00
Yury Semikhatsky 8d66edf6b3
browser(webkit): roll to safari-612.1.13-branch (#6422) 2021-05-05 12:03:40 -07:00
Pavel Feldman 9b8dc4ae00
browser(webkit): fix Ubuntu18, make vp9 build hermetic (#6421) 2021-05-05 11:33:04 -07:00
Andrey Lushnikov 5509527917
devops: do a full browser checkout by default on Dev machines (#6411)
The `git fetch --unshallow` is a non-trivial command to run, so we
should default to a full checkout unless we're on CI.
2021-05-05 01:12:03 -07:00
Pavel Feldman ee835fba6c
fix(webkit): fix screencast compilation on win (#6412) 2021-05-04 18:19:17 -07:00
Andrey Lushnikov 77c1020193
devops: re-use firefox checkout for firefox-stable (#6410)
Every patch to Firefox should also go to firefox-stable. This patch
starts re-using Firefox-beta checkout for firefox-stable, making
possible to easily rebaseline work atop of firefox-stable.

With this patch, working on a patch in Firefox is a 2-step
process:
1. work on a patch against Firefox-Beta
2. rebaseline your work atop of Firefox-Stable

Working on Firefox-Beta is as usual:
- setup an up-to-date firefox checkout:
  ```sh
  $ ./browser_patches/prepare_checkout.sh firefox
  ```
- create a new branch for your firefox work off `playwright-build`:
  ```sh
  $ cd ./browser_patches/firefox/checkout
  $ git checkout -b my-feature
  ```
- once work is done, export your branch:
  ```sh
  $ ./browser_patches/export.sh firefox
  ```

Rebaselining your work for Firefox-Stable takes advantage of a single
checkout:
- prepare a firefox-stable checkout:
  ```sh
  $ ./browser_patches/prepare_checkout.sh ff-stable
  ```
- rebaseline your feature branch atop of stable:
  ```sh
  $ cd ./browser_patches/firefox/checkout
  $ git checkout my-feature
  $ git rebase -i playwright-build
  ```
- make sure firefox-stable compiles:
  ```sh
  $ ./browser_patches/firefox-stable/build.sh
  ```
- export firefox-stable:
  ```sh
  $ ./browser_patches/export.sh ff-stable
  ```
2021-05-04 17:46:24 -07:00
Dmitry Gozman 5c5196104e
browser(firefox-stable): cherry pick recent changes from browser_patches/firefox (#6409) 2021-05-04 17:01:48 -07:00
Pavel Feldman fc9454eb76
browser(webkit): implement screencast (#6404) 2021-05-04 12:57:03 -07:00
Andrey Lushnikov 5326f39021
browser(chromium): build 878941 that reverts shader changes (#6407) 2021-05-04 11:51:45 -07:00
Joel Einbinder 1a58281394
browser(firefox): don't record video outside the viewport (#6361) 2021-05-04 05:33:32 -07:00
Andrey Lushnikov 4e0e13cf05
browser(firefox-beta): roll Firefox to beta 89.0b8 - May 2, 2021 (#6397) 2021-05-04 00:45:07 -07:00
Andrey Lushnikov fd4253991f
devops: fix swiftshader on Chromium Windows (#6391)
References #6390
2021-05-03 11:25:01 -07:00
Andrey Lushnikov 6c04b82256
browser(firefox-beta): roll @ beta Apr 29, 2021 - v89.0b6 (#6368) 2021-04-29 16:37:45 -07:00
Yury Semikhatsky 0abcaf02c8
browser(webkit): roll to safari-612.1.12-branch (#6367) 2021-04-29 15:46:22 -07:00
Yury Semikhatsky b0fae0f831
browser(firefox): merge FrameData into Frame (#6365) 2021-04-29 15:09:10 -07:00
Yury Semikhatsky 3b1bfdff48
devops(chromium): build a new Chromium 876873 (#6349) 2021-04-28 10:19:07 -07:00
Yury Semikhatsky 0039b313b8
browser(webkit): support downloads larger than 16Kb on Windows (#6343) 2021-04-27 16:21:23 -07:00
Yury Semikhatsky 83480850d3
browser(webkit): preserve color scheme override after navigation (#6333) 2021-04-26 16:23:07 -07:00
Andrey Lushnikov f4b8c3a848
browser(firefox): disable proton UI for now (#6327)
The new Proton UI breaks certain screencast tests. Disable
this for now.
2021-04-26 10:59:12 -07:00
Dmitry Gozman 10c76ff56f
browser(firefox): fix race between idleTasksFinishedPromise and window closure (#6308) 2021-04-23 16:05:37 -07:00
Andrey Lushnikov 83758fa48c
devops: add swiftshader DLL to chromium archive (#6305) 2021-04-23 14:36:45 -07:00
Andrey Lushnikov 531bf4dc19
browser(chromium): roll Chromium to new Dev (#6283) 2021-04-22 17:38:53 -07:00
Joel Einbinder f9478b124f
browser(webkit): fix compilation for drag drop and duplicated macro (#6278) 2021-04-22 17:05:17 -07:00
Yury Semikhatsky 2755d5e37d
browser(webkit): fix timezone override on Windows (#6277) 2021-04-22 16:10:12 -07:00
Andrey Lushnikov 111e55992e
devops: roll Chromium to r871980 (#6275)
NOTE: this is a non-dev revision. We roll to it to make sure
that swiftshader issues are fixed now.

See https://crbug.com/1200964
2021-04-22 15:03:48 -07:00
Andrey Lushnikov 59d1d2df2f
devops: add swiftshader file to Chromium builds (#6274)
See https://chromium-review.googlesource.com/c/chromium/src/+/2845811
2021-04-22 14:55:53 -07:00
Yury Semikhatsky 34e03fc77d
browser(webkit): roll to 04-21 (#6257) 2021-04-21 13:00:36 -07:00
Andrey Lushnikov faf39a23ac
devops: fix firefox-stable roll build (#6255) 2021-04-20 16:55:35 -07:00
Andrey Lushnikov 4dd8a1c8f1
browser(firefox-stable): roll to Firefox 88.0 (#6249) 2021-04-20 13:46:46 -07:00
Andrey Lushnikov 09c35adbd5
browser(firefox): roll firefox-beta to Apr 20, 2021 - version 89.0b2 (#6247) 2021-04-20 13:27:57 -07:00
Joel Einbinder ce0098d9eb
devops(chromium): build a new Chromium Dev 870763 (#6203) 2021-04-15 11:58:09 -07:00
Yury Semikhatsky 96cee43861
browser(webkit): roll to safari-612.1.11-branch (#6185) 2021-04-12 12:38:11 -07:00
Andrey Lushnikov 82e8c7226d
devops: fix firefox-stable build script (#6175)
The old mach used `--no-interactive` flag at a different place.
2021-04-09 22:36:24 -07:00
Andrey Lushnikov 17c6406e6c
devops: add firefox-stable channel browser (#6173)
This adds a firefox-stable application to build on our bots.
This is basically a rebaselined version of 66541552d0

The firefox base revision is bb9bf7e886
Which is taken from `about://buildconfig` of a stable Firefox version
on Mac as of Apr 9, 2021.

References #5993
2021-04-09 22:13:19 -07:00
Ross Wollman 957abc49e9
devops(chromium): build a new Chromium Dev 869727 (#6149) 2021-04-09 11:54:14 -07:00
Yury Semikhatsky 5fe3ee13f0
browser(webkit): fix assertion unsafe to ref/deref from different threads (#6163) 2021-04-09 11:36:01 -07:00
Yury Semikhatsky bd0043b8cb
browser(webkit): keep browser process running when all windows closed (#6131) 2021-04-07 19:13:20 -07:00
Yury Semikhatsky d6c415749a
browser(webkit): fix curl compilation (#6115) 2021-04-06 22:24:14 -07:00
Andrey Lushnikov 4bec81b111
browser(firefox): roll Firefox to beta @ Apr 6, 2021 (#6111) 2021-04-06 17:25:18 -07:00
Yury Semikhatsky fb7c703157
browser(webkit): roll to 06-04-21 (#6106) 2021-04-06 14:56:03 -07:00
Andrey Lushnikov 2c6c816a41
devops: add firefox-ubuntu-20.04 as expected build (#6063) 2021-04-02 21:37:12 -07:00
Andrey Lushnikov 5a1974ccad
devops(chromium): build a new Chromium Dev 867878 (#6061) 2021-04-02 16:08:17 -07:00
Andrey Lushnikov 46949cd2df
devops: start doing separate builds for Firefox @ Ubuntu 20.04 (#6058)
This will fix webgl issues with headful firefox on Ubuntu 20.04

See
https://github.com/microsoft/playwright/pull/5951#issuecomment-8125735670
2021-04-02 14:16:25 -07:00
Joel Einbinder 2357f0b562
browser(firefox): fix bootstrap on bots with --no-interactive (#6047)
The command --no-interactive moved and broke our build. See https://bugzilla.mozilla.org/show_bug.cgi?id=1695272
2021-04-02 07:52:42 -07:00
Andrey Lushnikov d662eba86a
browser(firefox): roll Firefox to beta @ Apr 1, 2021 (#6041)
Merging conflicts:
038f367c30

After this roll, we no longer require our custom `onFrameLocationChanged` instrumentation
since gecko now fixed the `NOTIFY_LOCATION` behavior so that it works
for same-document navigations inside iframes.
2021-04-01 16:49:01 -07:00
Dmitry Gozman 66541552d0
browser(firefox): make dpr emulation optional, take screenshots at 1x (#5555)
- deviceScaleFactor is now optional, so we can use host machine's dpr.
- Screenshots are not scaled up by dpr.
- Removed unused methods.
2021-04-01 14:51:02 -07:00
Joel Einbinder d71c147af7
browser(firefox): fix some missing mac edit commands (#6034) 2021-04-01 11:27:44 -07:00
Andrey Lushnikov cb15603ccb
browser(firefox): do not report console messages twice. (#6031)
References #6001
2021-04-01 09:29:33 -07:00
Dmitry Gozman 9b2e4ebf73
browser(webkit): make dpr emulation optional, take screenshots at 1x (#5557)
- deviceScaleFactor is now optional, so we can use host machine's dpr.
- Screenshots are not scaled up by dpr.
2021-03-31 21:37:54 -07:00
Pavel Feldman 2f5bf04f51 browser(webkit): fix double deref 2021-03-31 00:12:11 -07:00
Pavel Feldman 3455c3265f browser(webkit): restore occlusion detection disabled 2021-03-30 23:52:11 -07:00
Yury Semikhatsky 93d532b5e1
browser(webkit): fix windows compilation (#6011) 2021-03-30 14:42:23 -07:00
Yury Semikhatsky 97955247a2
browser(webkit): roll to safari-612.1.9-branch (#6002) 2021-03-30 11:29:37 -07:00
Yury Semikhatsky 94252231f0
fix(devops): include libANGLE-shared.dylib into mac archive (#6004) 2021-03-30 11:29:03 -07:00
Yury Semikhatsky 0d3d27d3ee
browser(webkit): trigger new build after updating cleanup script (#5997) 2021-03-29 23:55:07 -07:00
Yury Semikhatsky 9473f39b0b
fix(devops): cleanup now removes entire webkit build dir on mac (#5996) 2021-03-29 23:48:34 -07:00
Ross Wollman 6d6f802e5a
fix: favicon with color pref crashes firefox (#5977) (#5979) 2021-03-29 14:53:18 -07:00
Pavel Feldman 4cf0568ad7
browser(webkit): support safe area insets (#5987) 2021-03-29 11:38:26 -07:00
Yury Semikhatsky 2cce8850b7
browser(webkit): roll to safari-612.1.8-branch (#5965) 2021-03-26 11:54:55 -07:00
Pavel Feldman 6c1d3f65b5
browser(webkit): refresh embedder UI on macOS (#5957) 2021-03-26 09:44:31 -07:00
Yury Semikhatsky 5872d0407a
browser(chromium): build current dev chromium (865012) (#5950) 2021-03-25 09:31:41 -07:00
Yury Semikhatsky 7d7e5ede84
browser(webkit): roll back to safari-612.1.7-branch first commit (#5920) 2021-03-23 13:45:42 -07:00
Andrey Lushnikov 172de4082a
browser(chromium): build current dev chromium (#5911) 2021-03-22 17:38:28 -07:00
Yury Semikhatsky b74af2269f
browser(webkit): fix mac compilation after latest roll (#5909) 2021-03-22 14:34:58 -07:00
Yury Semikhatsky 6dd4d756dc
browser(webkit): roll to 03-22-21 (#5903) 2021-03-22 11:22:56 -07:00
Andrey Lushnikov 1fab84577a
browser(firefox): roll Firefox to beta @ Mar 16, 2021 (#5852) 2021-03-17 00:46:02 -07:00
Andrey Lushnikov 8dc740570a
devops: refactor check_cdn.sh script (#5835)
Introduce `EXPECTED_BUILDS` list in each application folder and use
these lists when determining if all builds are ready.
2021-03-16 01:14:45 -07:00
Andrey Lushnikov e64f66685a
devops: fork webkit into a separate browser (#5834)
Official WebKit no longer supports Mac 10.14. However, since
this system is still very much in use, we want to be able to
keep it running for a while.

This patch adds a new browser that we would compile and maintain
specifically for Mac 10.14: `deprecated-webkit-mac-10.14`. This
browser is a clone of Webkit r1443 that is the last known revision
to compile on Mac 10.14.

As we move on, we're free to modify this browser however we want,
backporting important patches.

References #5833
2021-03-16 01:08:21 -07:00
Andrey Lushnikov 8565e72e63
chore: consolidate browser cheatsheets (#5832) 2021-03-15 17:54:25 -07:00