Commit graph

6 commits

Author SHA1 Message Date
Yury Semikhatsky ce55cdffb8
fix: update path to cli.js in run-driver-win.cmd (#29538)
This was missed in https://github.com/microsoft/playwright/pull/29131

Fixes the following error in java on windows:

```
Error: Cannot find module 'C:\Users\RUNNER~1\AppData\Local\Temp\playwright-java-910508779801292985\package\lib\cli\cli.js'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1144:15)
    at Module._load (node:internal/modules/cjs/loader:985:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12)
    at node:internal/main/run_main_module:28:49 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}
```
2024-02-16 19:35:11 -08:00
Yury Semikhatsky f8100bbb25
fix: expect unquoted npde.exe path (#21307)
* It is more common to set env variable value without quotes on Windows
(see the bug)
* Use defined to check for string presence, it will work nicely with
strings that contain whitespaces

https://github.com/microsoft/playwright-java/issues/1213
2023-03-01 09:16:23 -08:00
Hylke Postma b695478840
fix(driver): AttributeError error when CWD contains space (#19801) 2023-01-02 14:36:07 +01:00
Max Schmitt a5eee6d960
fix(driver): with CWD which contained spaces (#17579)
Fixes https://github.com/microsoft/playwright-python/issues/1561
Fixes https://github.com/microsoft/playwright-python/issues/1565
2022-09-26 19:19:04 +02:00
Yury Semikhatsky ed1e5efc5c
feat: allow running driver with preinstalled node.js (#16518) 2022-08-15 09:27:35 -07:00
Dmitry Gozman d47fb6a780
feat(cli): build driver and upload to cdn (#4841) 2021-01-05 14:04:47 -08:00