Commit graph

3 commits

Author SHA1 Message Date
Yury Semikhatsky e9fe663e89
cherry-pick(#21104): chore: consolidate http/https fetching (#21284)
Fixes #21227

Fixes https://github.com/microsoft/playwright/issues/20784 Supersedes
https://github.com/microsoft/playwright/pull/21076
2023-03-01 12:55:49 -08:00
Max Schmitt 92eb8e5090
chore: make connectOverCDP work with localhost (#20396)
This wraps happy eyeballs in two places, the place where we make the
JSON request to Chromium and the actual CDP WebSocket request.

It required changes inside our happy eyeballs implementation since the
[websocket library does not
set](https://github.com/websockets/ws/blob/master/lib/websocket.js#L714)
the `clientRequestOptions.hostname` field, it just sets the `host` field
where we then fall back to when its not set.

This test would pass before Node.js 18 and fail after Node.js 18 without
my changes.

Fixes https://github.com/microsoft/playwright/issues/20364
2023-01-30 17:44:26 +01:00
Yury Semikhatsky 10ccfa9517
feat(fetch): happy eyeballs (#19902)
Fixes #18790
2023-01-05 14:39:49 -08:00