Max Schmitt
c4862c022c
chore: client certificates api review ( #31826 )
2024-07-23 22:56:36 +02:00
Yury Semikhatsky
383e4b3c73
Revert "feat: introduce touchscreen.touch() for dispatching raw touch… ( #31823 )
...
… events (#31457 )"
This reverts commit a3e31fd2c4
2024-07-23 10:29:37 -07:00
Max Schmitt
b9c4b6bff0
chore: client certificates refactorings ( #31822 )
2024-07-23 19:18:31 +02:00
Simon Knott
f23d02a211
feat(test runner): --only-changed option ( #31727 )
...
Introduces an `--only-changed [base ref]` option.
`playwright test --only-changed` filters the test run to only run test
suites that have uncommitted changes.
`playwright test --only-changed=foo` runs only tests that were changed
since commit `foo`.
In pull request CI, this can be used to run changed tests first and fail
fast: `--only-changed=$GITHUB_BASE_REF`.
During local development, it can be used to quickly filter down to the
touched set of tests suites.
In some rare usecases, this can also help to cut down on CI usage for
pull requests. Tread with caution though.
File dependencies are taken into account to ensure that if you touched a
utility file, all relevant tests are still executed.
Closes https://github.com/microsoft/playwright/issues/15075
2024-07-23 18:04:17 +02:00
Dmitry Gozman
e86c8af599
chore: rename route fixture in ct ( #31817 )
...
Addresses review feedback.
2024-07-23 07:43:28 -07:00
Simon Knott
bbe5df3f5f
fix(ui): when --grep is used, UI should only show selected tests ( #31815 )
...
Closes https://github.com/microsoft/playwright/issues/31617 .
2024-07-23 15:29:08 +02:00
Andrey Lushnikov
d23ea26947
feat(firefox): roll Firefox & Firefox-Beta to 1458 ( #31807 )
...
Fixes https://github.com/microsoft/playwright/issues/31525
Closes https://github.com/microsoft/playwright/pull/31806
Closes https://github.com/microsoft/playwright/pull/31805
2024-07-23 10:37:00 +02:00
Simon Knott
1408a45595
chore(ct): remove suite dependency by connecting dependency graphs at read time, not write time ( #31794 )
...
Broken out of https://github.com/microsoft/playwright/pull/31727 as per
@dgozman's
[request](https://github.com/microsoft/playwright/pull/31727#discussion_r1685793229 ).
The PR goal is to remove the `suite` argument from the Component
testing's Vite Plugin. `suite` is used to enrich Vite's dependency graph
with information about dependencies between test suites and helper
files. It essentially merges the Vite graph with the
`compilationCache.ts > fileDependencies` graph, and then writes the
result back into `compilationCache.ts > externalDependencies`.
By refactoring this to make the connection on the reading end in
`collectAffectedTestFiles`, we can drop the `suite` parameter.
We didn't yet have a test that depended on the dependency graph being
connected correctly between `fileDependencies` and
`externalDepedencies`, so I've [extended an existing
test](53a539938b
2024-07-23 10:19:58 +02:00
Dmitry Gozman
d87cb7a303
feat(trace viewer): allow hiding route actions ( #31726 )
...
Adds a new settings tab above the actions list.
<img width="307" alt="settings tab"
src="https://github.com/user-attachments/assets/792212b7-e2fd-4a5c-8878-654e2e060505 ">
Toggling the "Show route actions" checkbox hides all route calls:
`continue`, `fulfill`, `fallback`, `abort` and `fetch`.
References #30970 .
2024-07-22 11:34:34 -07:00
Yury Semikhatsky
e269092ef9
Revert "fix: add 'window-management' to chromium browser ( #31687 )" ( #31801 )
...
This reverts commit 0aa2f06f68https://github.com/microsoft/playwright/issues/27198
2024-07-22 11:27:12 -07:00
Yury Semikhatsky
bef87849e3
chore: show error when opening newer trace with old viewer ( #31781 )
...
Reference: https://github.com/microsoft/playwright-java/issues/1617
2024-07-22 08:16:25 -07:00
Dmitry Gozman
b535139b32
fix(trace viewer): library-only trace should not merge actions ( #31768 )
...
Without `wallTime`, actions are matched by `actionName:undefined` and
all actions with the same are merged.
Fixes #31764 .
2024-07-19 11:18:22 -07:00
Max Schmitt
b8546eb35e
test: unflake client-certificate WebKit tests ( #31776 )
2024-07-19 15:08:04 +02:00
Max Schmitt
f570c747d5
test: unskip har http2 test on WebKit Windows ( #31774 )
2024-07-19 13:44:56 +02:00
Max Schmitt
f104e920e0
fix(client-certificates): pass TLS servername for SNI ( #31761 )
2024-07-19 12:55:20 +02:00
Max Schmitt
0ecae56750
test: unflake 'should have ignoreHTTPSErrors=false by default' ( #31771 )
2024-07-19 12:04:12 +02:00
Max Schmitt
708def8804
fix(client-certificates): keep ignoreHTTPSErrors false by default ( #31760 )
2024-07-18 22:37:11 +02:00
Max Schmitt
297b1a8afe
test: move page-clock tests into library/ tests folder ( #31752 )
2024-07-18 14:45:45 +02:00
Max Schmitt
453e3bdf9d
test: fix client-certificates tests on Windows ( #31750 )
2024-07-18 13:43:56 +02:00
Dmitry Gozman
056997c41f
fix(toHaveScreenshot): attach "expected" when writing a missing expectation ( #31745 )
...
Previously, only the "actual" attachment was created, pointing to the
file in `test-results`. Now, the "expected" attachment pointing to the
file in `__screenshots__` is also created. This will help any reporters
that would like to know the "expected" path, for example to do a manual
accept/decline of the baseline.
Fixes #30693 .
2024-07-18 02:42:44 -07:00
Dmitry Gozman
6491e5b415
chore: deprecate/remove noWaitAfter from some actions ( #31739 )
...
The following actions keep `noWaitAfter` option: `click`, `selectOption`
and `press`.
All other actions that used to have `noWaitAfter` now behave like it was
set to true, not waiting for follow-up navigations. In the docs, this
option is marked as completely ignored.
A small logic change was made to compensate for this behavior: when
waiting for the `hitTargetInterceptor`, we now race it against
navigations to avoid stalling when navigation stalls. Previously,
waiting for the interceptor was disabled when `noWaitAfter` was passed,
and since it's impossible to pass this option now, we mitigate by never
stalling instead.
Fixes #31469 .
2024-07-18 00:19:08 -07:00
Matt Kleinsmith
e06481a332
fix(recorder): address custom context menus ( #31634 )
2024-07-17 11:45:48 -07:00
Yury Semikhatsky
3f15fe8518
feat(reporter): links in attachment names, attachments name only ( #31714 )
...
* Allow calling `test.info().attach('My text');` without options (no
path nor body).
* Highlight links in attachment names:
<img width="992" alt="image"
src="https://github.com/user-attachments/assets/770e7876-3e43-4434-8cf1-194ad6ae5819 ">
Fixes https://github.com/microsoft/playwright/issues/31284
2024-07-17 09:30:49 -07:00
Dmitry Gozman
f4399f7f06
fix(toHaveScreenshot): sanitize attachment names and paths ( #31712 )
...
... unless an array of file-system-friendly parts is provided.
Motivation: attachment name is used as a file system path when
downloading attachments, so we keep them fs-friendly.
References #30693 .
2024-07-17 07:08:43 -07:00
Simon Knott
8eab28d858
fix(list reporter): print step ends in non-TTY mode ( #31703 )
...
When used in a terminal, the `list` reporter prints out information
about test steps to help debugging. In non-TTY environments like GitHub
Actions, currently it doesn't.
This PR changes that, so that in non-TTY environments you'll see the
"step end" messages appearing, but not the "step begin" messages. This
is a good middleground, because it helps the user understand test
progress, without being too verbose.
Closes https://github.com/microsoft/playwright/issues/31674
2024-07-17 13:36:37 +02:00
Max Schmitt
ed6abf86c7
fix(expect): throw unsupported error when using this.equals() in expect ( #31723 )
2024-07-17 13:22:00 +02:00
Max Schmitt
e11c0c0cbb
fix(connect): annotate internal api calls correctly ( #31715 )
2024-07-17 09:00:47 +02:00
Max Schmitt
3694c1422d
Revert "test: rebase golden snapshots on Chromium macOS arm64 ( #31344 )" ( #31711 )
...
This reverts commit 02416877da3127571b24
2024-07-16 21:16:55 +02:00
Yury Semikhatsky
8021312c99
chore: enable notification permission tests in WebKit ( #31699 )
...
The Notifications API has been supported in WebKit since 2022, enable
related permission and tests.
2024-07-16 09:44:38 -07:00
Max Schmitt
7ce9b7e56b
fix(setInputFiles): throw when uploading file in directory upload ( #31706 )
2024-07-16 15:55:35 +02:00
Ismael Onilearan
0aa2f06f68
fix: add 'window-management' to chromium browser ( #31687 )
2024-07-15 14:34:57 -07:00
Max Schmitt
d463d1f285
fix(snapshotter): allow rendering of & in STYLE tags ( #31627 )
...
Fixes https://github.com/microsoft/playwright/issues/31607
2024-07-15 17:33:22 +02:00
Dmitry Gozman
6ee8f1de2d
Revert "chore: move artifacts recording to TestLifecycleInstrumentation ( #30935 )" ( #31686 )
...
This reverts commit ba5b460444
2024-07-15 07:01:51 -07:00
Dmitry Gozman
1686e5174d
chore: allow evaluating Error objects ( #31691 )
...
Previously, Error objects were replaced with strings.
Now, Error objects are reconstructed back from the serialized value.
2024-07-15 05:47:40 -07:00
Dmitry Gozman
074cc7d467
Revert "feat(trace): record trace upon browser closure ( #31563 )" ( #31677 )
...
This reverts commit bc27ca225e
2024-07-15 01:08:51 -07:00
Yury Semikhatsky
1b4d9003c6
fix(har): ignore boundary when matching multipart/form-data body ( #31672 )
...
Fixes https://github.com/microsoft/playwright/issues/31495
2024-07-12 16:59:48 -07:00
Pavel Feldman
297143885a
fix(clock): ensure Date.now() is an integer ( #31648 )
...
Fixes https://github.com/microsoft/playwright/issues/31644
2024-07-12 11:44:25 -07:00
Max Schmitt
3127571b24
Revert "fix(chromium): pass --enable-gpu when running headless ( #30937 )"
...
This reverts commit d0b052e1e0
2024-07-12 20:12:56 +02:00
Max Schmitt
71a668eb86
test: skip windows/CR client-certificates proxy tests ( #31662 )
2024-07-12 14:34:32 +02:00
Max Schmitt
9569cb5c1e
feat: support client certificates ( #31529 )
...
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
2024-07-12 11:42:24 +02:00
Max Schmitt
97e2aa07a5
test: fix Windows Socks tests ( #31654 )
2024-07-11 23:16:24 +02:00
Max Schmitt
89eef55dc7
chore: use own socks5 server for tests ( #31639 )
2024-07-11 14:12:48 +02:00
Dmitry Gozman
a1f82b0bb6
fix(trace): do not corrupt test runner actions when no library trace is present ( #31564 )
...
Recent logic that matches either by `stepId` or by `apiName`+`wallTime`
did not account for "no library trace" scenario.
2024-07-10 09:12:06 -07:00
Pavel Feldman
f374f8db38
chore: follow up to the attachments preview change ( #31598 )
2024-07-09 09:58:59 -07:00
Álvaro Martínez
00131c1e3f
feat(trace-viewer): display text attachments in ui mode ( #31215 )
2024-07-08 11:16:14 -07:00
Dmitry Gozman
21c4531618
fix(selector generator): do not reparent to invisible ancestor ( #31590 )
...
Fixes #31335 .
2024-07-08 09:07:25 -07:00
Dmitry Gozman
bc27ca225e
feat(trace): record trace upon browser closure ( #31563 )
...
Retaining traces in the following scenarios:
- browser crash;
- manual `browser.close()`;
- implicit `browser.close()` from the `browser` fixture upon test end.
This does not affect the library, where `browser.close()` will not
retain the trace and will close the browser as fast as possible.
References #31541 , #31535 , #31537 .
2024-07-06 11:34:34 -07:00
Dmitry Gozman
369a1eca48
feat(ct): experimental route fixture ( #31554 )
...
This fixture accepts the same arguments as `context.route()`, but also
supports request handlers compatible with msw syntax.
2024-07-06 09:35:20 -07:00
Max Schmitt
1132667ffe
chore: bump TypeScript to v5.5 ( #31532 )
2024-07-05 16:31:08 +02:00
Max Schmitt
2b94fa2e30
test: fix ESLint (remove unused imports)
2024-07-05 13:44:23 +02:00
Max Schmitt
f56978edb2
test: isolate proxy creds between contexts ( #31565 )
2024-07-05 13:24:06 +02:00
ryanrosello-og
e36ebb6ede
feat(trace-viewer) add request urls for actions initiated via APIRequestContext ( #31534 )
2024-07-04 11:59:56 +02:00
Dmitry Gozman
1c69d3e175
chore: update flakiness metadata for better ui presentation ( #31528 )
2024-07-03 08:39:53 -07:00
Max Schmitt
bfbd5f6f2f
test: snapshot with all: unset in StyleSheet ( #31514 )
2024-07-03 09:40:50 +02:00
Max Schmitt
9a3e0967e6
fix(electron): tracing with @playwright/test ( #31437 )
2024-07-01 19:19:38 +02:00
Max Schmitt
7040340d61
test: adjust upload folder expectation for msedge ( #31454 )
2024-07-01 12:19:04 +02:00
4ydx
4089f4593b
fix(codgen): assertValue works with disabled select ( #31315 )
2024-06-28 13:04:59 -07:00
Pavel Feldman
f46ae15500
test(clock): fix clock mode bots ( #31472 )
2024-06-28 11:46:28 -07:00
Yury Semikhatsky
a3e31fd2c4
feat: introduce touchscreen.touch() for dispatching raw touch events ( #31457 )
2024-06-27 14:37:36 -07:00
Pavel Feldman
c9e673c6dc
fix(utility): create utility world when web security is disabled ( #31458 )
...
Reverts previous attempt at #31096
Fixes: https://github.com/microsoft/playwright/issues/31431
Fixes: https://github.com/microsoft/playwright/issues/31442
2024-06-27 09:29:20 -07:00
Playwright Service
976373ed2c
feat(chromium-tip-of-tree): roll to r1234 ( #31418 )
2024-06-26 16:51:57 +02:00
Pavel Feldman
da441347e2
fix(runner): do not run beforeEach hooks upon skip modifier ( #31426 )
...
Fixes https://github.com/microsoft/playwright/issues/31425
2024-06-25 10:47:37 -07:00
Max Schmitt
f11ab2f145
chore: enable keepAlive in happy eyeballs http.Agent ( #31434 )
2024-06-25 19:05:32 +02:00
Pavel Feldman
122818c62c
feat: allow boxing and titling fixtures, simulate context fixture deps ( #31423 )
...
Fixes https://github.com/microsoft/playwright/issues/31411
2024-06-24 21:43:43 -07:00
Max Schmitt
47fb9a080d
fix(test-runner): don't add slow annotation twice ( #31414 )
2024-06-24 23:34:17 +02:00
Yury Semikhatsky
d74ddaebe7
fix: correctly report overridden headers on redirected requests ( #31409 )
...
Fixes https://github.com/microsoft/playwright/issues/31351
2024-06-21 17:44:58 -07:00
Max Schmitt
2285bcd55d
test: fix ct-vue-vite tests ( #31406 )
2024-06-22 00:50:10 +02:00
Max Schmitt
7e1b69cf33
test: update Electron to v30 ( #30334 )
2024-06-21 00:43:26 +02:00
Max Schmitt
6ed3b374a8
fix(electron): allow downloads ( #31390 )
2024-06-21 00:35:14 +02:00
Max Schmitt
1ebd20a47b
chore: .NET generator fixes ( #31401 )
2024-06-20 23:33:46 +02:00
Yury Semikhatsky
95fc2b8a8b
feat(fetch): maxRetries for fetch ( #31386 )
...
Fixes https://github.com/microsoft/playwright/issues/30978
2024-06-19 18:10:14 -07:00
Yury Semikhatsky
a2b116aa39
fix(trace): ensure har entry _monotonicTime is always start time ( #31385 )
...
* Revert harTracer change from
aeba083da0https://github.com/microsoft/playwright/issues/31133
2024-06-19 15:06:20 -07:00
Playwright Service
45ee318673
feat(firefox): roll to r1456 ( #31375 )
...
Fixes https://github.com/microsoft/playwright/issues/31328
Fixes https://github.com/microsoft/playwright/issues/30837
---------
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
2024-06-19 19:03:58 +02:00
Max Schmitt
8ba4cff10f
devops: add headless new to flakiness dashboard ( #31381 )
2024-06-19 18:08:22 +02:00
Dmitry Gozman
6ae9adfa4f
test: add "clock" to the metadata for dashboard traceability ( #31370 )
2024-06-18 14:56:08 -07:00
Dmitry Gozman
ac90a47b73
fix(click): do not retarget <a> to the parent <label> ( #31368 )
...
Fixes #31359 .
2024-06-18 12:12:19 -07:00
Andrey Lushnikov
ee7b5e6315
test: make sure main page recording continues after popup closes ( #31365 )
...
References https://github.com/microsoft/playwright/issues/30837
2024-06-18 10:29:41 -07:00
Max Schmitt
02416877da
test: rebase golden snapshots on Chromium macOS arm64 ( #31344 )
2024-06-18 19:09:24 +02:00
Yury Semikhatsky
dbc54c763d
test: delete tests for non-existing fastForwardTo ( #31366 )
...
The tests repeat `it.describe('fastForward'` above them.
2024-06-18 09:34:32 -07:00
Max Schmitt
5fc56283a6
fix(clock): throw for invalid date ( #31356 )
...
Fixes https://github.com/microsoft/playwright/issues/31354
2024-06-18 18:23:55 +02:00
Max Schmitt
f05b4daa2f
fix(clock): under reused context ( #31357 )
...
We uninstall all the setInitScript but forgot to mark `installed` as
`false`.
Fixes https://github.com/microsoft/playwright/issues/31353
2024-06-18 18:21:33 +02:00
Andrey Lushnikov
acf1b1f88c
test: add test reduced motion reset ( #31364 )
...
References https://github.com/microsoft/playwright/issues/31328
2024-06-18 09:01:35 -07:00
Dmitry Gozman
a002572dd2
test: update some test conditions ( #31336 )
2024-06-17 10:20:57 -07:00
Pavel Feldman
2a7f17d820
chore: fix simulated clock bots ( #31301 )
2024-06-17 09:17:38 -07:00
Fumiaki MATSUSHIMA
838c572209
fix: select issue in Windows with Edge ( #31270 )
2024-06-17 10:28:07 +02:00
Dmitry Gozman
2ae2fb421c
chore: roll stable test runner to 1.45.0-beta-1718411373000 ( #31326 )
2024-06-14 19:43:35 -07:00
Yury Semikhatsky
76ba94bce6
test: postBody for intercepted fetch FormData with Blob ( #31321 )
...
Fixes https://github.com/microsoft/playwright/issues/24077
2024-06-14 13:30:22 -07:00
Playwright Service
cf85905f44
feat(webkit): roll to r2035 ( #31308 )
2024-06-14 10:49:50 +02:00
Dmitry Gozman
d0b052e1e0
fix(chromium): pass --enable-gpu when running headless ( #30937 )
...
Fixes #30585 .
2024-06-13 11:27:17 -07:00
Pavel Feldman
897f7449ef
fix(clock): fix pauseAt to arrive at wall time ( #31297 )
2024-06-13 10:21:00 -07:00
Dmitry Gozman
b9106a4c42
fix(test runner): do not use @babel/plugin-transform-dynamic-import ( #31285 )
...
Historically, this plugin was important to translate dynamic imports
into require calls so that we can intercept them and transpile.
This is not needed anymore with ESM loader enabled by default, so we can
avoid this transformation and support dynamic imports of ESM-only
packages/files.
Fixes #17075 , fixes #23255 , fixes #31140 , references #23662 .
2024-06-13 06:18:44 -07:00
Yury Semikhatsky
9a31821411
test: disable page-drag tests in headed linux ( #31280 )
...
The tests have been flaking across browsers apparently due to stray
mouse event sent by the OS.
See
https://devops.playwright.dev/flakiness.html#filter_spec=page%2Fpage-drag.spec.ts&show_flaky=true×tamp=1718225128508
2024-06-12 15:09:56 -07:00
Max Schmitt
fbb44b043b
test: skip folder upload tests on macOS-12 and Android ( #31281 )
2024-06-12 23:58:36 +02:00
Max Schmitt
dcf4e4e054
feat: allow folder uploads ( #31165 )
2024-06-12 22:20:18 +02:00
Yury Semikhatsky
f1475fa644
chore: trim multiline step titles to first line ( #31269 )
...
Fixes https://github.com/microsoft/playwright/issues/31266
2024-06-12 08:24:12 -07:00
Dmitry Gozman
f115ba85d9
test: add more edge-case tests for clock ( #31256 )
2024-06-11 16:43:44 -07:00
Playwright Service
e07b46883d
feat(webkit): roll to r2029 ( #31257 )
2024-06-11 22:14:30 +02:00
Pavel Feldman
2b257ea963
chore(clock): introduce pauseAt ( #31255 )
2024-06-11 12:51:00 -07:00
Pavel Feldman
6399e8de4e
chore: clock api review ( #31237 )
2024-06-11 09:42:15 -07:00
Yury Semikhatsky
c08000b967
feat(chromium): storage-access permission ( #31239 )
...
Fixes https://github.com/microsoft/playwright/issues/31227
2024-06-11 09:18:45 -07:00
