cherry-pick(#20336): Revert "chore: respect headless option when reusing browser (#19980)" (#20340)

This reverts commit e674ea217f.

package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "playwright-internal",
-  "version": "1.30.0-next",
+  "version": "1.30.0",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "playwright-internal",
-      "version": "1.30.0-next",
+      "version": "1.30.0",
       "license": "Apache-2.0",
       "workspaces": [
         "packages/*"
@@ -5903,11 +5903,11 @@
       "version": "0.0.0"
     },
     "packages/playwright": {
-      "version": "1.30.0-next",
+      "version": "1.30.0",
       "hasInstallScript": true,
       "license": "Apache-2.0",
       "dependencies": {
-        "playwright-core": "1.30.0-next"
+        "playwright-core": "1.30.0"
       },
       "bin": {
         "playwright": "cli.js"
@@ -5917,11 +5917,11 @@
       }
     },
     "packages/playwright-chromium": {
-      "version": "1.30.0-next",
+      "version": "1.30.0",
       "hasInstallScript": true,
       "license": "Apache-2.0",
       "dependencies": {
-        "playwright-core": "1.30.0-next"
+        "playwright-core": "1.30.0"
       },
       "bin": {
         "playwright": "cli.js"
@@ -5931,7 +5931,7 @@
       }
     },
     "packages/playwright-core": {
-      "version": "1.30.0-next",
+      "version": "1.30.0",
       "license": "Apache-2.0",
       "bin": {
         "playwright": "cli.js"
@@ -5942,10 +5942,10 @@
     },
     "packages/playwright-ct-react": {
       "name": "@playwright/experimental-ct-react",
-      "version": "1.30.0-next",
+      "version": "1.30.0",
       "license": "Apache-2.0",
       "dependencies": {
-        "@playwright/test": "1.30.0-next",
+        "@playwright/test": "1.30.0",
         "@vitejs/plugin-react": "^3.0.0",
         "vite": "^4.0.3"
       },
@@ -5955,10 +5955,10 @@
     },
     "packages/playwright-ct-solid": {
       "name": "@playwright/experimental-ct-solid",
-      "version": "1.30.0-next",
+      "version": "1.30.0",
       "license": "Apache-2.0",
       "dependencies": {
-        "@playwright/test": "1.30.0-next",
+        "@playwright/test": "1.30.0",
         "vite": "^4.0.3",
         "vite-plugin-solid": "^2.5.0"
       },
@@ -5971,10 +5971,10 @@
     },
     "packages/playwright-ct-svelte": {
       "name": "@playwright/experimental-ct-svelte",
-      "version": "1.30.0-next",
+      "version": "1.30.0",
       "license": "Apache-2.0",
       "dependencies": {
-        "@playwright/test": "1.30.0-next",
+        "@playwright/test": "1.30.0",
         "@sveltejs/vite-plugin-svelte": "^2.0.2",
         "vite": "^4.0.3"
       },
@@ -6007,10 +6007,10 @@
     },
     "packages/playwright-ct-vue": {
       "name": "@playwright/experimental-ct-vue",
-      "version": "1.30.0-next",
+      "version": "1.30.0",
       "license": "Apache-2.0",
       "dependencies": {
-        "@playwright/test": "1.30.0-next",
+        "@playwright/test": "1.30.0",
         "@vitejs/plugin-vue": "^4.0.0",
         "vite": "^4.0.3"
       },
@@ -6056,10 +6056,10 @@
     },
     "packages/playwright-ct-vue2": {
       "name": "@playwright/experimental-ct-vue2",
-      "version": "1.30.0-next",
+      "version": "1.30.0",
       "license": "Apache-2.0",
       "dependencies": {
-        "@playwright/test": "1.30.0-next",
+        "@playwright/test": "1.30.0",
         "@vitejs/plugin-vue2": "^2.2.0",
         "vite": "^4.0.3"
       },
@@ -6071,11 +6071,11 @@
       }
     },
     "packages/playwright-firefox": {
-      "version": "1.30.0-next",
+      "version": "1.30.0",
       "hasInstallScript": true,
       "license": "Apache-2.0",
       "dependencies": {
-        "playwright-core": "1.30.0-next"
+        "playwright-core": "1.30.0"
       },
       "bin": {
         "playwright": "cli.js"
@@ -6086,11 +6086,11 @@
     },
     "packages/playwright-test": {
       "name": "@playwright/test",
-      "version": "1.30.0-next",
+      "version": "1.30.0",
       "license": "Apache-2.0",
       "dependencies": {
         "@types/node": "*",
-        "playwright-core": "1.30.0-next"
+        "playwright-core": "1.30.0"
       },
       "bin": {
         "playwright": "cli.js"
@@ -6100,11 +6100,11 @@
       }
     },
     "packages/playwright-webkit": {
-      "version": "1.30.0-next",
+      "version": "1.30.0",
       "hasInstallScript": true,
       "license": "Apache-2.0",
       "dependencies": {
-        "playwright-core": "1.30.0-next"
+        "playwright-core": "1.30.0"
       },
       "bin": {
         "playwright": "cli.js"
@@ -6848,7 +6848,7 @@
     "@playwright/experimental-ct-react": {
       "version": "file:packages/playwright-ct-react",
       "requires": {
-        "@playwright/test": "1.30.0-next",
+        "@playwright/test": "1.30.0",
         "@vitejs/plugin-react": "^3.0.0",
         "vite": "^4.0.3"
       }
@@ -6856,7 +6856,7 @@
     "@playwright/experimental-ct-solid": {
       "version": "file:packages/playwright-ct-solid",
       "requires": {
-        "@playwright/test": "1.30.0-next",
+        "@playwright/test": "1.30.0",
         "solid-js": "^1.4.7",
         "vite": "^4.0.3",
         "vite-plugin-solid": "^2.5.0"
@@ -6865,7 +6865,7 @@
     "@playwright/experimental-ct-svelte": {
       "version": "file:packages/playwright-ct-svelte",
       "requires": {
-        "@playwright/test": "1.30.0-next",
+        "@playwright/test": "1.30.0",
         "@sveltejs/vite-plugin-svelte": "^2.0.2",
         "svelte": "^3.49.0",
         "vite": "^4.0.3"
@@ -6889,7 +6889,7 @@
     "@playwright/experimental-ct-vue": {
       "version": "file:packages/playwright-ct-vue",
       "requires": {
-        "@playwright/test": "1.30.0-next",
+        "@playwright/test": "1.30.0",
         "@vitejs/plugin-vue": "^4.0.0",
         "vite": "^4.0.3"
       },
@@ -6924,7 +6924,7 @@
     "@playwright/experimental-ct-vue2": {
       "version": "file:packages/playwright-ct-vue2",
       "requires": {
-        "@playwright/test": "1.30.0-next",
+        "@playwright/test": "1.30.0",
         "@vitejs/plugin-vue2": "^2.2.0",
         "vite": "^4.0.3",
         "vue": "^2.7.13"
@@ -6934,7 +6934,7 @@
       "version": "file:packages/playwright-test",
       "requires": {
         "@types/node": "*",
-        "playwright-core": "1.30.0-next"
+        "playwright-core": "1.30.0"
       }
     },
     "@sindresorhus/is": {
@@ -9044,13 +9044,13 @@
     "playwright": {
       "version": "file:packages/playwright",
       "requires": {
-        "playwright-core": "1.30.0-next"
+        "playwright-core": "1.30.0"
       }
     },
     "playwright-chromium": {
       "version": "file:packages/playwright-chromium",
       "requires": {
-        "playwright-core": "1.30.0-next"
+        "playwright-core": "1.30.0"
       }
     },
     "playwright-core": {
@@ -9059,13 +9059,13 @@
     "playwright-firefox": {
       "version": "file:packages/playwright-firefox",
       "requires": {
-        "playwright-core": "1.30.0-next"
+        "playwright-core": "1.30.0"
       }
     },
     "playwright-webkit": {
       "version": "file:packages/playwright-webkit",
       "requires": {
-        "playwright-core": "1.30.0-next"
+        "playwright-core": "1.30.0"
       }
     },
     "postcss": {

package.json

@@ -1,7 +1,7 @@
 {
   "name": "playwright-internal",
   "private": true,
-  "version": "1.30.0-next",
+  "version": "1.30.0",
   "description": "A high-level API to automate web browsers",
   "repository": "github:Microsoft/playwright",
   "homepage": "https://playwright.dev",

packages/playwright-chromium/package.json

@@ -1,6 +1,6 @@
 {
   "name": "playwright-chromium",
-  "version": "1.30.0-next",
+  "version": "1.30.0",
   "description": "A high-level API to automate Chromium",
   "repository": "github:Microsoft/playwright",
   "homepage": "https://playwright.dev",
@@ -28,6 +28,6 @@
     "install": "node install.js"
   },
   "dependencies": {
-    "playwright-core": "1.30.0-next"
+    "playwright-core": "1.30.0"
   }
 }

packages/playwright-core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "playwright-core",
-  "version": "1.30.0-next",
+  "version": "1.30.0",
   "description": "A high-level API to automate web browsers",
   "repository": "github:Microsoft/playwright",
   "homepage": "https://playwright.dev",

packages/playwright-core/src/remote/playwrightConnection.ts

@@ -220,7 +220,10 @@ export class PlaywrightConnection {
     }
 
     if (!browser) {
-      browser = await playwright[(this._options.browserName || 'chromium') as 'chromium'].launch(serverSideCallMetadata(), this._options.launchOptions);
+      browser = await playwright[(this._options.browserName || 'chromium') as 'chromium'].launch(serverSideCallMetadata(), {
+        ...this._options.launchOptions,
+        headless: !!process.env.PW_DEBUG_CONTROLLER_HEADLESS,
+      });
       browser.on(Browser.Events.Disconnected, () => {
         // Underlying browser did close for some reason - force disconnect the client.
         this.close({ code: 1001, reason: 'Browser closed' });
@@ -284,6 +287,8 @@ function launchOptionsHash(options: LaunchOptions) {
     if (copy[key] === defaultLaunchOptions[key])
       delete copy[key];
   }
+  for (const key of optionsThatAllowBrowserReuse)
+    delete copy[key];
   return JSON.stringify(copy);
 }
 
@@ -295,3 +300,7 @@ const defaultLaunchOptions: LaunchOptions = {
   headless: true,
   devtools: false,
 };
+
+const optionsThatAllowBrowserReuse: (keyof LaunchOptions)[] = [
+  'headless',
+];

packages/playwright-ct-react/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@playwright/experimental-ct-react",
-  "version": "1.30.0-next",
+  "version": "1.30.0",
   "description": "Playwright Component Testing for React",
   "repository": "github:Microsoft/playwright",
   "homepage": "https://playwright.dev",
@@ -27,7 +27,7 @@
   },
   "dependencies": {
     "@vitejs/plugin-react": "^3.0.0",
-    "@playwright/test": "1.30.0-next",
+    "@playwright/test": "1.30.0",
     "vite": "^4.0.3"
   }
 }

packages/playwright-ct-solid/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@playwright/experimental-ct-solid",
-  "version": "1.30.0-next",
+  "version": "1.30.0",
   "description": "Playwright Component Testing for Solid",
   "repository": "github:Microsoft/playwright",
   "homepage": "https://playwright.dev",
@@ -28,7 +28,7 @@
   "dependencies": {
     "vite": "^4.0.3",
     "vite-plugin-solid": "^2.5.0",
-    "@playwright/test": "1.30.0-next"
+    "@playwright/test": "1.30.0"
   },
   "devDependencies": {
     "solid-js": "^1.4.7"

packages/playwright-ct-svelte/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@playwright/experimental-ct-svelte",
-  "version": "1.30.0-next",
+  "version": "1.30.0",
   "description": "Playwright Component Testing for Svelte",
   "repository": "github:Microsoft/playwright",
   "homepage": "https://playwright.dev",
@@ -26,7 +26,7 @@
     }
   },
   "dependencies": {
-    "@playwright/test": "1.30.0-next",
+    "@playwright/test": "1.30.0",
     "@sveltejs/vite-plugin-svelte": "^2.0.2",
     "vite": "^4.0.3"
   },

packages/playwright-ct-vue/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@playwright/experimental-ct-vue",
-  "version": "1.30.0-next",
+  "version": "1.30.0",
   "description": "Playwright Component Testing for Vue",
   "repository": "github:Microsoft/playwright",
   "homepage": "https://playwright.dev",
@@ -27,7 +27,7 @@
   },
   "dependencies": {
     "@vitejs/plugin-vue": "^4.0.0",
-    "@playwright/test": "1.30.0-next",
+    "@playwright/test": "1.30.0",
     "vite": "^4.0.3"
   }
 }

packages/playwright-ct-vue2/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@playwright/experimental-ct-vue2",
-  "version": "1.30.0-next",
+  "version": "1.30.0",
   "description": "Playwright Component Testing for Vue2",
   "repository": "github:Microsoft/playwright",
   "homepage": "https://playwright.dev",
@@ -26,7 +26,7 @@
     }
   },
   "dependencies": {
-    "@playwright/test": "1.30.0-next",
+    "@playwright/test": "1.30.0",
     "@vitejs/plugin-vue2": "^2.2.0",
     "vite": "^4.0.3"
   },

packages/playwright-firefox/package.json

@@ -1,6 +1,6 @@
 {
   "name": "playwright-firefox",
-  "version": "1.30.0-next",
+  "version": "1.30.0",
   "description": "A high-level API to automate Firefox",
   "repository": "github:Microsoft/playwright",
   "homepage": "https://playwright.dev",
@@ -28,6 +28,6 @@
     "install": "node install.js"
   },
   "dependencies": {
-    "playwright-core": "1.30.0-next"
+    "playwright-core": "1.30.0"
   }
 }

packages/playwright-test/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@playwright/test",
-  "version": "1.30.0-next",
+  "version": "1.30.0",
   "description": "A high-level API to automate web browsers",
   "repository": "github:Microsoft/playwright",
   "homepage": "https://playwright.dev",
@@ -33,6 +33,6 @@
   "license": "Apache-2.0",
   "dependencies": {
     "@types/node": "*",
-    "playwright-core": "1.30.0-next"
+    "playwright-core": "1.30.0"
   }
 }

packages/playwright-webkit/package.json

@@ -1,6 +1,6 @@
 {
   "name": "playwright-webkit",
-  "version": "1.30.0-next",
+  "version": "1.30.0",
   "description": "A high-level API to automate WebKit",
   "repository": "github:Microsoft/playwright",
   "homepage": "https://playwright.dev",
@@ -28,6 +28,6 @@
     "install": "node install.js"
   },
   "dependencies": {
-    "playwright-core": "1.30.0-next"
+    "playwright-core": "1.30.0"
   }
 }

packages/playwright/package.json

@@ -1,6 +1,6 @@
 {
   "name": "playwright",
-  "version": "1.30.0-next",
+  "version": "1.30.0",
   "description": "A high-level API to automate web browsers",
   "repository": "github:Microsoft/playwright",
   "homepage": "https://playwright.dev",
@@ -28,6 +28,6 @@
     "install": "node install.js"
   },
   "dependencies": {
-    "playwright-core": "1.30.0-next"
+    "playwright-core": "1.30.0"
   }
 }

tests/library/debug-controller.spec.ts

@@ -30,6 +30,7 @@ type Fixtures = {
 
 const test = baseTest.extend<Fixtures>({
   wsEndpoint: async ({ }, use) => {
+    process.env.PW_DEBUG_CONTROLLER_HEADLESS = '1';
     const server = new PlaywrightServer({ path: '/' + createGuid(), maxConnections: Number.MAX_VALUE, enableSocksProxy: false });
     const wsEndpoint = await server.listen();
     await use(wsEndpoint);