playwright/.github/workflows
Max Schmitt 4a67437704
devops(gha): move from always() to !cancelled() (#30060)
**Investigation:**

- According to
[here](https://github.com/microsoft/playwright/actions/runs/8351676198),
the job got cancelled, because someone force-pushed and another commit
took priority.
- We have `if: always()` for uploading the blobs, even if they are
cancelled. We expect, that the task before (`npx playwright test`)
finished writing the blob, but it didn't - cancelled in between. We
still upload - a broken one.
- We download the broken zip and it breaks from there on.

Proposed change: Instead of uploading always, upload if it did not get
cancelled.

Quoting from the GitHub Actions docs about `always()`:

> Warning: Avoid using always for any task that could suffer from a
critical failure, for example: getting sources, otherwise the workflow
may hang until it times out. If you want to run a job or step regardless
of its success or failure, use the recommended alternative: if: `${{
!cancelled() }}`

This is phase 1/2 where it changes our code to use this new condition.
The actual roll-out happens once it works for us.

Relates https://github.com/microsoft/playwright/issues/29451
2024-03-22 19:25:13 +01:00
..
cherry_pick_into_release_branch.yml devops: fix cherry_pick_into_release_branch permissions (#29689) 2024-02-27 17:34:16 +01:00
create_test_report.yml devops: bump GitHub Actions workflow actions (#29219) 2024-01-29 19:22:44 +01:00
infra.yml devops: bump GitHub Actions workflow actions (#29219) 2024-01-29 19:22:44 +01:00
merge.config.ts devops: call merge-reports with explicit config (#27965) 2023-11-03 13:49:32 -07:00
pr_check_client_side_changes.yml devops: fix pr_check_client_side_changes workflow (#28847) 2024-01-03 13:15:50 -08:00
publish_canary.yml devops: do not publish sha-X Docker images (#29433) 2024-02-09 09:07:10 -08:00
publish_release_docker.yml devops: do not publish sha-X Docker images (#29433) 2024-02-09 09:07:10 -08:00
publish_release_driver.yml devops: bump GitHub Actions workflow actions (#29219) 2024-01-29 19:22:44 +01:00
publish_release_npm.yml devops(gha): move from always() to !cancelled() (#30060) 2024-03-22 19:25:13 +01:00
publish_release_traceviewer.yml devops: bump GitHub Actions workflow actions (#29219) 2024-01-29 19:22:44 +01:00
roll_browser_into_playwright.yml devops: fix roll into PR action (#29318) 2024-02-02 14:16:56 +01:00
roll_driver_nodejs.yml devops: bump GitHub Actions workflow actions (#29219) 2024-01-29 19:22:44 +01:00
tests_components.yml devops: bump GitHub Actions workflow actions (#29219) 2024-01-29 19:22:44 +01:00
tests_electron.yml devops(gha): move from always() to !cancelled() (#30060) 2024-03-22 19:25:13 +01:00
tests_primary.yml devops(gha): move from always() to !cancelled() (#30060) 2024-03-22 19:25:13 +01:00
tests_secondary.yml devops(gha): move from always() to !cancelled() (#30060) 2024-03-22 19:25:13 +01:00
tests_service.yml devops(gha): move from always() to !cancelled() (#30060) 2024-03-22 19:25:13 +01:00
tests_stress.yml devops(gha): move from always() to !cancelled() (#30060) 2024-03-22 19:25:13 +01:00
tests_video.yml devops(gha): move from always() to !cancelled() (#30060) 2024-03-22 19:25:13 +01:00
tests_webview2.yml devops(gha): move from always() to !cancelled() (#30060) 2024-03-22 19:25:13 +01:00
trigger_tests.yml devops: update repo for internal tests 2022-10-30 21:33:30 -07:00