Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity
playwright/tests/playwright-test
History
Max Schmitt 4431a8366d
fix: collect stdio from forked processes (#27074) 
A summary about the attempts we tried in
https://github.com/microsoft/playwright/pull/26931 for
https://github.com/microsoft/playwright/issues/26859 and
https://github.com/microsoft/playwright/issues/24591.

1. attempt: collect all the stdio from the worker host.
- this made it hard to capture the live console logs for the live trace
2. attempt: collect all the stdio from the worker host, but keep
proxying `process.{stdout,stderr}.write`.
- this solved the live console logs problem, since we could still listen
on them
- we found out about a race that the stdout/stderr streams can still
buffer data while the test already had finished
- we created a best effort flush implementation but didn't like the
complexity it introduced to the project
3. attempt: keep things like they are but also listen to stdio from the
worker host
- this solves the race of console.log in the test (things stay like they
are)
    - this keeps live trace working (things stay like they are)
- a known pitfall is that it could result in logs which don't end up in
the reporter onStdOut/onStdErr, but it is already a significant
improvement over how it was before.
      - before: they were not getting displayed
- after: they are getting displayed and there is a low likelihood that
they don't end up in the reporter API if the write happens slightly
before a test finished.

Closes #26931
Fixes #26859
Fixes #24591
2023-09-14 18:34:26 +02:00
..
__screenshots__/playwright.artifacts.spec.ts feat: allow options in automatic screenshots (#19143) 2022-12-07 08:45:33 -08:00
assets chore: allow calling spawnSync on Node.js file inside test (#26429) 2023-08-11 18:37:14 +02:00
stable-test-runner chore: roll stable test runner to 1.38 beta (#27066) 2023-09-13 16:01:06 -07:00
access-data.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
babel.spec.ts chore: allow marking scripts as external for transform (#23449) 2023-06-01 20:28:49 -07:00
basic.spec.ts fix(test.fail): expect() failure should not skip future tests (#26663) 2023-08-24 08:32:14 -07:00
command-line-filter.spec.ts chore: remove unnecessary args in ttest (#21012) 2023-02-18 13:08:17 -08:00
config.spec.ts chore: allow merging defineConfig (#26390) 2023-08-09 17:23:34 -07:00
decorators.spec.ts chore: allow ts decorators (#22080) 2023-03-29 20:43:08 -07:00
deps.spec.ts chore: fix .only in dependent tests (#26503) 2023-08-16 13:39:08 -07:00
esm.spec.ts chore: allow calling spawnSync on Node.js file inside test (#26429) 2023-08-11 18:37:14 +02:00
exit-code.spec.ts fix: collect stdio from forked processes (#27074) 2023-09-14 18:34:26 +02:00
expect-configure.spec.ts chore: remove expect.configure({poll}) (#23060) 2023-05-16 18:45:03 -07:00
expect-poll.spec.ts chore: show last poller error on test timeout (#24292) 2023-07-18 17:03:26 -07:00
expect-soft.spec.ts chore: introduce expect.configure (#22533) 2023-04-25 10:29:56 -07:00
expect-to-pass.spec.ts chore: show last poller error on test timeout (#24292) 2023-07-18 17:03:26 -07:00
expect.spec.ts feat(expect): narrow down available assertions for Page/Locator/APIResponse (#26658) 2023-08-23 13:14:39 -07:00
fixture-errors.spec.ts Revert "chore: refactor timeout manager to use scopes (1) (#24315)" (#24382) 2023-07-24 14:09:20 -07:00
fixtures.spec.ts fix(test runner): separate test fixture scope for beforeAll/afterAll hooks (#22746) 2023-05-02 11:04:51 -07:00
gitignore.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
global-setup.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
golden.spec.ts feat: deprecate toMatchSnapshot for buffers (#26718) 2023-08-25 18:20:01 -07:00
hooks.spec.ts test: unflake "beforeAll and afterAll should have a separate timeout" (#23263) 2023-05-24 13:46:28 -07:00
list-files.spec.ts chore: remove output dir before each test (#23380) 2023-05-30 16:03:50 -07:00
list-mode.spec.ts chore: ensure error location is present (#22804) 2023-05-03 18:45:33 -07:00
loader.spec.ts chore: tolerate css imports (#26626) 2023-08-23 08:32:23 -07:00
match-grep.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
max-failures.spec.ts fix(test runner): extract FailureTracker helper (#26757) 2023-08-31 15:32:29 -07:00
override-timeout.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
playwright-test-fixtures.ts chore: make @playwright/test depend on playwright (#26946) 2023-09-08 14:23:35 -07:00
playwright.artifacts.spec.ts Revert "fix: do not collide with other tests when test names have special chars (#23414)" (#24213) 2023-07-13 20:03:02 +02:00
playwright.config.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
playwright.config.ts fix(blob report): default location relative to package.json (#24481) 2023-07-28 15:49:31 -07:00
playwright.connect.spec.ts fix: remove connectInsteadOfLaunching (#26828) 2023-08-31 15:29:04 -07:00
playwright.ct-build.spec.ts chore: do not add plugins to config twice (#26670) 2023-08-24 16:19:57 -07:00
playwright.ct-react.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
playwright.fetch.spec.ts test: unflake "should stop tracing on requestContext.dispose()" (#23489) 2023-06-02 16:37:50 -07:00
playwright.reuse.browser.spec.ts fix: encode launch options correctly when reusing browser (#24174) 2023-07-12 16:40:55 +02:00
playwright.reuse.spec.ts fix(trace): render items under expect.toPass (#24016) 2023-07-05 11:20:28 -07:00
playwright.spec.ts fix(tracing): unclash trace names between test and hooks (#27063) 2023-09-13 19:56:40 -07:00
playwright.trace.spec.ts chore: use custom expect message in trace step (#26752) 2023-08-28 14:48:24 -07:00
playwright.unhandled.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
repeat-each.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
reporter-attachment.spec.ts Revert "fix: do not collide with other tests when test names have special chars (#23414)" (#24213) 2023-07-13 20:03:02 +02:00
reporter-base.spec.ts feat: print message if maxFailures has reached (#26322) 2023-08-25 19:06:49 +02:00
reporter-blob.spec.ts chore: make @playwright/test depend on playwright (#26946) 2023-09-08 14:23:35 -07:00
reporter-dot.spec.ts chore: run more reporter tests through blob report, some fixes (#23765) 2023-06-16 21:30:55 -07:00
reporter-github.spec.ts chore: run more reporter tests through blob report, some fixes (#23765) 2023-06-16 21:30:55 -07:00
reporter-html.spec.ts feat: make it possible to filter by column in HTML report (#27020) 2023-09-12 22:13:15 +02:00
reporter-json.spec.ts chore: remove usesCustomOutputDir from tests (#21011) 2023-02-18 11:41:41 -08:00
reporter-junit.spec.ts chore(merge): console status updates (#24559) 2023-08-02 14:49:06 -07:00
reporter-line.spec.ts chore: run more reporter tests through blob report, some fixes (#23765) 2023-06-16 21:30:55 -07:00
reporter-list.spec.ts chore: more network panel polish (#26780) 2023-08-29 22:20:28 -07:00
reporter-markdown.spec.ts chore: remove details from markdown reports (#26961) 2023-09-08 17:49:34 -07:00
reporter-onend.spec.ts feat(onEnd): allow overriding the exit code (#27010) 2023-09-12 13:37:30 -07:00
reporter.spec.ts chore: make @playwright/test depend on playwright (#26946) 2023-09-08 14:23:35 -07:00
resolver.spec.ts fix(resolver): allow importing packages with non-index main script (#26692) 2023-08-24 14:09:00 -07:00
retry.spec.ts fix(test runner): failed + skipped = flaky (#26385) 2023-08-09 16:35:14 -07:00
runner.spec.ts chore: make @playwright/test depend on playwright (#26946) 2023-09-08 14:23:35 -07:00
shard.spec.ts feat(shard): introduce mode: 'default' (#23023) 2023-05-18 13:07:22 -07:00
snapshot-path-template.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
stdio.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
store.spec.ts chore: hide store from public (#21763) 2023-03-17 11:50:44 -07:00
test-extend.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
test-grep.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
test-ignore.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
test-info.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
test-modifiers.spec.ts fix(test runner): make sure static annotations are reported for skipped tests (#26634) 2023-08-23 08:40:12 -07:00
test-output-dir.spec.ts Revert "fix: do not collide with other tests when test names have special chars (#23414)" (#24213) 2023-07-13 20:03:02 +02:00
test-parallel.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
test-serial.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
test-step.spec.ts fix(steps): only propagate soft errors up the hierarchy (#24054) 2023-07-05 15:30:53 -07:00
test-use.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00
timeout.spec.ts test: unflake some tests (#23984) 2023-06-30 13:08:18 -07:00
to-have-screenshot.spec.ts fix: use snapshotPath instead of expectedPath for image diffs (#24567) 2023-08-07 04:42:35 -07:00
types-2.spec.ts tet: unflake some test runner tests (#23240) 2023-05-23 13:31:23 -07:00
types.spec.ts chore: update typescript to 5.1.3 (#23461) 2023-06-02 18:57:09 +02:00
ui-mode-fixtures.ts chore: flaky tests fixes (#26714) 2023-08-25 12:43:50 -07:00
ui-mode-test-attachments.spec.ts chore: fix ui mode to show screenshots (#26563) 2023-08-20 14:47:18 -07:00
ui-mode-test-ct.spec.ts chore: do not add plugins to config twice (#26670) 2023-08-24 16:19:57 -07:00
ui-mode-test-filters.spec.ts test(ui-mode): make retries (#23136) 2023-05-18 11:28:28 -07:00
ui-mode-test-output.spec.ts chore: implement faster ansi2html format for console (#26826) 2023-09-01 09:09:47 -07:00
ui-mode-test-progress.spec.ts chore: store scroll positions in trace viewer (#26938) 2023-09-07 17:14:39 -07:00
ui-mode-test-run.spec.ts chore: remove output dir before each test (#23380) 2023-05-30 16:03:50 -07:00
ui-mode-test-screencast.spec.ts chore: flaky tests fixes (#26714) 2023-08-25 12:43:50 -07:00
ui-mode-test-setup.spec.ts fix(ui-mode): run teardown handlers with Command + C (#24267) 2023-07-19 17:50:25 +02:00
ui-mode-test-source.spec.ts test(ui-mode): make retries (#23136) 2023-05-18 11:28:28 -07:00
ui-mode-test-tree.spec.ts chore: enable no-floating-promises ESLint rule for tests (#23376) 2023-06-02 21:59:12 +02:00
ui-mode-test-update.spec.ts test(ui-mode): make retries (#23136) 2023-05-18 11:28:28 -07:00
ui-mode-test-watch.spec.ts test(ui-mode): make retries (#23136) 2023-05-18 11:28:28 -07:00
ui-mode-trace.spec.ts chore: store scroll positions in trace viewer (#26938) 2023-09-07 17:14:39 -07:00
watch.spec.ts chore: make @playwright/test depend on playwright (#26946) 2023-09-08 14:23:35 -07:00
web-server.spec.ts chore: make @playwright/test depend on playwright (#26946) 2023-09-08 14:23:35 -07:00
worker-index.spec.ts test: remove magic headers in ttest (#20867) 2023-02-14 19:20:56 -08:00