playwright/.github
Max Schmitt 4a67437704
devops(gha): move from always() to !cancelled() (#30060)
**Investigation:**

- According to
[here](https://github.com/microsoft/playwright/actions/runs/8351676198),
the job got cancelled, because someone force-pushed and another commit
took priority.
- We have `if: always()` for uploading the blobs, even if they are
cancelled. We expect, that the task before (`npx playwright test`)
finished writing the blob, but it didn't - cancelled in between. We
still upload - a broken one.
- We download the broken zip and it breaks from there on.

Proposed change: Instead of uploading always, upload if it did not get
cancelled.

Quoting from the GitHub Actions docs about `always()`:

> Warning: Avoid using always for any task that could suffer from a
critical failure, for example: getting sources, otherwise the workflow
may hang until it times out. If you want to run a job or step regardless
of its success or failure, use the recommended alternative: if: `${{
!cancelled() }}`

This is phase 1/2 where it changes our code to use this new condition.
The actual roll-out happens once it works for us.

Relates https://github.com/microsoft/playwright/issues/29451
2024-03-22 19:25:13 +01:00
..
actions devops(gha): move from always() to !cancelled() (#30060) 2024-03-22 19:25:13 +01:00
dummy-package-files-for-dependents-analytics chore: add dummy playwright-test package for GitHub Dependents (#7134) 2021-06-15 10:16:48 +02:00
ISSUE_TEMPLATE devops: add a hint how to create a repro (#29665) 2024-02-26 13:33:57 -08:00
workflows devops(gha): move from always() to !cancelled() (#30060) 2024-03-22 19:25:13 +01:00