4a67437704
**Investigation:** - According to [here](https://github.com/microsoft/playwright/actions/runs/8351676198), the job got cancelled, because someone force-pushed and another commit took priority. - We have `if: always()` for uploading the blobs, even if they are cancelled. We expect, that the task before (`npx playwright test`) finished writing the blob, but it didn't - cancelled in between. We still upload - a broken one. - We download the broken zip and it breaks from there on. Proposed change: Instead of uploading always, upload if it did not get cancelled. Quoting from the GitHub Actions docs about `always()`: > Warning: Avoid using always for any task that could suffer from a critical failure, for example: getting sources, otherwise the workflow may hang until it times out. If you want to run a job or step regardless of its success or failure, use the recommended alternative: if: `${{ !cancelled() }}` This is phase 1/2 where it changes our code to use this new condition. The actual roll-out happens once it works for us. Relates https://github.com/microsoft/playwright/issues/29451
45 lines
1.7 KiB
YAML
45 lines
1.7 KiB
YAML
name: 'Download artifacts'
|
|
description: 'Download artifacts from GitHub'
|
|
inputs:
|
|
namePrefix:
|
|
description: 'Name prefix of the artifacts to download'
|
|
required: true
|
|
default: 'blob-report'
|
|
path:
|
|
description: 'Directory with downloaded artifacts'
|
|
required: true
|
|
default: '.'
|
|
runs:
|
|
using: "composite"
|
|
steps:
|
|
- name: Create temp downloads dir
|
|
shell: bash
|
|
run: mkdir -p '${{ inputs.path }}/artifacts'
|
|
- name: Download artifacts
|
|
uses: actions/github-script@v7
|
|
with:
|
|
script: |
|
|
console.log(`downloading artifacts for workflow_run: ${context.payload.workflow_run.id}`);
|
|
console.log(`workflow_run: ${JSON.stringify(context.payload.workflow_run, null, 2)}`);
|
|
const allArtifacts = await github.paginate(github.rest.actions.listWorkflowRunArtifacts, {
|
|
...context.repo,
|
|
run_id: context.payload.workflow_run.id
|
|
});
|
|
console.log('total = ', allArtifacts.length);
|
|
const artifacts = allArtifacts.filter(a => a.name.startsWith('${{ inputs.namePrefix }}'));
|
|
const fs = require('fs');
|
|
for (const artifact of artifacts) {
|
|
const result = await github.rest.actions.downloadArtifact({
|
|
...context.repo,
|
|
artifact_id: artifact.id,
|
|
archive_format: 'zip'
|
|
});
|
|
console.log('downloaded artifact', result);
|
|
fs.writeFileSync(`${{ inputs.path }}/artifacts/${artifact.name}.zip`, Buffer.from(result.data));
|
|
}
|
|
- name: Unzip artifacts
|
|
shell: bash
|
|
run: |
|
|
unzip -n '${{ inputs.path }}/artifacts/*.zip' -d ${{ inputs.path }}
|
|
rm -rf '${{ inputs.path }}/artifacts'
|