playwright/packages/playwright-core/src/cli
Max Schmitt e1e69cbbcc
fix(cli): pdf/screenshot did not save artifacts (#21352)
As of today we support CLI argument wise `--save-storage` and
`--save-har` in pdf/screenshot CLI command. But they are not working,
since we just close the browser rather than the context where we take
care of saving the artifacts.

`launchContext` has 4 usages:

- open/codegen there closing the browser / `SIGINT` will close it
gracefully
- pdf/screenshot there we will now close the page which will then
[here](b00579edb7/packages/playwright-core/src/cli/cli.ts?q=cli.ts#L503)
close the browser.

I did not find any tests except the [installation
test](3e84ab4701/tests/installation/playwright-cli-screenshot-should-work.spec.ts),
I'm happy to add one for both command if requested.

Fixes https://github.com/microsoft/playwright/issues/20718
2023-03-02 22:05:39 +01:00
..
cli.ts fix(cli): pdf/screenshot did not save artifacts (#21352) 2023-03-02 22:05:39 +01:00
DEPS.list test: remove service2 mode and experimental-grid (#20730) 2023-02-07 14:19:37 -08:00
driver.ts chore: remove separate network tethering client connection (#20267) 2023-01-21 18:18:22 -08:00