Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity
playwright/packages/playwright-core
History
Max Schmitt 6d7d37061d
fix(recorder): Locator picker had wrong initial language in language bindings (#27706) 
**Description**

When a language port was using Inspector with the "Locator Picker"
feature, it only recognised JavaScript as a language by default. As a
workaround the user was able to click record, interact with the page and
then the language would be correctly used -> csharp e.g. would work in
the "Locator Picker".

**Why?**

Our language bindings are setting `PW_LANG_NAME=<sdkLanguage>` env var
-> good. Our recorder harness also uses this along its internal state
here:


b9b289b641/packages/playwright-core/src/server/recorder.ts (L369)

and it gets used here (no parameter means: we use the first language
aka. primary language):


b9b289b641/packages/playwright-core/src/server/recorder.ts (L95)

The only issue is that the Inspector frontend in the beginning does not
know which language it should use and pass over to the server side, it
then falls back to JavaScript.

**Proposed fix**

Instead of passing it over from the frontend to the server side, we just
always use it from the server side, aka. "currentLanguage". When the
user switches languages in the frontend, "currentLanguage" already gets
updated properly via the "fileChanged" event.

https://github.com/microsoft/playwright-dotnet/issues/2718

---------

Signed-off-by: Max Schmitt <max@schmitt.mx>
2023-10-22 13:02:14 +02:00
..
bin chore: enhance download/install logic of branded browsers (#26806) 2023-08-31 22:48:07 +02:00
bundles chore: remove glob dependency from utils bundle (#24291) 2023-07-19 05:17:34 +02:00
src fix(recorder): Locator picker had wrong initial language in language bindings (#27706) 2023-10-22 13:02:14 +02:00
types chore: break dowload.path() to throw (#27662) 2023-10-17 12:56:56 -07:00
.eslintrc.js lint: prevent object string concatenation (#23172) 2023-05-19 15:17:43 -07:00
.npmignore chore: fix installation tests (#26602) 2023-08-22 16:48:52 +02:00
browsers.json feat(chromium-tip-of-tree): roll to r1161 (#27705) 2023-10-19 16:44:36 +02:00
cli.js chore: fix playwright-core cli (#23203) 2023-05-22 12:37:08 -07:00
index.d.ts chore: migrate to monorepo (#9421) 2021-10-11 16:52:17 +02:00
index.js chore: refactored minimum Node Major version to variable (#24188) 2023-07-18 19:57:48 +02:00
index.mjs fix: export request from index.jsm (#13158) 2022-03-30 09:35:47 -07:00
package.json chore: mark 1.40.0-next (#27538) 2023-10-10 16:10:28 -07:00
README.md chore: drop dependency on playwright-core in all our packages (#2318) 2020-05-21 13:18:15 -07:00
ThirdPartyNotices.txt chore: remove glob dependency from utils bundle (#24291) 2023-07-19 05:17:34 +02:00

README.md

playwright-core

This package contains the no-browser flavor of Playwright.