playwright/packages
Rui Figueira 73ffaf65d7
fix(codegen): fill action prevents omnibox navigation recording (#29790)
This PR is a fix proposal for a bug when trying to record a omnibox
navigation after a recorded action (e.g., `fill`).

The following test, included in this PR, reproduces the problem:

```ts
  test('should record omnibox navigations after recordAction', async ({ page, openRecorder, server }) => {
    const recorder = await openRecorder();
    await recorder.setContentAndWait(`<textarea></textarea>`);
    await Promise.all([
      recorder.waitForOutput('JavaScript', 'fill'),
      page.locator('textarea').fill('Hello world'),
    ]);
    // for performed actions, 5 seconds is the time needed to ensure they are committed
    await page.waitForTimeout(5000);
    await page.goto(server.PREFIX + `/empty.html`);
    await recorder.waitForOutput('JavaScript', `await page.goto('${server.PREFIX}/empty.html');`);
  });
```

After performed actions (e.g., `click`), it successfully records the
navigation as long as there's at least a 5 sec. gap between both
actions. That happens because after that 5 sec. interval the performed
action is automatically commited and therefore the navigation is not
stored as a signal of that action.

The proposed fix for recorded actions also forces that action to be
automatically commited after 5 sec (for testing, I'm using 500ms to
speed up the test execution).
2024-03-04 12:31:03 -08:00
..
html-reporter chore: do not use project id in telereporter (#29776) 2024-03-01 21:44:08 -08:00
playwright chore: iterate towards tele reporter reuse in vscode (#29803) 2024-03-04 11:08:40 -08:00
playwright-browser-chromium chore: mark 1.43.0-next (#29670) 2024-02-26 16:45:25 -08:00
playwright-browser-firefox chore: mark 1.43.0-next (#29670) 2024-02-26 16:45:25 -08:00
playwright-browser-webkit chore: mark 1.43.0-next (#29670) 2024-02-26 16:45:25 -08:00
playwright-chromium fix: point to the right cli program export (#29715) 2024-02-28 14:05:42 -08:00
playwright-core fix(codegen): fill action prevents omnibox navigation recording (#29790) 2024-03-04 12:31:03 -08:00
playwright-ct-core fix(ct): stop-gap for shared file import (#29744) 2024-02-29 19:13:32 -08:00
playwright-ct-react chore: remove pw- binaries from ct (#29754) 2024-02-29 16:50:00 -08:00
playwright-ct-react17 chore: remove pw- binaries from ct (#29754) 2024-02-29 16:50:00 -08:00
playwright-ct-solid chore: remove pw- binaries from ct (#29754) 2024-02-29 16:50:00 -08:00
playwright-ct-svelte chore: remove pw- binaries from ct (#29754) 2024-02-29 16:50:00 -08:00
playwright-ct-vue chore: remove pw- binaries from ct (#29754) 2024-02-29 16:50:00 -08:00
playwright-ct-vue2 chore: remove pw- binaries from ct (#29754) 2024-02-29 16:50:00 -08:00
playwright-firefox fix: point to the right cli program export (#29715) 2024-02-28 14:05:42 -08:00
playwright-test chore: mark 1.43.0-next (#29670) 2024-02-26 16:45:25 -08:00
playwright-webkit fix: point to the right cli program export (#29715) 2024-02-28 14:05:42 -08:00
protocol/src feat(playwright-core): add remove cookies api (#29698) 2024-03-02 07:27:01 -08:00
recorder fix(recorder): reference Language enum for recorderTypes (#29294) 2024-02-01 13:48:30 -08:00
trace/src feat(trace): show target point for raw mouse apis (#28459) 2023-12-07 06:27:49 -08:00
trace-viewer chore: inject string pool into the tele receiver (#29781) 2024-03-04 08:46:32 -08:00
web chore: polish network panel highlight (#29299) 2024-02-01 13:44:26 -08:00
.eslintrc.js chore: replace process.exit with graceful closure (#24242) 2023-07-24 08:29:29 -07:00