Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity
playwright/packages/playwright-core
History
Andrey Lushnikov 9105a20ac4
fix: remove window.stop() from page.setContent() implementation (#26886) 
The call was added back in 2019 to stop network loading. See commit:
56a48559c2

However, there's no evidence that this call is needed any more:
- all the tests pass without it
- `window.stop()` behavior is poorly defined, so relying on it is
unfortunate.

The `window.stop()` call, however, causes trouble while rolling firefox:
under certain condititions, the call prevents document from firing the
`load` event in the `document.open().write(..).close()` sequence that
comes immediately after the call. While this does look like a bug in
Firefox itself, we failed to reproduce it in isolation.

For the reference, the following tests fail with the Firefox 116 (using
`PWTEST_TRACE=1` triggers the race condition somewhere):

```bash
PWTEST_TRACE=1 npm run ftest cli-codegen
```
2023-09-06 11:02:38 -07:00
..
bin chore: enhance download/install logic of branded browsers (#26806) 2023-08-31 22:48:07 +02:00
bundles chore: remove glob dependency from utils bundle (#24291) 2023-07-19 05:17:34 +02:00
src fix: remove window.stop() from page.setContent() implementation (#26886) 2023-09-06 11:02:38 -07:00
types feat(chromium): roll to r1077 (#26709) 2023-08-25 19:31:19 +02:00
.eslintrc.js lint: prevent object string concatenation (#23172) 2023-05-19 15:17:43 -07:00
.npmignore chore: fix installation tests (#26602) 2023-08-22 16:48:52 +02:00
browsers.json feat(chromium-tip-of-tree): roll to r1148 (#26904) 2023-09-06 18:15:32 +02:00
cli.js chore: fix playwright-core cli (#23203) 2023-05-22 12:37:08 -07:00
index.d.ts chore: migrate to monorepo (#9421) 2021-10-11 16:52:17 +02:00
index.js chore: refactored minimum Node Major version to variable (#24188) 2023-07-18 19:57:48 +02:00
index.mjs fix: export request from index.jsm (#13158) 2022-03-30 09:35:47 -07:00
package.json chore: cut 1.37.0 branch (#26357) 2023-08-09 01:46:29 -07:00
README.md chore: drop dependency on playwright-core in all our packages (#2318) 2020-05-21 13:18:15 -07:00
ThirdPartyNotices.txt chore: remove glob dependency from utils bundle (#24291) 2023-07-19 05:17:34 +02:00

README.md

playwright-core

This package contains the no-browser flavor of Playwright.