4a67437704
**Investigation:** - According to [here](https://github.com/microsoft/playwright/actions/runs/8351676198), the job got cancelled, because someone force-pushed and another commit took priority. - We have `if: always()` for uploading the blobs, even if they are cancelled. We expect, that the task before (`npx playwright test`) finished writing the blob, but it didn't - cancelled in between. We still upload - a broken one. - We download the broken zip and it breaks from there on. Proposed change: Instead of uploading always, upload if it did not get cancelled. Quoting from the GitHub Actions docs about `always()`: > Warning: Avoid using always for any task that could suffer from a critical failure, for example: getting sources, otherwise the workflow may hang until it times out. If you want to run a job or step regardless of its success or failure, use the recommended alternative: if: `${{ !cancelled() }}` This is phase 1/2 where it changes our code to use this new condition. The actual roll-out happens once it works for us. Relates https://github.com/microsoft/playwright/issues/29451
49 lines
1.3 KiB
YAML
49 lines
1.3 KiB
YAML
name: "electron"
|
|
|
|
on:
|
|
push:
|
|
branches:
|
|
- main
|
|
- release-*
|
|
pull_request:
|
|
paths-ignore:
|
|
- 'browser_patches/**'
|
|
- 'docs/**'
|
|
types: [ labeled ]
|
|
branches:
|
|
- main
|
|
- release-*
|
|
|
|
env:
|
|
# Force terminal colors. @see https://www.npmjs.com/package/colors
|
|
FORCE_COLOR: 1
|
|
FLAKINESS_CONNECTION_STRING: ${{ secrets.FLAKINESS_CONNECTION_STRING }}
|
|
|
|
jobs:
|
|
test_electron:
|
|
name: ${{ matrix.os }}
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
os: [ubuntu-latest, macos-latest, windows-latest]
|
|
runs-on: ${{ matrix.os }}
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- uses: actions/setup-node@v4
|
|
with:
|
|
node-version: 18
|
|
- run: npm ci
|
|
env:
|
|
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
|
|
- run: npm run build
|
|
- run: npx playwright install --with-deps chromium
|
|
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run etest
|
|
if: matrix.os == 'ubuntu-latest'
|
|
- run: npm run etest
|
|
if: matrix.os != 'ubuntu-latest'
|
|
- run: node tests/config/checkCoverage.js electron
|
|
if: ${{ !cancelled() && matrix.os == 'ubuntu-latest' }}
|
|
- run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json
|
|
if: ${{ !cancelled() }}
|
|
shell: bash
|